summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorFelix Fietkau <nbd@openwrt.org>2012-09-06 16:53:50 +0200
committerFelix Fietkau <nbd@openwrt.org>2012-09-06 16:54:38 +0200
commit3b5a5c3e99a4ceb1428d58aecc38d5adf9438541 (patch)
treed05700d8757f3aefd8ac93ffed6b12cb46ef9f1b
parentc58e7f45ec4e32db109ffb12d22745133a3b1068 (diff)
do not prematurely release the main dev on link loss, should fix DHCP NAK handling
-rw-r--r--interface.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/interface.c b/interface.c
index 4a42ad9..2456227 100644
--- a/interface.c
+++ b/interface.c
@@ -170,8 +170,6 @@ interface_event(struct interface *iface, enum interface_event ev)
static void
interface_flush_state(struct interface *iface)
{
- if (iface->main_dev.dev)
- device_release(&iface->main_dev);
if (iface->l3_dev.dev)
device_release(&iface->l3_dev);
interface_data_flush(iface);
@@ -404,6 +402,8 @@ interface_proto_cb(struct interface_proto_state *state, enum interface_proto_eve
netifd_log_message(L_NOTICE, "Interface '%s' is now down\n", iface->name);
mark_interface_down(iface);
+ if (iface->main_dev.dev)
+ device_release(&iface->main_dev);
interface_handle_config_change(iface);
break;
case IFPEV_LINK_LOST: