From 03c77dafe3cfb922b995adfe9c0f8a75c98a18af Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Fri, 27 Nov 2020 20:54:18 +0100 Subject: treewide: transition div tables to actual table markup Modern browsers allow decomposing table markup equally well as nested div constructs, therefor migrate our
table markup to actual tags but keep the old table/tr/th/td CSS classes for now to allow for a smooth theme transition. Signed-off-by: Jo-Philipp Wich --- .../resources/view/status/include/80_upnp.js | 18 +++++++++--------- .../htdocs/luci-static/resources/view/upnp/upnp.js | 18 +++++++++--------- 2 files changed, 18 insertions(+), 18 deletions(-) (limited to 'applications/luci-app-upnp') diff --git a/applications/luci-app-upnp/htdocs/luci-static/resources/view/status/include/80_upnp.js b/applications/luci-app-upnp/htdocs/luci-static/resources/view/status/include/80_upnp.js index 608929c700..b5446ecb6c 100644 --- a/applications/luci-app-upnp/htdocs/luci-static/resources/view/status/include/80_upnp.js +++ b/applications/luci-app-upnp/htdocs/luci-static/resources/view/status/include/80_upnp.js @@ -38,15 +38,15 @@ return baseclass.extend({ render: function(data) { - var table = E('div', { 'class': 'table', 'id': 'upnp_status_table' }, [ - E('div', { 'class': 'tr table-titles' }, [ - E('div', { 'class': 'th' }, _('Protocol')), - E('div', { 'class': 'th' }, _('External Port')), - E('div', { 'class': 'th' }, _('Client Address')), - E('div', { 'class': 'th' }, _('Host')), - E('div', { 'class': 'th' }, _('Client Port')), - E('div', { 'class': 'th' }, _('Description')), - E('div', { 'class': 'th cbi-section-actions' }, '') + var table = E('table', { 'class': 'table', 'id': 'upnp_status_table' }, [ + E('tr', { 'class': 'tr table-titles' }, [ + E('th', { 'class': 'th' }, _('Protocol')), + E('th', { 'class': 'th' }, _('External Port')), + E('th', { 'class': 'th' }, _('Client Address')), + E('th', { 'class': 'th' }, _('Host')), + E('th', { 'class': 'th' }, _('Client Port')), + E('th', { 'class': 'th' }, _('Description')), + E('th', { 'class': 'th cbi-section-actions' }, '') ]) ]); diff --git a/applications/luci-app-upnp/htdocs/luci-static/resources/view/upnp/upnp.js b/applications/luci-app-upnp/htdocs/luci-static/resources/view/upnp/upnp.js index 5780bcc469..e0a326d4fc 100644 --- a/applications/luci-app-upnp/htdocs/luci-static/resources/view/upnp/upnp.js +++ b/applications/luci-app-upnp/htdocs/luci-static/resources/view/upnp/upnp.js @@ -78,15 +78,15 @@ return view.extend({ s = m.section(form.GridSection, '_active_rules'); s.render = L.bind(function(view, section_id) { - var table = E('div', { 'class': 'table cbi-section-table', 'id': 'upnp_status_table' }, [ - E('div', { 'class': 'tr table-titles' }, [ - E('div', { 'class': 'th' }, _('Protocol')), - E('div', { 'class': 'th' }, _('External Port')), - E('div', { 'class': 'th' }, _('Client Address')), - E('div', { 'class': 'th' }, _('Host')), - E('div', { 'class': 'th' }, _('Client Port')), - E('div', { 'class': 'th' }, _('Description')), - E('div', { 'class': 'th cbi-section-actions' }, '') + var table = E('table', { 'class': 'table cbi-section-table', 'id': 'upnp_status_table' }, [ + E('tr', { 'class': 'tr table-titles' }, [ + E('th', { 'class': 'th' }, _('Protocol')), + E('th', { 'class': 'th' }, _('External Port')), + E('th', { 'class': 'th' }, _('Client Address')), + E('th', { 'class': 'th' }, _('Host')), + E('th', { 'class': 'th' }, _('Client Port')), + E('th', { 'class': 'th' }, _('Description')), + E('th', { 'class': 'th cbi-section-actions' }, '') ]) ]); -- cgit v1.2.3