From 03c77dafe3cfb922b995adfe9c0f8a75c98a18af Mon Sep 17 00:00:00 2001 From: Jo-Philipp Wich Date: Fri, 27 Nov 2020 20:54:18 +0100 Subject: treewide: transition div tables to actual table markup Modern browsers allow decomposing table markup equally well as nested div constructs, therefor migrate our
table markup to actual tags but keep the old table/tr/th/td CSS classes for now to allow for a smooth theme transition. Signed-off-by: Jo-Philipp Wich --- .../luci-static/resources/view/nlbw/display.js | 80 +++++++++++----------- 1 file changed, 40 insertions(+), 40 deletions(-) (limited to 'applications/luci-app-nlbwmon/htdocs/luci-static/resources/view/nlbw/display.js') diff --git a/applications/luci-app-nlbwmon/htdocs/luci-static/resources/view/nlbw/display.js b/applications/luci-app-nlbwmon/htdocs/luci-static/resources/view/nlbw/display.js index 1b654d7bca..6d57c12c5c 100644 --- a/applications/luci-app-nlbwmon/htdocs/luci-static/resources/view/nlbw/display.js +++ b/applications/luci-app-nlbwmon/htdocs/luci-static/resources/view/nlbw/display.js @@ -609,14 +609,14 @@ return view.extend({ ]) ]) ]), - E('div', { 'class': 'table' }, [ - E('div', { 'class': 'tr table-titles' }, [ - E('div', { 'class': 'th' }, label || col), - E('div', { 'class': 'th' }, _('Conn.')), - E('div', { 'class': 'th' }, _('Down. (Bytes)')), - E('div', { 'class': 'th' }, _('Down. (Pkts.)')), - E('div', { 'class': 'th' }, _('Up. (Bytes)')), - E('div', { 'class': 'th' }, _('Up. (Pkts.)')), + E('table', { 'class': 'table' }, [ + E('tr', { 'class': 'tr table-titles' }, [ + E('th', { 'class': 'th' }, label || col), + E('th', { 'class': 'th' }, _('Conn.')), + E('th', { 'class': 'th' }, _('Down. (Bytes)')), + E('th', { 'class': 'th' }, _('Down. (Pkts.)')), + E('th', { 'class': 'th' }, _('Up. (Bytes)')), + E('th', { 'class': 'th' }, _('Up. (Pkts.)')), ]) ]) ]); @@ -841,18 +841,18 @@ return view.extend({ ]) ]), - E('div', { 'class': 'table', 'id': 'host-data' }, [ - E('div', { 'class': 'tr table-titles' }, [ - E('div', { 'class': 'th left hostname' }, [ _('Host') ]), - E('div', { 'class': 'th right' }, [ _('MAC') ]), - E('div', { 'class': 'th right' }, [ _('Connections') ]), - E('div', { 'class': 'th right' }, [ _('Download (Bytes)') ]), - E('div', { 'class': 'th right' }, [ _('Download (Packets)') ]), - E('div', { 'class': 'th right' }, [ _('Upload (Bytes)') ]), - E('div', { 'class': 'th right' }, [ _('Upload (Packets)') ]), + E('table', { 'class': 'table', 'id': 'host-data' }, [ + E('tr', { 'class': 'tr table-titles' }, [ + E('th', { 'class': 'th left hostname' }, [ _('Host') ]), + E('th', { 'class': 'th right' }, [ _('MAC') ]), + E('th', { 'class': 'th right' }, [ _('Connections') ]), + E('th', { 'class': 'th right' }, [ _('Download (Bytes)') ]), + E('th', { 'class': 'th right' }, [ _('Download (Packets)') ]), + E('th', { 'class': 'th right' }, [ _('Upload (Bytes)') ]), + E('th', { 'class': 'th right' }, [ _('Upload (Packets)') ]), ]), - E('div', { 'class': 'tr placeholder' }, [ - E('div', { 'class': 'td' }, [ + E('tr', { 'class': 'tr placeholder' }, [ + E('td', { 'class': 'td' }, [ E('em', { 'class': 'spinning' }, [ _('Collecting data...') ]) ]) ]) @@ -881,17 +881,17 @@ return view.extend({ ]) ]), - E('div', { 'class': 'table', 'id': 'layer7-data' }, [ - E('div', { 'class': 'tr table-titles' }, [ - E('div', { 'class': 'th left' }, [ _('Application') ]), - E('div', { 'class': 'th right' }, [ _('Connections') ]), - E('div', { 'class': 'th right' }, [ _('Download (Bytes)') ]), - E('div', { 'class': 'th right' }, [ _('Download (Packets)') ]), - E('div', { 'class': 'th right' }, [ _('Upload (Bytes)') ]), - E('div', { 'class': 'th right' }, [ _('Upload (Packets)') ]), + E('table', { 'class': 'table', 'id': 'layer7-data' }, [ + E('tr', { 'class': 'tr table-titles' }, [ + E('th', { 'class': 'th left' }, [ _('Application') ]), + E('th', { 'class': 'th right' }, [ _('Connections') ]), + E('th', { 'class': 'th right' }, [ _('Download (Bytes)') ]), + E('th', { 'class': 'th right' }, [ _('Download (Packets)') ]), + E('th', { 'class': 'th right' }, [ _('Upload (Bytes)') ]), + E('th', { 'class': 'th right' }, [ _('Upload (Packets)') ]), ]), - E('div', { 'class': 'tr placeholder' }, [ - E('div', { 'class': 'td' }, [ + E('tr', { 'class': 'tr placeholder' }, [ + E('td', { 'class': 'td' }, [ E('em', { 'class': 'spinning' }, [ _('Collecting data...') ]) ]) ]) @@ -920,18 +920,18 @@ return view.extend({ ]) ]), - E('div', { 'class': 'table', 'id': 'ipv6-data' }, [ - E('div', { 'class': 'tr table-titles' }, [ - E('div', { 'class': 'th left' }, [ _('Host') ]), - E('div', { 'class': 'th right' }, [ _('MAC') ]), - E('div', { 'class': 'th double right hide-xs' }, [ _('Family') ]), - E('div', { 'class': 'th double right' }, [ _('Download (Bytes)') ]), - E('div', { 'class': 'th double right' }, [ _('Download (Packets)') ]), - E('div', { 'class': 'th double right' }, [ _('Upload (Bytes)') ]), - E('div', { 'class': 'th double right' }, [ _('Upload (Packets)') ]), + E('table', { 'class': 'table', 'id': 'ipv6-data' }, [ + E('tr', { 'class': 'tr table-titles' }, [ + E('th', { 'class': 'th left' }, [ _('Host') ]), + E('th', { 'class': 'th right' }, [ _('MAC') ]), + E('th', { 'class': 'th double right hide-xs' }, [ _('Family') ]), + E('th', { 'class': 'th double right' }, [ _('Download (Bytes)') ]), + E('th', { 'class': 'th double right' }, [ _('Download (Packets)') ]), + E('th', { 'class': 'th double right' }, [ _('Upload (Bytes)') ]), + E('th', { 'class': 'th double right' }, [ _('Upload (Packets)') ]), ]), - E('div', { 'class': 'tr placeholder' }, [ - E('div', { 'class': 'td' }, [ + E('tr', { 'class': 'tr placeholder' }, [ + E('td', { 'class': 'td' }, [ E('em', { 'class': 'spinning' }, [ _('Collecting data...') ]) ]) ]) -- cgit v1.2.3