Age | Commit message (Collapse) | Author |
|
Add ucode template equivalents for the Lua templates used by the theme.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
this let browser automatically fill according to HTML spec for input elements.
luci-theme-bootstrap and luci-base are affected.
Signed-off-by: Viktor Tsvetkov <zwetvik@gmail.com>
[indentation fix]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Optimized PNG filesize from 733 to 592 bytes without any quality loss.
Signed-off-by: Alexander Semukhin <semukhin@mail.com>
|
|
- Make control-group containers flex and ensure proper spacing between
elements, fixes e.g. unwanted break for reveal/hide password button
on narrow mobile views
- Decrease top margin of modal popups
- Fix displaying cell titles on mobile wrapped table rows
- Tune mobile flex table styles
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Restore accidentally removed the initramfs boot warning banner.
Ref: https://github.com/openwrt/luci/commit/8055acc9be89f0bed31b6692ad08e6196611d478#commitcomment-73447330
Fixes: 8055acc9be ("luci-theme-bootstrap: overhaul styles")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Fixes: #5743
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Fixes: #5693
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Fixes: c81b09ec3d ("luci-theme-bootstrap: simplify login dialog")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Use an traditional HTML form with post submit action to the same URL in
order to simplify the login process and not rely on the discarded login
XHR reply properly setting the login cookie.
This will also avoid one useless request on login and hopefully fix login
issues reported with various browser environments.
As a bonus, the resulting code is somewhat smaller as well.
Ref: https://forum.openwrt.org/t/login-does-not-work/113360
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Prevent the log output textareas to touch the footer border.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Ref: https://github.com/openwrt/luci/commit/b11a7d8e4940a3f68b93c5d93f16c900c9371bc2#commitcomment-60968071
Fixes: 8055acc9be ("luci-theme-bootstrap: overhaul styles")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
- Add proper top and bottom margin for tab descriptions
- Allow flex wrapping for cbi-value rows
- Ensure that nested table/grid sections always take the full width
- Make table/grid section row action buttons are as narrow as possible
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Since the removal of the clearfix styles, overlong captions will displace
subsequent input field rows.
Fix the issue by replace floating label + field margin with flexbox styles.
Fixes: #5535
Fixes: 8055acc9be ("luci-theme-bootstrap: overhaul styles")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Only enable scrollbars if content overflows.
Fixes: #5505
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
- Use the proper dialog class name to apply changelog styles
- Darken grey background and borders
Fixes: 5bd111f58f ("luci-theme-bootstrap: fix uci changelog and readonly input styles")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
- Rework uci changelog styling rules to work with unmodified markup
- Drop redundant readonly input styles, don't fade readonly input texts
Fixes: 8055acc9be ("luci-theme-bootstrap: overhaul styles")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Revert to the previous uci-defaults behaviour of only setting the
selected theme to Bootstrap if the Bootstrap entry didn't exist yet
in the configuration.
Ref: https://forum.openwrt.org/t/luci-theme-behaviour-change/112047
Fixes: ed86f03a9f ("luci-theme-bootstrap: add explicit dark/light mode selection")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
- Fix progress bar shadow in light mode
- Fix color schema preference in light and dark modes
Fixes: #5498
Fixes: #5499
Fixes: ed86f03a9f ("luci-theme-bootstrap: add explicit dark/light mode selection")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Register two further "virtual" themes called BootstrapDark and
BootstrapLight which force dark and light mode respectively.
The actual Bootstrap theme itself will continue to auto-select
dark mode preference based on OS/Browser preference settings.
Fixes: #5492
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Ref: https://github.com/openwrt/luci/commit/26047fb967f079000ab61c7377f8e26e11277569#commitcomment-58638390
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Fixed overlay display failures for users on mobile, or users who booted
up in safe mode XD. Noticeable when vertical or horizontal real-estate
is too small for the displayed overlay.
This failure is most evident when you "edit" an interface, or display
your unsaved changes.
When content is wider than the screen view, the table hugs the (widest)
content maximally, and the overlay window becomes scrollable.
Disabled -webkit-overflow-scrolling, left, and right, because both FF
and Safari disable them as invalid anyway.
Signed-off-by: Paul Dee <systemcrash@users.noreply.github.com>
[Merge duplicate modal declarations, remove not applicable modal
flexbox properties]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Fixes: 588e24f9ca ("luci-theme-bootstrap: various tweaks and cleanups")
Ref: https://github.com/openwrt/luci/commit/588e24f9ca68de074c4d085ec99fd8c96ad0a3ed#r58625289
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
- introduce new variable --text-color-highest which results in #000/#fff
for bright and dark modes respectively
- drop unused navigation style rules and selectors
- use sticky positioning for header bar and drop top margin hacks
- use flex box layout for header bar contents
- use uniform line-height for button elements instead of pixel paddings
- fix too bright .cbi-value bottom border in mobile dark mode
- avoid rendering duplicate .cbi-value bottom borders for nested sections
- simplify header markup, get rid of unused container elements
- use non-wrapping flex box layout for page actions, prioritize primary
action button in automatic width calculation
- fix border radius of ifacebox headers
- use brightest color for log output textareas
- fix dark mode colors for mode menu
- use flex layout for footer
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Fixes: #5405
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Add a dark theme variant which is enabled by default when
prefers-color-scheme is set to dark.
Signed-off-by: Teoh Han Hui <teohhanhui@gmail.com>
|
|
Some devices offer a full LuCI interface from their recovery interface.
As it's read-only it should only be used for installing sysupgrades and
therefore warn users that no settings are saved.
Signed-off-by: Paul Spooren <mail@aparcar.org>
|
|
Fix themes for broken display of advanced button in the sysupgrade modal.
Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
This calls striptags() on the hostname to prevent any XSS over the
hostname. This should fix CVE-2021-33425 as far as I understood it.
If someone adds some Javascript into system.@system[0].hostname it would
have been directly added to the page, this prevents the problem.
This can only be exploited by someone being able to modify the uci
configuration, normally a user with such privileges could also just
modify the webpage.
Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
|
|
The still referenced help.gif icon is absent by default since it has been
moved to luci-compat.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
* should fix #4647
Signed-off-by: Dirk Brenken <dev@brenken.org>
|
|
Remove the reference to setting a password being linked to SSH capability.
(SSH has been initially enabled since year 2015.)
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
In the Material theme, clicking on the logo takes you to the status page.
This seems logical, and is very helpful. But in Bootstrap, it doesn't
do anything, so just pulling the same href from Material to Bootstrap,
so the link works in Bootstrap as well.
Signed-off-by: Russell Morris <rmorris@rkmorris.us>
[adjust commit subject, squash commits]
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Utilize the LuCI.ui.menu class to load, traverse and cache the menu tree
in the local session store.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
set mediaurlbase only when it is the first time to be installed
|
|
If we build multi-themes into firmware, each of them set itself
to be the default theme, what theme should it be?
To make it clear, we only set mediaurlbase if the theme is the
first time to be installed/built-in.
This resolve the issue that theme always change to somewhat default
after upgrading the firmware even with a config-keep-upgrade
Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
|
|
Fixes: #3795
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Fixes: #3722
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
(cherry picked from commit 3b40c582baefcb302fb23ed633ed85ab1ac72a9e)
|
|
Fixes: #3757
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Ref: #3563
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
luci-theme-*: remove modal max-height #3383 v2
|