summaryrefslogtreecommitdiffhomepage
path: root/modules/luci-mod-system
AgeCommit message (Collapse)Author
2019-10-18luci-mod-system: leds.js: fix handling device optionJo-Philipp Wich
Since the modal overlay map was unable to read the current trigger value, it mistakingly allowed the removal of the device option value. Fix it by finding the option object through lookupOption() instead of relying on a reference. Fixes: #3216 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-10-16Merge pull request #3145 from ptpt52/refine-flash-resetJo-Philipp Wich
luci-mod-system: refine flash reset
2019-10-07luci-mod-system: flash.js: fix passing sysupgrade optsJo-Philipp Wich
Instead of binding the checked state to the button handler function, bind the underlying checkboxes instead to observe the actual user choice instead of the initial value. This fixes forcing sysupgrade or deselecting keep settings. Reported-by: Hannu Nyman <hannu.nyman@iki.fi> Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-10-07luci-mod-system: refine flash resetChen Minqiang
We determine flash reset capability by checking overlayfs in /proc/mounts Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
2019-10-07luci-app-advanced-reboot: import applyreboot template from luci-mod-systemJo-Philipp Wich
Since the advanced-reboot app is the sole remaining user of the applyreboot template, import it into this package to avoid the need for shipping it with the default installation. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-10-07luci-mod-system: port reboot view to client side jsJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-10-07luci-mod-system: use awaitReconnect() from ui.jsJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-10-07luci-mod-system: sshkeys.js: use common fs.js classJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-10-07luci-mod-system: startup.js: use common fs.js classJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-10-07luci-mod-system: flash.js: use common fs.js classJo-Philipp Wich
Also move the keep settings checkbox above the error messages in the sysupgrade confirmation dialog. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-10-07luci-mod-system: crontab.js: use common fs.js classJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-10-02luci-mod-system: flash.js: fix "rootfs_data" partition detectionJo-Philipp Wich
The `/sys/devices/virtual/mtd/` information is not available on all devices so rely on the contents of `/proc/mtd` instead to check for the existence of the `rootfs_data` partition. Fixes: #3136 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-10-02luci-mod-system: check for sysupgrade with backup possibilityRafał Miłecki
Some firmware images may not support preserving backup. In such cases display a warning and disable relevant checkbox. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2019-10-02luci-mod-system: check if it's possible to force sysupgradeRafał Miłecki
Some validation errors may be critical enough to prevent sysupgrade. Check the "forceable" property and disallow forcing sysupgrade if applicable. It would fail anyway at the "sysupgrade" call. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2019-10-02luci-mod-system: use "system" new "validate_firmware_image" ubus methodRafał Miłecki
This new ubus method provides more properly-formatted details about firmware file. Use it to check if uploaded image is valid. The old "sysupgrade --test" method is left for now to provide stderr output. Signed-off-by: Rafał Miłecki <rafal@milecki.pl> [Added missing ACL, add default value for the ubus failure case] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-30luci-mod-system: allow IPv6 addresses for external syslog serverJo-Philipp Wich
Fixes: #3126 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-27luci-mod-system: fix rerendering of ssh key list after add/removeJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-27luci-mod-system: allow deleting all NTP serversJo-Philipp Wich
Fixes: #3121 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-25luci-mod-system: flash.js: disable mtdblock downloads on mtd-less systemsJo-Philipp Wich
Ref: https://github.com/openwrt/luci/commit/3c40a7450a9b7d340cdc9e233818c63a8092fec2#commitcomment-35233073 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-25luci-mod-system: flash.js: rename handleReset to handleFirstbootJo-Philipp Wich
Rename the procedure to prevent a name clash with the standard view action which we intentionally disable. Ref: https://github.com/openwrt/luci/commit/3c40a7450a9b7d340cdc9e233818c63a8092fec2#commitcomment-35233207 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-25luci-mod-system: flash.js: improve storage size detection heuristicsJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-24luci-mod-system: system.js: use more concise label for use_dhcpJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-24luci-mod-system: system.js: expose use_dhcp NTP optionJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-24luci-mod-system: reimplement flashops as client side viewJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-24luci-mod-system: startup.js: fix syntax errorJo-Philipp Wich
Fixes: f3ff641d8 ("luci-mod-system: ensure that textarea contents are properly escaped") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-23luci-mod-system: ensure that textarea contents are properly escapedJo-Philipp Wich
Fixes: #3090 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-21luci-mod-system: remove unused controller actionsJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-21luci-mod-system: mounts.js: preload fstab uciJo-Philipp Wich
Preload the uci configuration on page load to avoid accidential double rendering of the globals section and mount overview table. Fixes: e39ab8725 ("luci-mod-system: mounts.js: implicitely create globals section") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-21luci-mod-system: mounts.js: implicitely create globals sectionJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-21luci-mod-system: remplement fstab settings as client side viewJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-18luci-mod-system: system.js: simplify btn actions, use feature flagsJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-18luci-mod-system: disable redundant page actions in crontab, startup viewsJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-17luci-mod-system: remplement dropbear settings as client side viewJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-16luci-mod-system: remplement password change as client side viewJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-15luci-mod-system: reimplement SSH key mgmt as client side viewJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-12luci-mod-system: improve LED configuration pageJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-12luci-mod-system: add heading to startup page, improve error reportingJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-12luci-mod-system: reimplent system/crontab as client side viewJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-12luci-mod-system: restore rc.local editing functionalityJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-09-12luci-mod-system: reimplent system/startup as client side viewJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-08-14luci-app-firewall: honour global default policies in per-zone settingsJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-07-25luci-mod-system: leds.js: fix crash when no usb devices or ports are presentJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-07-08luci-base,luci-mod-system: split ubus localtime into get and set callJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-07-07luci-mod-system: rework leds.js and system.js viewsJo-Philipp Wich
- Drop manual RPC batch usage - Use LuCI.Poll for status updates Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-07-07luci-mod-system: use client side cbi forms for system and led configJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-07-01luci-mod-system: fix flash activity trigger nameMartin Schiller
The former name "Flashmemory write access" is wrong. The triggers also indicate read/erase access to the flash memories. Signed-off-by: Martin Schiller <ms@dev.tdt.de>
2019-06-28luci-mod-system: fix some led trigger name translationsMartin Schiller
Signed-off-by: Martin Schiller <ms@dev.tdt.de>
2019-06-12luci-mod-system: prevent clearing rc.local on unrelated submit actionsJo-Philipp Wich
Fixes: #2760 Fixes: 1c09ee5e4 ("luci-mod-system: fix SimpleForm usage on file editing pages") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-06-05luci-mod-system: fix SimpleForm usage on file editing pagesJo-Philipp Wich
When a value identical to the stored one is submitted, the CBI framework will not emit an option write event and therfore not store the value in the form data dictionary passed to SimpleForm.handle(). This usage pattern usally works be accident for file editor views such as admin_system/crontab because \r\n windows style line endings are substituted with unix \n ones before writing the data, defeating the equality check in CBI. When a single line without trailing newline is submitted however, the CBI will not see a difference to the data stored in the file and clear out the value on subsequent saves. This commit alignes the logic used by various SimpleForm views to behave identically and predictable: - File data is handled in the SimpleForm.handle() callback - The forcewrite property is used to disable equality checks - Submission of an empty string empties the backing file Fixes: #2737 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2019-04-30Merge pull request #2620 from TDT-AG/pr/20190311-luci-mod-systemFlorian Eckert
luci-mod-system: add button to sync with ntp server