summaryrefslogtreecommitdiffhomepage
path: root/modules/luci-mod-network
AgeCommit message (Collapse)Author
2022-01-07luci-mod-network: fix reading back rpfilter configuration valueJo-Philipp Wich
Fixes: #5635 Fixes: faad7464a8 ("luci-mod-network: add support for network.device sections") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-12-09luci-mod-network: wireless.js: retain maclist contentsJo-Philipp Wich
Fixes: #5579 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-12-01luci-mod-network: allow IPv6 dns, dns_service and domain for RA only modeJo-Philipp Wich
Fixes: #5564 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-12-01luci-mod-network: fix loading ra_mtu and ra_hoplimit optionsJo-Philipp Wich
Fixes: #5565 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-12-01luci-mod-network: fix unbalanced and confusing markup in DHCP translationJo-Philipp Wich
The string `<%s>...<%s>` is invalid HTML and will confuse translation software like poedit as well as human translators. It is not clear that `<%s>...<%s>` is supposed to interpolate into both a start and end tag and `<%s>` might be mistaken as a quoted form of `%s` like `«%s»` or `〈%s〉`. Replace the string with `<a href="%s">...</a>` to make it immediately clear that the acronym is surrounded by an HTML anchor, only pass the destination URL via string formatting to avoid mistranslations there. Fixes: 3bfcf99a68 ("luci-mod-network: fix unbalanced and confusing markup in DHCP translation") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-12-01luci-mod-network: Disambiguate DNS config messagePaul Dee
Responses themselves are not RFC1918, but the address types that they contain may be. Signed-off-by: Paul Dee <itsascambutmailmeanyway@gmail.com>
2021-11-11luci-mod-network: use firewall.getZoneColorStyle() in interface viewJo-Philipp Wich
Use the new `firewall.getZoneColorStyle()` helper to apply background zone color styles to the interface boxes. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-10-31luci-mod-network: fix invalid markup in TFTP/PXE settings tabJo-Philipp Wich
Also resync translations accordingly. Fixes: #5475 Fixes: 3165d5ea3f ("luci-mod-network: Add PXE Boot options tab under DHCP and DNS") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-10-25luci-mod-network: Add PXE Boot options tab under DHCP and DNSPaul Dee
This commit adds support for managing `boot` sections in /etc/config/dhcp. Signed-off-by: Paul Dee <systemcrash@users.noreply.github.com> [Hide alias interfaces in network select, reword commit message] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-10-22luci-mod-network: remove related bridge-vlan sections on deleting deviceJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-10-19luci-mod-network: allow sorting static leasesJo-Philipp Wich
Fixes: #5453 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-10-12Merge pull request #5436 from vgaetera/dhcp-ipsetJo-Philipp Wich
2021-10-11luci-mod-network: diagnostics: remove leftover attributeJo-Philipp Wich
There is no `type` attribute for `select` elements. Fixes: 5ac9fd7b3b ("luci-mod-network: diagnostics: remove arp-scan install placeholder") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-10-11luci-mod-network: diagnostics: remove arp-scan install placeholderJo-Philipp Wich
We do not want to advertise functionality that is not installed as it may have been left out intentionally. Referring to "Missing" functionality is confusing in this case. It is also not comparable to missing protocol extension hints as those are backed by actual user configuration. Also replace the freetext input with a dropdown of known network devices as the hardcoded `br-lan` is not universally applicable to all setups. In general we want to avoid hardcoding defaults which might deviate from the system state. Finaly drop the superfluous width annotations and add a missing space to the RPC command declaration. Fixes: 22b7442011 ("luci-mod-admin-full: add arp-scan to network diagnostic") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-10-12luci-mod-network: support dhcp.ipset as sectionVladislav Grigoryev
Allow configuring ipset sections in the dhcp config: https://openwrt.org/docs/guide-user/base-system/dhcp#ip_sets This can also be combined with instance-specific IP sets: https://github.com/openwrt/luci/pull/5402 However, it makes easier to assign domains to IP sets. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-10-11luci-mod-admin-full: add arp-scan to network diagnosticPaul Spooren
This is a JavaScript rewrite of the PR#5152 It adds the ability to perform ARP scans if the tool `arp-scan` is installed. Signed-off-by: Paul Spooren <mail@aparcar.org>
2021-10-08luci-mod-network: spelling / grammarPaul Dee
"Setup" is a noun, the thing. "Set up" is a verbal idiom, the action. One cannot setup a DHCP server, just as one cannot fuckup a test, or ripup some paper. One can, however, set a DHCP server up, and one can fuck a test up, and rip some paper up. Signed-off-by: Paul Dee <systemcrash@users.noreply.github.com>
2021-10-08Merge pull request #5353 from vgaetera/fix-rule-src/dest-textvalueJo-Philipp Wich
luci-mod-network: fix src/dest textvalue for rules
2021-10-01luci-mod-network: support dhcp.dnsmasq.ipsetVladislav Grigoryev
Allow to modify the ipset option in the dhcp.dnsmasq config. This makes possible to populate IP sets with dnsmasq. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-09-27Merge pull request #5378 from vgaetera/dhcpv6-sourcefilterFlorian Eckert
luci-mod-network: support network.interface.sourcefilter
2021-09-27luci-mod-network: fix disabling 11w MFP for WPA3Jo-Philipp Wich
Fixes: #5394 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-09-23luci-mod-network: fix name of network.device.isolate uci optionJo-Philipp Wich
Fixes: #5383 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-09-22luci-mod-network: support network.interface.sourcefilterVladislav Grigoryev
Allow to modify the sourcefilter option in the network.interface config. This is required for custom policy routing with IPv6 MWAN and/or NAT6. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-09-10luci-mod-network: fix src/dest textvalue for rulesVladislav Grigoryev
Fix the incorrectly displayed src/dest textvalue for the rules. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-09-04luci-mod-network: fix route and rule optionsVladislav Grigoryev
Allow adding routes with unspecified interface. This is required for prohibit, blackhole and unreachable routes. Allow adding routes with loopback interface. This can work as a blackhole route. Fix netmask to prefix conversion for the routes. Identify the IP family by the UCI section type. Avoid setting the routing table textvalue for the rules. The rules should target none table unless specified otherwise. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-09-03Merge pull request #5008 from mpratt14/vlan-defaultFlorian Eckert
luci-mod-network: do not remove enable_vlan from config
2021-09-01luci-mod-network: network/routing support for pbrVladislav Grigoryev
Provide comprehensive routing configuration: * Rename the "Network > Routes" page to "Network > Routing". * Unify sorting for the "Status" and "Network" menus. * Add the tabs "IPv4 Rules" and "IPv6 Rules" to the "Routing" page. * Provide configuration for IPv4 and IPv6 routing rules. * Consolidate routing configuration and terminology for IPv4 and IPv6. Policy-based routing is an increasingly popular problem. Netifd natively supports policy-based routing: * Interface-specific options "ip4table" and "ip6table". * Routing rules using the "rule" and "rule6" sections. LuCI is missing configuration for routing rules. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-08-31Merge pull request #5301 from vgaetera/fix-iface-ip6tableJo-Philipp Wich
2021-08-31luci-mod-network: clarify device settings "Delete" buttonSven Roederer
Use proper label text "Unconfigure" for button which "Remove related device settings". Ref: #5090, #5092 Signed-off-by: Sven Roederer <freifunk@it-solutions.geroedel.de>
2021-08-31Merge pull request #5296 from vgaetera/dhcp-labelsFlorian Eckert
luci-mod-network: update dhcp and dns labels and descriptions
2021-08-30luci-mod-network: update dhcp and dns labels and descriptionsVladislav Grigoryev
Update labels and descriptions for DHCP and DNS settings. Add missing descriptions and clarify the existing ones. Group settings by tab and avoid redundant abbreviations. Consolidate terminology according to the dnsmasq documentation: https://thekelleys.org.uk/dnsmasq/docs/dnsmasq-man.html Fix spelling according to the previously adopted policy: https://github.com/openwrt/luci/commit/88b9d843882cf52a6acf4d08a878fd005120edd4 Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-08-26luci-mod-network: fix route6 source autocompleteVladislav Grigoryev
Fix the wrong value for the "source" option of the "route6" section. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-08-26luci-mod-network: fix option ip6table in network/interfacesVladislav Grigoryev
Fix the incorrectly displayed value for the option "ip6table". Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com>
2021-08-11network: hide dnamsq (dhcp+dns) itemFritz D. Ansel
.. when no dnsmasq is installed, as it tells only that there are no settings available Signed-off-by: Fritz D. Ansel <fdansel@yandex.ru>
2021-08-09luci-mod-network: merge hosts with dns settingsVladislav Grigoryev
The current location for "Network > Hostnames" is confusing. It is provided by Dnsmasq and partly overlaps with static leases. Merge "Hostnames" with "Network > DHCP and DNS" as an extra tab. Also add a simple explanation of the use case. Signed-off-by: Vladislav Grigoryev <vg.aetera@gmail.com> [Fix typo in label description string] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-08-09luci-mod-network: fix legacy_rates option dependencyJo-Philipp Wich
The recently introduced band option support changed the internal frequency selector choice values, breaking the legacy rates option dependency. Fixes: #5234 Fixes: 0829d31290 ("luci-mod-network: support newer wireless.wifi-device.band option") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-09luci-mod-network: fix 60GHz radio frequency configurationJo-Philipp Wich
Fix incorrect minimum 60GHz frequency value and ensure that a 60GHz band choice option is available once corresponding channels are found on the system. Ref: http://lists.openwrt.org/pipermail/openwrt-devel/2021-July/035810.html Suggested-by: Alex Henrie <alexhenrie24@gmail.com> Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-08luci-mod-network: dhcp.js: don't fail on not existing interfaceJo-Philipp Wich
Fixes: #5177 Fixes: 7e56289538 ("luci-mod-network: improve static DHCP lease validation") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-03luci-mod-network: fixes to DHCP lease validationJo-Philipp Wich
- validate current form value IP instead of stored uci one - ensure to not pass non-string values to the validator - remove leftover debug code - simplify obtaining formvalues Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-03luci-mod-network: improve static DHCP lease validationJo-Philipp Wich
- Ensure that MAC addresses are unique within the same pool - Ensure that IP addresses are globally unique - Ensure that IP addresses are within any DHCP pool range Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-03Revert "luci-mod-network: issue with breakdown of dnsmasq after duplication ↵Jo-Philipp Wich
of static IP was fixed" This reverts commit 463e910119813aaea0755ff5c16c91ce412a8cbb. This change causes the entire static lease to get deleted when attempting to change the MAC address. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-02luci-mod-network: fix saving bridge VLANs without member portsJo-Philipp Wich
Calling `uci.set()` with an empty array yields an invalid argument error, make sure to pass `null` instead in this case. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-02luci-mod-network: work around jsmin bugJo-Philipp Wich
The jsmin minifier incorrectly transforms the expression `/\*/.test(...)` into `/\* /.test(...)`, causing the VLAN filter dialog to not recognize PVID settings in the configuration. Work around the issue by using an equivalent `\x2a` escape sequence instead. Ref: https://forum.openwrt.org/t/x/99222/28 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-30luci-mod-network: enforce IPv4 mode for traceroute callJo-Philipp Wich
Recent busybox traceroute applet versions support both IPv4 and IPv6 and default to IPv6 when running a route trace to an IPv6 enabled target host. Pass the `-4` flag to enforce IPv4 mode in this case. Fixes: #5155 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-21Merge pull request #4965 from tano-systems/pr/20210406-disable-routes-supportFlorian Eckert
luci-mod-network: Support for disabling routes
2021-06-21treewide: fix typo in "Enable VLAN filtering" labelJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: parse ports without tag/pvid annotation as wellJo-Philipp Wich
Fixes: 01eac366f6 ("luci-mod-network: fix tagging/pvid state parsing in bridge-vlan ports") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: fix tagging/pvid state parsing in bridge-vlan portsJo-Philipp Wich
The previous code naively looked for a `t` in the entire port spec, wrongly matching untagged ports having a `t` in their name, such as `eth0`. Rework the logic to be more strict when parsing the port member specification to avoid this issue. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: refactor device configurationJo-Philipp Wich
Since all netifd device types inherit generic device settings, we can simplify various aspects of the device configuration ui and drop unused code while we're at it. - Remove setIfActive() helper, superseded by commit f3f74bd0fe ("luci-base: form.js: consider aliased options in AbstractValue.remove()") - Remove most dependency constraints to make all generic device settings available for all device types - Add MTU value validation to disallow exceeding parent device MTU for VLAN interfaces - Dynamically update placeholder values when changing base or parent device options - Undo VLAN network config hack since all options are available now. Reverts commit 3c6b59504a ("luci-mod-interfaces: simplify configuring MAC address of 802.1q devices") - Do not suggest inactive wireless networks as existing device or base device choices - Disallow specifying names of already existing network devices when creating new device settings - Fix a number of multicast dependency specifications - Drop now unused functions Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: change port status layout in vlan filter configJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>