summaryrefslogtreecommitdiffhomepage
path: root/modules/luci-mod-network/htdocs
AgeCommit message (Collapse)Author
2021-07-02luci-mod-network: fix saving bridge VLANs without member portsJo-Philipp Wich
Calling `uci.set()` with an empty array yields an invalid argument error, make sure to pass `null` instead in this case. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-07-02luci-mod-network: work around jsmin bugJo-Philipp Wich
The jsmin minifier incorrectly transforms the expression `/\*/.test(...)` into `/\* /.test(...)`, causing the VLAN filter dialog to not recognize PVID settings in the configuration. Work around the issue by using an equivalent `\x2a` escape sequence instead. Ref: https://forum.openwrt.org/t/x/99222/28 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-30luci-mod-network: enforce IPv4 mode for traceroute callJo-Philipp Wich
Recent busybox traceroute applet versions support both IPv4 and IPv6 and default to IPv6 when running a route trace to an IPv6 enabled target host. Pass the `-4` flag to enforce IPv4 mode in this case. Fixes: #5155 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-21Merge pull request #4965 from tano-systems/pr/20210406-disable-routes-supportFlorian Eckert
luci-mod-network: Support for disabling routes
2021-06-21treewide: fix typo in "Enable VLAN filtering" labelJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: parse ports without tag/pvid annotation as wellJo-Philipp Wich
Fixes: 01eac366f6 ("luci-mod-network: fix tagging/pvid state parsing in bridge-vlan ports") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: fix tagging/pvid state parsing in bridge-vlan portsJo-Philipp Wich
The previous code naively looked for a `t` in the entire port spec, wrongly matching untagged ports having a `t` in their name, such as `eth0`. Rework the logic to be more strict when parsing the port member specification to avoid this issue. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: refactor device configurationJo-Philipp Wich
Since all netifd device types inherit generic device settings, we can simplify various aspects of the device configuration ui and drop unused code while we're at it. - Remove setIfActive() helper, superseded by commit f3f74bd0fe ("luci-base: form.js: consider aliased options in AbstractValue.remove()") - Remove most dependency constraints to make all generic device settings available for all device types - Add MTU value validation to disallow exceeding parent device MTU for VLAN interfaces - Dynamically update placeholder values when changing base or parent device options - Undo VLAN network config hack since all options are available now. Reverts commit 3c6b59504a ("luci-mod-interfaces: simplify configuring MAC address of 802.1q devices") - Do not suggest inactive wireless networks as existing device or base device choices - Disallow specifying names of already existing network devices when creating new device settings - Fix a number of multicast dependency specifications - Drop now unused functions Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: change port status layout in vlan filter configJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-17luci-mod-network: only consider bridge vlans belonging to the current deviceJo-Philipp Wich
In case multiple bridges with bridge vlans are declared, LuCI did not correctly filter the VLANs to show only the ones belonging to the bridge being configured currently. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-14luci-mod-network: wireless.js: recognize HE* htmodesJo-Philipp Wich
Ref: https://bugs.openwrt.org/index.php?do=details&task_id=3856#comment9797 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-13luci-mod-network: small styling fixes for vlan filter matrixJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-12luci-mod-network: migrate more device optionsRafał Miłecki
Include mtu and igmp_snooping while migrating. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-06-12luci-mod-network: reset bridge VLANs on cancelling modal dialogJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-12luci-mod-network: fix vlan filter matrix overflow after redrawJo-Philipp Wich
Ensure that the overflow styles are reapplied after a redraw. This also simplifies the code as a side-effect. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-11luci-mod-network: add port status to bridge vlan filter matrixJo-Philipp Wich
Also ensure that port devices are ordered numerically. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-09luci-mod-network: fix horizontal scrolling in the bridge vlan filter matrixJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-09Merge pull request #5110 from jow-/wireless-band-optionJo-Philipp Wich
luci-mod-network: support newer wireless.wifi-device.band option
2021-06-09luci-mod-network: interfaces.js: fix ifname migration in device sectionsJo-Philipp Wich
The migration code attempted to add new device sections instead of moving the ifname option to a ports list within the existing ones. Fixes: #5108 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-09luci-mod-network: interfaces: show bridge port device icons againJo-Philipp Wich
Restore the display of bridge port device icons in the interface overviews. This feature has been lost after migrating the network config from legacy bridge declarations to device bridge declarations. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-09luci-mod-network: support newer wireless.wifi-device.band optionJo-Philipp Wich
OpenWrt switched from "option hwmode" to "option band" in order to select the frequency band to use for the radio phy. Extend the channel selector to recognize and use an existing "option band" to select the appropriate channel list. When operating upon a wireless configuration still using "option hwmode", then translate it to a band value internally and translate it back to "option hwmode" on save. This should provide forward- and backwards compatibility with both current OpenWrt master and older versions still using hwmode. Fixes: #5106 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-07treewide: consolidate {IPv4,IPv6,MAC} {address,gateway} spellingsJo-Philipp Wich
- Turn IPv4-Address into IPv4 address - Turn IPv4-Gateway into IPv4 gateway - Turn IPv6-Address into IPv6 address - Turn IPv6-Gateway into IPv6 gateway - Turn MAC-Address into MAC address Also remove related duplicate translation entries. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-07treewide: fix "promiscious" typoJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-05Merge pull request #5095 from jow-/dhcpv6-reworkJo-Philipp Wich
luci-mod-network: interfaces: restructure DHCPv6 and IPv6 RA options
2021-06-05Merge pull request #5070 from blocktrron/pr-luci-wifi6David Bauer
luci-mod-network: add 802.11ax HE support
2021-06-05luci-mod-network: allow device declarations and device configs to coexistJo-Philipp Wich
It is legal to have two device sections referring to the same netdev if one section is a declaration (a section setting option type) and the other is a configuration (a section not specifying a type but matching an existing netdev). Support this case in LuCI since it might be required for some complex device setups. Additionally, fix the device type determination for device configuration sections without type, those should be treated as ethernet (a.k.a. simple device) configuration instead of falling back to the underlying netdev device type. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-05luci-mod-network: add 802.11ax HE supportDavid Bauer
This commit adds the ability to configure HE-modes for radios (HE20 / HE40 / HE80 / HE160) as well as HE rate information in the assiciation view. Tested-on: Ubiquiti UniFi 6 Lite / LR Signed-off-by: David Bauer <mail@david-bauer.net>
2021-06-05luci-mod-interfaces: simplify configuring MAC address of 802.1q devicesJo-Philipp Wich
Treat not explicitly configured, preexisting VLAN interfaces as simple network devices when adding configuration for them, since it is more likely that people want to set general device properties such as MAC address instead of reconfiguring ingress/egress QoS mapping, which is the only editable property of preexisting VLAN device config dialogs. Ref: https://github.com/openwrt/luci/issues/5102 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-03luci-mod-network: interfaces: restructure DHCPv6 and IPv6 RA optionsJo-Philipp Wich
- Condense overly large IPv6 RA/DHCPv6 description texts and get rid of most embedded markup - Switch ra/ndp/dhcpv6 mode selections to rich dropdown lists and move extended choice descriptions next to the selection options - Drop ndproxy_static option which has been removed from odhcpd long ago - Add format validations to all text input fields - Add ability to configure master/relay modes for non-static interfaces (#2998) - Move extended RA configuration options into a new tab - Prevent enabling master mode on multiple interfaces - Prevent enabling ra/dhcpv6 server mode on non-static or master interfaces - Drop ra_management in favor to ra_flags option (#5083) - Add support for dns_service option - Read current effective IPv6 MTU and hop limit placeholder values from procfs Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-03treewide: Update JS using luci-rpc getHostHintsNiels Widger
Update frontend JS code which uses luci-rpc getHostHints to support the new response format which removes the `ipv4` and `ipv6` host hint string fields and replaces them with `ipaddrs` and `ip6addrs` weighted string list fields. Signed-off-by: Niels Widger <niels@qacafe.com> [rework code to be forwards/backwards compatible, fix some Network.Hosts methods, fix IP choice ordering, change commit subject, rewrap commit message] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-01luci-mod-network: rename "device" option to "_net_device" internallyJo-Philipp Wich
This is required to resolve conflicts with the existing "device" option in other proto handlers such as PPP or QMI where "device" refers to the device path of the tty control device instead of a netdev name. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-01luci-mod-network: clarify device settings reset button tooltipJo-Philipp Wich
Ref: #5090 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-01luci-mod-network: don't accidentally reset macvlan device namesJo-Philipp Wich
Fixes: #5081 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-06-01luci-mod-network: drop duplicated "Master" optionHannu Nyman
It got accidentally added when additional RA and NDP parameters were added. Fixes: 504bdb23fb ("luci-mod-network: Introduce new RA and NDP params...") Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
2021-05-31luci-mod-network: migrate macaddr during bridge migrationRafał Miłecki
Link: https://forum.openwrt.org/t/network-migration-21-02-0-rc2/97934 Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-05-31luci-mod-network: allow netifd version query to failJo-Philipp Wich
Fixes: 17af33ee48 ("luci-mod-network: migrate network config depending on netifd version") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-05-31luci-mod-network: make device selector dependent on protocol (again)Jo-Philipp Wich
This commit effectively reverts the change made with 907b4222f7 ("luci-mod-network: don't hide "Device" on protocol change"). Floating tunnel protocols such as 6in4, plain PPP over modem device, VPNC etc. do not have any layer 2 device at all, for such protocols the device selector should be hidden. Also swap back the incorrect option order introduced with commit b7f3cf66ca ("luci-mod-network: drop support for *adding* legacy bridges"). Since device depends on proto, it should come after the protocol selection, not before. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-05-31luci-mod-network: fix device dependencies in add interface dialogJo-Philipp Wich
Commit b7f3cf66ca "luci-mod-network: drop support for *adding* legacy bridges" dropped the protocol dependcies of the ifname/device selector in the add new interface dialog. Re-add the required dependencies and swap the order of the protocol and device inputs while we're at it since latter depends on the former. Fixes: b7f3cf66ca ("luci-mod-network: drop support for *adding* legacy bridges") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2021-05-29luci-mod-network: split config migration into 2 stepsRafał Miłecki
Problem with handling all migrations in 1 step is that uci.sections() doesn't include changes queued using uci.callAdd() and uci.callSet(). That could result in unexpected behaviour and generating invalid configs. For the sake of simplicity and reliability use 2 steps migration. The downside is that users may get prompted twice to migrate. Reported-by: Hauke Mehrtens <hauke@hauke-m.de> Fixes: 74be304e541f ("treewide: use "device" option in UCI "interface" sections") Signed-off-by: Rafał Miłecki <rafal@milecki.pl> Tested-by: Hauke Mehrtens <hauke@hauke-m.de>
2021-05-28luci-mod-network: allow setting bridge device MTU and MACRafał Miłecki
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-05-27luci-mod-network: bump min netifd version for migrationRafał Miłecki
Using "device" option requires netifd from 2021-05-26 or newer. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-05-27treewide: use "device" option in UCI "interface" sectionsRafał Miłecki
netifd has been recently patched to use "device" option instead of "ifname" as more clear & accurate. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-05-26luci-mod-network: migrate network config depending on netifd versionRafał Miłecki
Checking netifd version is important for users of the most recent LuCI that didn't update netifd (e.g. OpenWrt package). Suggested-by: Jo-Philipp Wich <jo@mein.io> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-05-26luci-mod-network: migrate config to use "ports" optionRafał Miłecki
LuCI supports only the newer method of specifying bridge ports using the "ports" option. Offer users migration so they can configure their network. Example: 1. Before config device option name 'br-lan' option type 'bridge' list ifname 'lan1' list ifname 'lan2' list ifname 'lan3' list ifname 'lan4' 2. After config device option name 'br-lan' option type 'bridge' list ports 'lan1' list ports 'lan2' list ports 'lan3' list ports 'lan4' Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-05-20luci-mod-network: drop 2 unused variablesRafał Miłecki
Fixes: faad7464a8ed ("luci-mod-network: add support for network.device sections") Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-05-20luci-mod-network: don't hide "Device" on protocol changeRafał Miłecki
Device ("ifname" UCI option) doesn't depend on protocol so there is no need to hide / reset it on protocol change. While at it drop names of two removed inputs (dead code). Fixes: ec020cee0c44 ("luci-mod-network: drop support for *editing* legacy bridges") Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-05-18luci-mod-network: add bridge interface migrationRafał Miłecki
LuCI now supports the updated UCI syntax for bridges that requires: 1. device section for L2 2. interface section for L3 Check for legacy syntax usage and offser user a migration to allow changing network config. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-05-18luci-mod-network: use "ports" option for setting bridge portsRafał Miłecki
netifd has been recently patched to use more accurate "ports" option instead of "ifname" Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-05-18luci-mod-network: drop support for *editing* legacy bridgesRafał Miłecki
The old way of defining bridge (L2) as part of interface (L3) is deprecated. All such configs should be migrated to define bridge as L3 UCI section type "device". Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
2021-05-18luci-mod-network: drop support for *adding* legacy bridgesRafał Miłecki
The old way of defining bridge (L2) as part of interface (L3) is deprecated. Don't support *adding* interfaces like that. Support for *editing* legacy bridges is kept for now for compatibility with existing legacy setups. Signed-off-by: Rafał Miłecki <rafal@milecki.pl>