summaryrefslogtreecommitdiffhomepage
path: root/modules/luci-base/htdocs/luci-static
AgeCommit message (Collapse)Author
2024-02-19luci-base: ui.js: rework dropdown focus behaviorJo-Philipp Wich
Drop mouse following focus behavior as it interferes with custom value inputs, rely on CSS based hover effects instead. Also slightly improve keyboard navigation by auto-focussing the custom value input when entering the last dropdown choice via arrow down or tab key, and by allowing to leave the text input again with the arrow up key. Fixes: #6903 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2024-01-31luci-mod-network: add disabled option for interfacePaul Donald
Enabled by default. If the interface is in use, the user will be asked to confirm. Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
2024-01-31luci-base: Code quality fixesPaul Donald
reduce backtracking in regex Signed-off-by: Paul Donald <newtwen@gmail.com>
2024-01-31luci-base: Code quality fixesPaul Donald
handle (possibly incorrect) comment variants <!-- --> <!-- --!> Signed-off-by: Paul Donald <newtwen@gmail.com>
2024-01-25luci-base: fix docs for TableSectionPaul Donald
There are repeated values (TableSection inherits identically named values from TypedSection which do not make sense to recreate). There seemed to be other errors. E.g. TypedSection for FlagValue properties, which mean that TypedSection got tooltip + tooltipicon, and by virtue of the above error, GridSection inherited this too. Signed-off-by: Paul Donald <newtwen@gmail.com>
2024-01-23luci-base: FlagValue fix type of enabled and disabled propertiesSergey Ponomarev
The form.Flag checkbox allows to specify a value for enabled/disabled e.g. for a dropbear: o = s.option(form.Flag, 'PasswordAuth'); o.enabled = 'on'; So the property type should be a string but not just a number. Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
2024-01-23luci-base: JsDoc: exec_direct(): fix "type" enumSergey Ponomarev
The "type" can be "json" Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
2023-12-23luci-base: comment fixes (sp)Paul Donald
Signed-off-by: Paul Donald <newtwen@gmail.com>
2023-12-15luci-base: Use getMode in getActiveModeEvan Benn
Signed-off-by: Evan Benn <evan.benn@morsemicro.com>
2023-12-15luci-base: Replace mode: Master with Access PointEvan Benn
Access Point is the string used on the network wireless setup dialogue. Use Access Point to report the mode on the network wireless and status screens. Signed-off-by: Evan Benn <evan.benn@morsemicro.com>
2023-12-15luci-base: Make uci mode strings match iwinfo mode stringsEvan Benn
uci mesh was being displayed as 'Mesh', while iwinfo mesh was being reported as 'Mesh Point'. Unify those. Update getActiveModeI18n to deal with all the values iwinfo returns. Fix the incorrect 'Mash' translation. Signed-off-by: Evan Benn <evan.benn@morsemicro.com>
2023-10-19luci-base: ui.js: sorting fixes for tables initialized from markupJo-Philipp Wich
- Populate id option from table id attribute - Update column head sort indicator in UITable.update() - Don't store sort state for tables without id Ref: https://github.com/openwrt/luci/issues/6640 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2023-09-23luci-base: Fix typos in JsDocsSergey Ponomarev
In some places argument name was renamed but in the JsDoc it's remain old. Added more typing for string enum fields like: @param {string} [type=text] replaced with: @param {"blob"|"text"|"blob"} [type=text] Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
2023-09-23luci-base: network.js: simplify getWifiNetidBySidSergey Ponomarev
Remove unused variables i and netid and reuse radioname Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
2023-09-23luci-base: "an URL" replace with "a URL"Sergey Ponomarev
This is a correct form Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
2023-09-23luci-base: cbi.js cbi_validate_named_section_add() simplifySergey Ponomarev
Reduce if to a simple boolean evaluation Signed-off-by: Sergey Ponomarev <stokito@gmail.com>
2023-08-11luci-base: grammar fixesPaul Dee
Login (n) -> Log (v) in Logout (n) -> Log (v) out Signed-off-by: Paul Dee <itsascambutmailmeanyway@gmail.com>
2023-06-07luci-base: ui.js: set `autocomplete="new-password"` for password fieldsJo-Philipp Wich
Attempt to prevent Firefox from randomly filling nonesense into arbitrary password fields such as the WireGuard private key field by setting the `autocomplete="new-password"` attribute on any password type fields. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2023-04-28luci-base: ui.js: make upload cancellation message translatableJo-Philipp Wich
Resync base translation templates as well. Fixes: #6364 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2023-04-03luci-base: validation.js: fix xgettext quirkJo-Philipp Wich
The xgettext utility does not properly discard `/` inside regex character classes, causing a false positive unterminated string error. Avoid the issue by explicitly escaping the embedded slash. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2023-03-15luci-mod-network: add stricter wireless interface name validationGlenn Washburn
Linux wireless interface names have the following restrictions: * It must not be an empty string * It must not be '.' or '..' * It must not contain any /, : or space character ( , \t, \n, ...) * It must be less than 16 chars * It likely must not contain any % either Fixes: 8673aef8db ("luci-mod-network: remove uciname validation from wireless interface") Signed-off-by: Glenn Washburn <development@efficientek.com> [reword validation error messages, remove extended description text as it would be shown as part of the validation errors] Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2023-02-08Revert "luci-proto-openconnect: fix server url validation"Jo-Philipp Wich
This reverts commit f1312cadc6675fb29d02425775dd8a2a533d7e7c. The commit contained unrelated changes. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2023-02-07Merge pull request #6104 from dhewg/6gJo-Philipp Wich
luci-mod-network: enable configuring wifi ax networks on the 6G band
2023-02-07luci-proto-openconnect: fix server url validationJo-Philipp Wich
The OpenConnect configuration form incorrectly assumed that the server setting must be hostname while it actually may be a full URL. Fixes: #6184 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2023-02-05luci-base: ui.js: modal dialog tweaksJo-Philipp Wich
- Automatically focus modal dialog frame - Close modal dialog on pressing escape key Fixes: #4609, #6205 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2023-02-05luci-base: ui.js: improve ui.Dropdown event handlingJo-Philipp Wich
Improve overall event and focus handling, avoid registering a global mouseover event listener, stop propagating escape keypress on closing dropdown and avoid `Element.blur()` to prevent de-focusing open modals. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2023-02-04luci-base: form.js: reuse JSONMap data provider in GridSection modalsJo-Philipp Wich
Reuse the same data provider as the parent JSONMap instance in order to avoid inadvertently mangling the form data when saving the modal edit dialog. Fixes: bb9ede238a ("luci-base: form.js: reuse JSONMap data provider in GridSection modals") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2023-02-04luci-base: form.js: fix GridSection modals in JSONMap instancesJo-Philipp Wich
Since grid section edit modals construct a new Map instance internally, we must take care of using the correct map constructor type for the internal copy in order to end up with the correct data provider. Ensure that the extended option modal of GridSection instances uses a JSONMap when the grid section's owner map is a JSONMap to avoid stray uci related errors. Ref: https://forum.openwrt.org/t/luci-save-apply/149658/5 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2023-01-23luci-base: use "hwmodes_text" to describe wireless radiosAndre Heider
This is a preformatted string like "ac/ax/b/g/n" for presentation. Signed-off-by: Andre Heider <a.heider@gmail.com>
2023-01-17luci-base: help-text spell fixPaul Dee
Signed-off-by: Paul Dee <itsascambutmailmeanyway@gmail.com>
2022-12-27luci-base: ui.js: support div based table markup in UITable.update()Jo-Philipp Wich
Constructing UITable instances from existing, div based markup is supported but the UITable.update() implementation did not account for that, leading to defunct data updates on tables built from div based markup. Fix this issue by extending UITable.update() to consider a div based table structure as well, like we do in UITable.initFromMarkup() already. Fixes: #5713 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-12-13luci-base: fix button handling for named sectionsFlorian Eckert
If more than one named section is added to the page, it is currently the case, that the first button is always switched on or off during input validation of the uci section name. This is because the usage of the 'document.querySelector' function is to imprecise. Changing the search start to the element to be created, fixes this. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2022-11-22luci-base: ui.js: table enhancementsJo-Philipp Wich
- Gracefully handle cells without innerText - Properly handle `DocumentFragment` call values on table update - Introduce ability to fetch actual cell value for sorting purposes from `data-value` attribute Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-11-09luci-base: cbi.js: await L.ui load before updating tablesJo-Philipp Wich
On legacy views, the `L.ui` JavaScript class is not automatically loaded, so request it before updating tables. Fixes: e0e6989a4a ("luci-base: introduce new LuCI.ui.Table class") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-07-27luci-base: revise array sortingJo-Philipp Wich
Refactor various sort operations throughout luci-base to use the new L.naturalCompare() comparator function. This primarily ensures that embedded numbers are sorted numerically and not in a lexicographical way. It also simplifies some code as a side effect. Ref: #5899 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-07-27luci-base: luci.js: add array sort utilitiesJo-Philipp Wich
Add two new utility functions L.naturalCompare() and L.sortedArray() to simplify sorting arrays naturally. Ref: #5899 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-07-23luci-base: uci.js: prevent sending empty uci set operationsJo-Philipp Wich
Under certain circumstances, a staged uci option value might get unset again before saving the config, leaving an empty section change set behind, causing the save call to send an empty uci set request via rpc, triggering an ubus code 4 (Resource not found) error. In particular this prevented bridge VLANs from getting saved properly. Fixes: #5876 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-07-22luci-base: form.js: fix removing just created named GridSectionJo-Philipp Wich
Since the `handleModalSave()` handler of the GridSection class invokes `handleModalCancel()` after saving the data but before removing the `addedSection` property, the `handleModalCancel` handler incorrectly removed the uci section that has just been created. This bug didn't affect anonymous GridSections because after saving the id of the created section changes, causing the remove command to fail, but for named ones with stable section IDs, the bug manifested. Solve the issue by passing a flag to `handleModalCancel()` indicating whether the method was called from a safe operation and use it do decide whether to delete the new staged uci section or not. Fixes: #5760 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-06-25luci-base: optimized icons filesizesy04
Optimized PNG filesize without any quality loss. Signed-off-by: Alexander Semukhin <semukhin@mail.com>
2022-06-16luci-base: network.js: consider uci config for Device.getType()/getParent()Jo-Philipp Wich
For network devices declared in uci but not yet created by netifd, the runtime status information will be unavailable, causing methods such as `getType()` to assume plain ethernet interfaces and `getParent()` to fail resolving parent devices. Fall back to infer the information from uci configuration settings in such cases to give accurate type hints to callers. In particular, this prevents LuCI from turning wireless target networks containing a to-be-created bridge device into bridges themselves. Fixes: https://github.com/openwrt/packages/issues/18768 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-05-17luci-base: ui.js: add required CSS class to dynlist widgetJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-05-17luci-base: form.js: minor tweaks for mobile stylingJo-Philipp Wich
- Annotate gridsection textvalue cells as CBI.DummyValue widgets - Replace `<br>` elements with newlines in `stripTags()` Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-05-16luci-base: form.js: trim option descriptionJo-Philipp Wich
If a whitespace-only description is set on an element, the CSS :empty selector will not match, causing description icons to be shown when there's no actual content. To avoid that, trim the description string when building the element. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-05-16luci-base: luci.js: remove wrong CSS class from page footerJo-Philipp Wich
The `control-group` class is meant for gapless grouping of inputs with buttons, while the page actions are just distinct buttons in a row. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-05-16luci-base: form.js: remove stray `<br>` elements from section placeholderJo-Philipp Wich
Theme CSS styles shoudl take care of introducing padding as needed. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-05-16luci-base: form.js: save parent map on opening nested modal mapJo-Philipp Wich
Before opening (rendering) a nested modal map, make sure to save the parent modal map in order to persist any structural uci changes, such as newly added anonymous sections to prevent the nested map from operating on stale values or ephemeral config section IDs. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-05-16luci-base: form.js: handle SectionValue objects in GridSection modalsJo-Philipp Wich
The existing logic for cloning section options into the modal form section container did not properly handle SectionValue objects. Introduce a new `cloneOptions()` helper to recursively traverse and properly clowning such nested sections. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-05-16luci-base: form.js: reset parent maps on returning from nested section modalJo-Philipp Wich
The nested section modal might have changed values also covered/displayed by the parent map, so ensure to reload all parent maps in the current modal view stack to ensure that no stale values are shown on return. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-05-16luci-base: form.js: allow overriding section placeholder of TableSectionsJo-Philipp Wich
The existing implementation was hardcoding the empty TableSection placeholder instead of invoking `renderSectionPlaceholder()` which might be overridden by various forms. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2022-05-16luci-base: ui.js: warn about connectivity loss on changing iface settingsJo-Philipp Wich
If specific settings such as the protocol, IP address or netmask of an interface the user is connected to are changed, the apply/rollback mechanism might interfere. Display an additional warning dialog in this case, instructing the user to manually reconnect and offering to continue with a less safe unchecked apply mechanism. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-04 00:11:23 +0000