Age | Commit message (Collapse) | Author |
|
Remove sysupgrade_backup from help. Also have it check parameters.
Signed-off-by: John Kohl <jtk.git@bostonpog.org>
|
|
Signed-off-by: John Kohl <jtk.git@bostonpog.org>
|
|
Add a backup/restore capability for rrd data storage in
luci_statistics. The data storage is typically in /tmp and does not
survive reboot or sysupgrade. This adds an option for the
administrator to configure the RRD plugin, so that the RRD data are
are preserved with a backup copy in the overlay file system.
This works for shutdown/reboot, sysupgrade (backup config files,
restore config files, and true sysupgrade).
Also fix a bug where starting luci_statistics for the first time would
not get a restart a running collectd: during install of the package
when it is not included in the base flashed image, collectd might be
started when it got installed/configured before this package gets
installed/configured. So we need to check if it's running, and
restart it to use the luci_statistics configuration.
Signed-off-by: John Kohl <jtk.git@bostonpog.org>
|
|
Make hiding the 'free' memory configurable.
Set default as disabled, shown in graph which always scales to 100%.
If enabled, the graph scales to actually used memory,
which enables a more detailed view to memory usage.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Modernize tcpconns plugin to match the features in collectd:
* Support summary of all ports
* 'All listening ports' can be concurrent to specified ports,
not just alternative
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Adjust also default_timespan option to be 2hour, as that change was
forgotten in 4b49b456. (That seems to have no practical relevance, as
LuCI seems to offer the first item from the period list in any case.)
Fixes: 4b49b456 luci-app-statistics: set shortest period data/graph to 2 hours
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Change the shortest defined statistics period from 1 hour to 2 hours.
In practice, this only changes the graph for the shortest period
to show 2 hours of data instead of 1 hour.
The underlying database is not changed:
there are currently 288 data items for each period,
so with the 30 seconds default step, the shortest data series
contains 288 x 0.5 min = 144 min > 2 hours of data.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Rewrite the collectd config generator script in ucode to remove the implicit
dependency on the Lua runtime.
Also move the stat-genconfig script into /usr/libexec as it isn't really a
user facing executable.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Do not emit native collectd.conf boolean false options if the corresponding
uci option is unset in order to honour collectd's implicit defaults.
This fixes certain options, such as the memory plugins `ValuesAbsolute`,
being without effect if declared as default-enabled in the related plugin
uci forms.
Fixes: #5777
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Increase the default number of data items in the RRD database
from 144 to 288. This leads to smaller summarising/averaging periods,
visible especially in the day & week graphs. The averaging intervals
will be: 30s, 5min, 35min, 2h35min, 1d6h30min
(Note: this change only applies in a live router if the RRD database is
empty. E.g after reboot or after emptying the RRD database dir.)
Reference to discussion at #4065
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Adjust the fallback timespan and graph width to the current config
defaults. (The default width in /etc/config/luci_statistics has been
600 already since commit 7ab8b51bd in March 2010.)
Expose the graph height in the config file and
increase it from 100 to 150 to keep the original aspect ratio.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Remove the unnecessary Include line from the default config.
It causes error at collectd start, as the directory is missing.
daemon.err collectd[9722]: configfile: stat (/etc/collectd/conf.d) failed: No such file or directory
Leave the line as a comment/example.
Fixes #5373
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
the `irq` plugin does not show the right data if the interrupt name is only numeric
Signed-off-by: Ronny Kotzschmar <ro.ok@me.com>
|
|
Signed-off-by: John Kohl <jtk.git@bostonpog.org>
|
|
Fix the newly added ipstatistics plugin
* add config definition
* add configSummary
* remove unnecessary option config form
(no plugin-specific options)
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Signed-off-by: Nick Hainke <vincent@systemli.org>
|
|
Add IPv6 statistics.
Signed-off-by: Nick Hainke <vincent@systemli.org>
|
|
Add initial support for chrony statistics.
At this point introduce time offset and stratum stats.
There is something strange with the host option.
Anything else than 'localhost' or '127.0.0.1' causes an error at
collectd start, even when /tmp/collectd/conf is directly edited
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Tidy up the current default config for statistics:
* df: use /overlay as the example mount point instead of /jffs
* openvpn: add missing section
* syslog: remove leading whitespaces
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Add the dhcpleases plugin:
https://github.com/openwrt/packages/pull/14204
Added-Frontend-by: Hannu Nyman <hannu.nyman@iki.fi>
Signed-off-by: Nick Hainke <vincent@systemli.org>
[Minor changes to graph: alt_autoscale, precision, label]
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
* Add functionality to hide the metric of 'idle' state
from the chart and data table. Many routers are mostly idle,
and the 98% 'idle' dominates the graph reducing its usefulness.
Without 'idle', the smaller CPU usage spikes are visible.
* Hide 'idle' by default. Provide config option to show it.
(note: the option in inside LuCI, and has no impact on actual
data collection by collectd.)
* Tweak the defaults to use the percentage data by default.
It makes more sense to average users than jiffies.
* Set the current LuCI defaults also in the config file.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
|
|
Increase the default number of data items in the RRD database
from 100 to 144. That leads to better matching summarising/averaging
moments between day & week and week & month at the averaging intervals:
30sec, 10min, 70 min, 5h10min, 2d13h
Previous 100 led too easily to situations, where the longer period's
more scarce data gets selected for displaying in the graph. That could
happen if the longer period's last data point was stored more recently
than the last data item in the originally required period.
(E.g. if the last "week data item" was more recent than the last
"day data item", the week data was used for the day chart.)
(Note: this change only applies in a live router if the RRD database is
empty. E.g after reboot or after emptying the RRD database dir.)
Reference to discussion at #4065
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
We are generating the PNG images on the fly and and the rrdimg directory
itself is not used anymore. Therefore the no longer needed code section
is removed with this commit.
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
|
|
Add graphs for sqm data collected by 'sqm_collect.sh'
An overall sqm graph displays bandwidth (Kb/s), Backlog (Bytes) and
drops for each supported qdisc.
Sqm-cake supports cake's tin structure and displays many(!) graphs per
tin:
Bandwidth: Bandwidth (Kb/s), bandwidth threshold (Kb/s).
Latency: Target latency, Peak, Average, Sparse flow latency
Backlog v Drops: Backlog (Bytes), Drops, ECN marks, Ack-filter drops
Flow counts: Sparse flows, Bulk flows, Unresponsive flows
Fun for all the family :-)
Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
|
|
Signed-off-by: Tobias Waldvogel <tobias.waldvogel@gmail.com>
|
|
Fix the ACL name.
Instead of referencing openvpn, use the statistics ACL.
Fixes commit 8f34e105c0
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
- Remove redundant form flags
- Fix various default values
- Add some new collect options and remove options that do not exist anymore
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
build: unify and clean up the uci-defaults scripts
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
|
|
This conversion requires cgi-io >= version 17 and uhttpd version >= 2020-02-12
to function properly.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Fixes: 556e14c74 ("luci-app-statistics: convert plugin definitions to JSON")
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Fixes the following runtime error:
/usr/bin/lua: /usr/bin/stat-genconfig:289: attempt to index field 'i18n' (a nil value)
stack traceback:
/usr/bin/stat-genconfig:289: in main chunk
Reported-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
Fix d064cbcf9 by actually enabling ValuesAbsolute in the
config file and also prevent removing that option by LuCI.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
Fix config generation for the following sections:
* curl
* exec
* network
* iptables
Ref: https://github.com/openwrt/packages/issues/9427
Fixes: c1380ab ("make luci-app-statistics more extensible")
Signed-off-by: Florian Eckert <fe@dev.tdt.de>
|
|
|
|
It allows to force ipv4 or ipv6 when the DNS returns both addresses, but
only one works (for example if there is no ipv6 connectivity).
Signed-off-by: Loïc Yhuel <loic.yhuel@gmail.com>
|
|
|
|
Add collectd-mod-curl plugin support. Which can do some complex track,
such as grab stock, but by now, only response time are supported.
Signed-off-by: Chizhong Jin <pjincz@gmail.com>
|
|
Convert init script to procd format in order to register reload triggers
on /etc/config/luci_statistics.
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
|
|
OpenWRT/LEDE support for APC UPSes is only partial: although the collectd
apcups plugin is included, related lua/luci code is missing. These changes
add the lua side and have been used for ~2 years, both on OpenWRT and LEDE.
Reworked from patches submitted by James Klaas to the luci development list
in 2015.
Signed-off-by: Tony Ambardar <itugrok@yahoo.com>
|
|
Force logfile plugin to be evaluated first so that it gets placed
first in the collectd.conf file.
Reference to https://collectd.org/wiki/index.php/Plugin:LogFile
Fixes #1219
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|
|
* fix whitespace in config file
* place the contextswitch item corerrctly
in the sorted options list
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
|