summaryrefslogtreecommitdiffhomepage
AgeCommit message (Collapse)Author
2018-11-15Merge pull request #2286 from kevinoid/fix_statistics_filename_quotingJo-Philipp Wich
luci-app-statistics: quote : in filenames for DEF
2018-11-14luci-app-statistics: quote : in filenames for DEFKevin Locke
: is used to delimit fields in DEF: rrd instructions, so when it appears in a filename it must be escaped using \.[1] This commit adds the escaping. I discovered the issue after configuring collectd-mod-ping to monitor an IPv6 host (2001:19f0:5:727:5b56:205d:ff55:2208). Accessing https://192.168.0.1/cgi-bin/luci/admin/statistics/graph/ping would cause the following messages to be logged: Wed Nov 14 23:04:33 2018 daemon.err uhttpd[30261]: ERROR: can't parse DEF '2ping_avg_raw=/tmp/rrd/openwrthost/ping/ping-2001:19f0:5:727:5b56:205d:ff55:2208.rrd:value:AVERAGE' -2 Wed Nov 14 23:04:33 2018 daemon.err uhttpd[30261]: ERROR: can't parse DEF '2ping_droprate_avg_raw=/tmp/rrd/openwrthost/ping/ping_droprate-2001:19f0:5:727:5b56:205d:ff55:2208.rrd:value:AVERAGE' -2 and the graphs would not display. After applying this commit, the graphs display correctly and no messages are logged. 1. https://oss.oetiker.ch/rrdtool/doc/rrdgraph_data.en.html#IDEF Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
2018-11-14luci-base: fix some long standing german mistranslationsJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-mod-network: require unique MACs for DHCP leasesJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: datatypes: add "unique" dummy validatorJo-Philipp Wich
Add a dummy validator for the server side so that we can start using unique in client side JS code. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14Merge pull request #2259 from pmelange/luci-app-olsr-new-json-libJo-Philipp Wich
update luci-app-olsr to the new jsoninfo library
2018-11-14Merge pull request #2282 from TDT-AG/pr/20181114-luci-baseJo-Philipp Wich
luci-base: allow optional default value for file browser
2018-11-14luci-lib-ipkg: move out of luci-baseJo-Philipp Wich
Move the old luci.model.ipkg utility class into a separate package and let the components using it depend on the new library package. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-mod-system: replace builtin opkg support with luci-app-opkgJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-mod-system: use luci.sys.process.exec() in system controllerJo-Philipp Wich
Switch the system controller to the common luci.sys.process.exec() function and drop the local ltn12_popen() and fork_exec() helpers. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-mod-system: prevent comment injection in mtdbackup endpointJo-Philipp Wich
Rework the parameter handling to both prevent a crash when no parameter is given and to prevent root command injection through the mtd index part of the parameter value. Fixes: 9840d310e ("modules: add backup module for mtdblock devices") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14applications: add luci-app-opkgJo-Philipp Wich
Add a new luci-app-opkg which is a feature-complete replacement for the builtin opkg functionality of luci-mod-system using mostly client side JavaScript to reduce the amount of server side processing. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-app-firewall: remove references to cbi_bind()Jo-Philipp Wich
Use the standard addEventListener() instead. Also remove an old cbi_validate_field() call referencing a not existing field. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-mod-status: use progressbar widgets on main status pageJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: simplify apply widget codeJo-Philipp Wich
- Drop embedded CSS in favor to new global rules - Drop extraneous include of cbi.js - Use showModal() facilities - Fix a cosmetic bug in countdown timeout handling Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: cbi.js: add modal dialog functionsJo-Philipp Wich
Add two new functions showModal() and hideModal() which will fade in and close an open modal respectively. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-theme-bootstrap: add modal/progressbar rules, cleanupJo-Philipp Wich
- Add rules for modal dialogs and progress bar widgets - Drop redundant, unused or obsolete rules - Add spin utility class Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-theme-openwrt: modal/progressbar rules, mobile improvementsJo-Philipp Wich
- Add rules for modal dialogs and progress bar widgets - Increase button and input size on mobile devices - Convert pt to px units - Add label and h5 styles - Add common flash and spin utility classes Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: add luci.sys.process.exec()Jo-Philipp Wich
The new process.exec() function simplifies spawning external processes and capturing their stdio. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14applications: drop luci-app-asteriskJo-Philipp Wich
This application was never useful to begin with, drop it to avoid further confusion. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base, themes: dropdown behaviour improvementsJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: cbi.js: remove dead code in cbi_validate_field()Jo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: cbi.js: enable validation for dropdown fieldsJo-Philipp Wich
Directly attach validation handlers to cbi dropdowns as well, this allows validating dropdown choices made by the user, similar to how plain select boxes are handled by the cbi JavaScript. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-theme-openwrt: dropdown style tweaksJo-Philipp Wich
- Remove 2em min height, this looks out of place with the OpenWrt theme - Only colorize invalid dropdown when not open - Drop use of image background for invalid fields while we're at it Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-theme-bootstrap: add invalid style for dropdownsJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-theme-{freifunk-generic,material,openwrt}: z-index fixesJo-Philipp Wich
Ensure that open dropdowns cover active tooltips. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-theme-bootstrap: z-index fixesJo-Philipp Wich
Lower z-index of header bar to allow tooltips and dropdowns to overlap it, also increase the z-index of open dropdowns to ensure that they cover active tooltip bubbles. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: cbi.js: set .value property of cbi dropdown elementsJo-Philipp Wich
In order to make cbi dropdowns usable for validation and other code expecting native form elements, set the .value DOM property on the dropdown parent element whenever the selection is changed. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: cbi.js: properly handle cbi tooltips on nested elementsJo-Philipp Wich
Rework the tooltip event delegation logic to prevent hiding the tooltop when the cursor is moved to a children of the tooltip container element. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: cbi.js: avoid using .form property directlyJo-Philipp Wich
In order to prepare support for calling cbi validation on non-native form widgets, remove direct usages of the node.form property and lookup the containing form using findParent() instead. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: cbi.js: fix passing multiple dropdown values in change eventJo-Philipp Wich
Due to a misspelled property name, only the first value was passed in the event details. Fixes: c2b570998 ("luci-base: cbi.js: rework dropdown implementation") Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: rework dynamic list templateJo-Philipp Wich
Commit 7c7821833 ("luci-base, themes: rework dynlist and dropdown widgets") changed the way we initialize dynamic lists on client side, avoiding the need for pre-rendering the items on the server side. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: add ARIA label to reveal/hide password buttonJo-Philipp Wich
Fixes #2070. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14luci-base: update german translationJo-Philipp Wich
Signed-off-by: Jo-Philipp Wich <jo@mein.io>
2018-11-14Merge pull request #2281 from TDT-AG/pr/20181114-luci-app-mwan3Hannu Nyman
luci-app-mwan3: add/remove options
2018-11-14Merge pull request #2277 from sotux/masterHannu Nyman
i18n: luci-base: update Simplified Chinese translation
2018-11-14Merge pull request #2284 from dibdot/travelmateDirk Brenken
luci-app-travelmate: consolidate css
2018-11-14Merge pull request #2283 from dibdot/adblockDirk Brenken
luci-app-adblock: consolidate css
2018-11-14Merge pull request #2280 from dibdot/banipDirk Brenken
luci-app-banip: fix remaining css issues
2018-11-14luci-app-banip: fix remaining css issuesDirk Brenken
* fix IE Edge rendering issues * merge remaining external styles in central css Signed-off-by: Dirk Brenken <dev@brenken.org>
2018-11-14luci-app-travelmate: consolidate cssDirk Brenken
* fix IE Edge rendering issues * merge external styles in central css Signed-off-by: Dirk Brenken <dev@brenken.org>
2018-11-14luci-app-adblock: consolidate cssDirk Brenken
* fix IE Edge rendering issues * merge external styles in central css Signed-off-by: Dirk Brenken <dev@brenken.org>
2018-11-14luci-base: allow optional default value for file browserFlorian Eckert
With this change we could set optional value for the file browser. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2018-11-14luci-app-mwan3: remove deprecated local_source optionFlorian Eckert
Remove deprecated local_source option which is not supported/needed anymore. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2018-11-14luci-app-mwan3: add rt_table_lookup optionFlorian Eckert
Make list option rt_table_lookup configurable in luci. With this option we could define additional routing tables which get scanned by mwan3 and then get added to the connected ipset. The entries will be treated as connected network and will not get mangeld by mwan3. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2018-11-14luci-app-mwan3: add rtmon interval optionFlorian Eckert
Add the configuration option rtmon to luci. With this parameter we could adjust how often the routing table get synced between main routing table and the interface routing table. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2018-11-14luci-app-mwan3: rename variable in globalsconfig.luaFlorian Eckert
Name variables as the options name in uci. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2018-11-14luci-app-mwan3: declare variables in globalsconfig.lua localFlorian Eckert
It is best practice to declar module variables local. Signed-off-by: Florian Eckert <fe@dev.tdt.de>
2018-11-14Merge pull request #2279 from yglb/masterJo-Philipp Wich
luci-theme-rosy: Remove redundant statements and fixed typo
2018-11-14luci-theme-rosy: fixed typoYanlan Shen
Signed-off-by: Yanlan Shen <yanlan.shen.@rosinson.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-25 12:42:09 +0000