summaryrefslogtreecommitdiffhomepage
path: root/modules/luci-mod-admin-full/luasrc/controller/admin/index.lua
diff options
context:
space:
mode:
authorJo-Philipp Wich <jo@mein.io>2018-04-26 08:52:55 +0200
committerJo-Philipp Wich <jo@mein.io>2018-05-05 23:11:23 +0200
commit8deb9495515b97898514e8ffb8f002c8afe3bfa7 (patch)
tree65d4d7b831c273329c0a79a6b9e4a547e760481b /modules/luci-mod-admin-full/luasrc/controller/admin/index.lua
parent7cca3139591a08e62b7900115fe0bfd4a3df8f8a (diff)
treewide: rework uci apply workflow
Switch to rpcd based uci apply/rollback workflow which helps to avoid soft- bricking devices by requiring an explicit confirmation call after config apply. When a user now clicks "Save & Apply", LuCI first issues a call to uci apply which commits and reloads configuration, then goes into a polling countdown mode where it repeatedly attempts to call uci confirm. If the committed configuration is sane, the confirm call will go through and cancel rpcd's pending rollback timer. If the configuration change leads to a loss of connectivity (e.g. due to bad firewall rules or similar), the rollback mechanism will kick in after the timeout and revert configuration files and pending changes to the pre-apply state. In order to cover such rare cases where a lost of connectivity is expected and desired, the user is offered an "unchecked" apply option after timing out, which allows committing and applying the changes anyway, without the extra safety checks. As a consequence of this change, the luci-reload mechanism is now completely unsused since rpcd uses ubus config reload signals to reload affected services, which means that only procd-enabled services will receive proper reload treatment with the new workflow. Signed-off-by: Jo-Philipp Wich <jo@mein.io>
Diffstat (limited to 'modules/luci-mod-admin-full/luasrc/controller/admin/index.lua')
0 files changed, 0 insertions, 0 deletions