luci-base: replace uci change pages with client side modal dialog

Signed-off-by: Jo-Philipp Wich <jo@mein.io>

6 files changed, 20 insertions, 331 deletions

diff --git a/modules/luci-base/luasrc/view/admin_uci/changelog.htm b/modules/luci-base/luasrc/view/admin_uci/changelog.htm
deleted file mode 100644
index 9d6267cf31..0000000000
--- a/modules/luci-base/luasrc/view/admin_uci/changelog.htm
+++ /dev/null
@@ -1,66 +0,0 @@
-<%#
- Copyright 2010 Jo-Philipp Wich <jo@mein.io>
- Licensed to the public under the Apache License 2.0.
--%>
-
-<% export("uci_changelog", function(changes) -%>
-<div class="cbi-section">
-	<strong><%:Legend:%></strong>
-	<div class="uci-change-legend">
-		<div class="uci-change-legend-label"><ins>&#160;</ins> <%:Section added%></div>
-		<div class="uci-change-legend-label"><del>&#160;</del> <%:Section removed%></div>
-		<div class="uci-change-legend-label"><var><ins>&#160;</ins></var> <%:Option changed%></div>
-		<div class="uci-change-legend-label"><var><del>&#160;</del></var> <%:Option removed%></div>
-		<br style="clear:both" />
-	</div>
-	<br />
-
-	<div class="uci-change-list"><%
-		local util = luci.util
-		local tpl = {
-			["add-3"] = "<ins>uci add %0 <strong>%3</strong> # =%2</ins>",
-			["set-3"] = "<ins>uci set %0.<strong>%2</strong>=%3</ins>",
-			["set-4"] = "<var><ins>uci set %0.%2.%3=<strong>%4</strong></ins></var>",
-			["remove-2"] = "<del>uci del %0.<strong>%2</strong></del>",
-			["remove-3"] = "<var><del>uci del %0.%2.<strong>%3</strong></del></var>",
-			["order-3"] = "<var>uci reorder %0.%2=<strong>%3</strong></var>",
-			["list-add-4"] = "<var><ins>uci add_list %0.%2.%3=<strong>%4</strong></ins></var>",
-			["list-del-4"] = "<var><del>uci del_list %0.%2.%3=<strong>%4</strong></del></var>",
-			["rename-3"] = "<var>uci rename %0.%2=<strong>%3</strong></var>",
-			["rename-4"] = "<var>uci rename %0.%2.%3=<strong>%4</strong></var>"
-		}
-
-		local conf, deltas
-		for conf, deltas in util.kspairs(changes) do
-			write("<h3># /etc/config/%s</h3>" % conf)
-
-			local _, delta, added
-			for _, delta in pairs(deltas) do
-				local t = tpl["%s-%d" %{ delta[1], #delta }]
-
-				write(t:gsub("%%(%d)", function(n)
-					if n == "0" then
-						return conf
-					elseif n == "2" then
-						if added and delta[2] == added[1] then
-							return "@%s[-1]" % added[2]
-						else
-							return delta[2]
-						end
-					elseif n == "4" then
-						return util.shellquote(delta[4])
-					else
-						return delta[tonumber(n)]
-					end
-				end))
-
-				if delta[1] == "add" then
-					added = { delta[2], delta[3] }
-				end
-			end
-
-			write("<br />")
-		end
-	%></div>
-</div>
-<%- end) %>
diff --git a/modules/luci-base/luasrc/view/admin_uci/changes.htm b/modules/luci-base/luasrc/view/admin_uci/changes.htm
deleted file mode 100644
index 43bd7c23fb..0000000000
--- a/modules/luci-base/luasrc/view/admin_uci/changes.htm
+++ /dev/null
@@ -1,45 +0,0 @@
-<%#
- Copyright 2008 Steven Barth <steven@midlink.org>
- Copyright 2008-2018 Jo-Philipp Wich <jo@mein.io>
- Licensed to the public under the Apache License 2.0.
--%>
-
-<%+header%>
-
-<%-
-	local node, redir_url = luci.dispatcher.lookup(luci.http.formvalue("redir"))
-	export("redirect", redir_url or url("admin/uci/changes"))
-
-	include("admin_uci/changelog")
--%>
-
-<h2 name="content"><%:Configuration%> / <%:Changes%></h2>
-
-<% if changes then %>
-	<%- uci_changelog(changes) -%>
-<% else %>
-	<p><strong><%:There are no pending changes!%></strong></p>
-<% end %>
-
-<div class="alert-message" id="cbi_apply_status" style="display:none"></div>
-
-<div class="cbi-page-actions">
-	<% if redir_url then %>
-	<form method="get" action="<%=luci.util.pcdata(redir_url)%>">
-		<input class="cbi-button cbi-button-link" type="submit" value="<%:Back%>" />
-	</form>
-	<% end %>
-
-	<form method="post" action="<%=url("admin/uci/changes")%>">
-		<input type="hidden" name="token" value="<%=token%>" />
-		<input type="hidden" name="redir" value="<%=pcdata(luci.http.formvalue("redir"))%>" />
-		<input class="cbi-button cbi-button-save" type="submit" name="trigger_apply" value="<%:Save & Apply%>" />
-	</form>
-	<form method="post" action="<%=url("admin/uci/revert")%>">
-		<input type="hidden" name="token" value="<%=token%>" />
-		<input type="hidden" name="redir" value="<%=pcdata(luci.http.formvalue("redir"))%>" />
-		<input class="cbi-button cbi-button-reset" type="submit" value="<%:Revert%>" />
-	</form>
-</div>
-
-<%+footer%>
diff --git a/modules/luci-base/luasrc/view/admin_uci/revert.htm b/modules/luci-base/luasrc/view/admin_uci/revert.htm
deleted file mode 100644
index d8fd3de01e..0000000000
--- a/modules/luci-base/luasrc/view/admin_uci/revert.htm
+++ /dev/null
@@ -1,33 +0,0 @@
-<%#
- Copyright 2008 Steven Barth <steven@midlink.org>
- Copyright 2008-2018 Jo-Philipp Wich <jo@mein.io>
- Licensed to the public under the Apache License 2.0.
--%>
-
-<%+header%>
-
-<%-
-	local node, redir_url = luci.dispatcher.lookup(luci.http.formvalue("redir"))
-	export("redirect", redir_url or url("admin/uci/changes"))
-
-	include("admin_uci/changelog")
--%>
-
-<h2 name="content"><%:Configuration%> / <%:Revert%></h2>
-
-<% if changes then %>
-	<p><strong><%:The following changes have been reverted%>:</strong></p>
-	<%- uci_changelog(changes) -%>
-<% else %>
-	<p><strong><%:There are no pending changes to revert!%></strong></p>
-<% end %>
-
-<% if redir_url then %>
-	<div class="cbi-page-actions">
-		<form class="inline" method="get" action="<%=luci.util.pcdata(redir_url)%>">
-			<input class="cbi-button cbi-button-link" style="margin:0" type="submit" value="<%:Back%>" />
-		</form>
-	</div>
-<% end %>
-
-<%+footer%>
diff --git a/modules/luci-base/luasrc/view/cbi/apply_widget.htm b/modules/luci-base/luasrc/view/cbi/apply_widget.htm
deleted file mode 100644
index 0f9667390e..0000000000
--- a/modules/luci-base/luasrc/view/cbi/apply_widget.htm
+++ /dev/null
@@ -1,172 +0,0 @@
-<% export("cbi_apply_widget", function(redirect_ok, rollback_token) -%>
-<script type="text/javascript">//<![CDATA[
-	var xhr = new XHR(),
-	    uci_apply_auth = { sid: '<%=luci.dispatcher.context.authsession%>', token: '<%=token%>' },
-	    uci_apply_rollback = <%=math.max(luci.config and luci.config.apply and luci.config.apply.rollback or 30, 30)%>,
-	    uci_apply_holdoff = <%=math.max(luci.config and luci.config.apply and luci.config.apply.holdoff or 4, 1)%>,
-	    uci_apply_timeout = <%=math.max(luci.config and luci.config.apply and luci.config.apply.timeout or 5, 1)%>,
-	    uci_apply_display = <%=math.max(luci.config and luci.config.apply and luci.config.apply.display or 1.5, 1)%>,
-	    uci_confirm_auth = <% if rollback_token then %>{ token: '<%=rollback_token%>' }<% else %>null<% end %>,
-	    was_xhr_poll_running = false;
-
-	function uci_status_message(type, content) {
-		if (type) {
-			var message = showModal('', '');
-
-			message.classList.add('alert-message');
-			DOMTokenList.prototype.add.apply(message.classList, type.split(/\s+/));
-
-			if (content)
-				message.innerHTML = content;
-
-			if (!was_xhr_poll_running) {
-				was_xhr_poll_running = XHR.running();
-				XHR.halt();
-			}
-		}
-		else {
-			hideModal();
-
-			if (was_xhr_poll_running)
-				XHR.run();
-		}
-	}
-
-	function uci_rollback(checked) {
-		if (checked) {
-			uci_status_message('warning spinning',
-				'<p><%:Failed to confirm apply within %ds, waiting for rollback…%></p>'.format(uci_apply_rollback));
-
-			var call = function(r, data, duration) {
-				if (r.status === 204) {
-					uci_status_message('warning',
-						'<h4><%:Configuration has been rolled back!%></h4>' +
-						'<p><%:The device could not be reached within %d seconds after applying the pending changes, which caused the configuration to be rolled back for safety reasons. If you believe that the configuration changes are correct nonetheless, proceed by applying anyway. Alternatively, you can dismiss this warning and edit changes before attempting to apply again, or revert all pending changes to keep the currently working configuration state.%></p>'.format(uci_apply_rollback) +
-						'<div class="right">' +
-							'<input type="button" class="btn" onclick="uci_status_message(false)" value="<%:Dismiss%>" /> ' +
-							'<input type="button" class="btn cbi-button-action important" onclick="uci_revert()" value="<%:Revert changes%>" /> ' +
-							'<input type="button" class="btn cbi-button-negative important" onclick="uci_apply(false)" value="<%:Apply anyway%>" />' +
-						'</div>');
-
-					return;
-				}
-
-				var delay = isNaN(duration) ? 0 : Math.max(1000 - duration, 0);
-				window.setTimeout(function() {
-					xhr.post('<%=url("admin/uci/confirm")%>', uci_apply_auth, call, uci_apply_timeout * 1000);
-				}, delay);
-			};
-
-			call({ status: 0 });
-		}
-		else {
-			uci_status_message('warning',
-				'<h4><%:Device unreachable!%></h4>' +
-				'<p><%:Could not regain access to the device after applying the configuration changes. You might need to reconnect if you modified network related settings such as the IP address or wireless security credentials.%></p>');
-		}
-	}
-
-	function uci_confirm(checked, deadline) {
-		var tt;
-		var ts = Date.now();
-
-		uci_status_message('notice');
-
-		var call = function(r, data, duration) {
-			if (Date.now() >= deadline) {
-				window.clearTimeout(tt);
-				uci_rollback(checked);
-				return;
-			}
-			else if (r && (r.status === 200 || r.status === 204)) {
-				var indicator = document.querySelector('.uci_change_indicator');
-				if (indicator) indicator.style.display = 'none';
-
-				uci_status_message('notice', '<p><%:Configuration has been applied.%></p>');
-
-				window.clearTimeout(tt);
-				window.setTimeout(function() {
-					<% if redirect_ok then -%>
-						location.href = decodeURIComponent('<%=luci.util.urlencode(redirect_ok)%>');
-					<%- else -%>
-						window.location = window.location.href.split('#')[0];
-					<% end %>
-				}, uci_apply_display * 1000);
-
-				return;
-			}
-
-			var delay = isNaN(duration) ? 0 : Math.max(1000 - duration, 0);
-			window.setTimeout(function() {
-				xhr.post('<%=url("admin/uci/confirm")%>', uci_confirm_auth, call, uci_apply_timeout * 1000);
-			}, delay);
-		};
-
-		var tick = function() {
-			var now = Date.now();
-
-			uci_status_message('notice spinning',
-				'<p><%:Waiting for configuration to be applied… %ds%></p>'.format(Math.max(Math.floor((deadline - Date.now()) / 1000), 0)));
-
-			if (now >= deadline)
-				return;
-
-			tt = window.setTimeout(tick, 1000 - (now - ts));
-			ts = now;
-		};
-
-		tick();
-
-		/* wait a few seconds for the settings to become effective */
-		window.setTimeout(call, Math.max(uci_apply_holdoff * 1000 - ((ts + uci_apply_rollback * 1000) - deadline), 1));
-	}
-
-	function uci_apply(checked) {
-		uci_status_message('notice spinning', '<p><%:Starting configuration apply…%></p>');
-
-		xhr.post('<%=url("admin/uci")%>/' + (checked ? 'apply_rollback' : 'apply_unchecked'), uci_apply_auth, function(r, tok) {
-			if (r.status === (checked ? 200 : 204)) {
-				if (checked && tok !== null && typeof(tok) === 'object' && typeof(tok.token) === 'string')
-					uci_confirm_auth = tok;
-
-				uci_confirm(checked, Date.now() + uci_apply_rollback * 1000);
-			}
-			else if (checked && r.status === 204) {
-				uci_status_message('notice', '<p><%:There are no changes to apply.%></p>');
-				window.setTimeout(function() {
-					<% if redirect_ok then -%>
-						location.href = decodeURIComponent('<%=luci.util.urlencode(redirect_ok)%>');
-					<%- else -%>
-						uci_status_message(false);
-					<%- end %>
-				}, uci_apply_display * 1000);
-			}
-			else {
-				uci_status_message('warning', '<p><%_Apply request failed with status <code>%h</code>%></p>'.format(r.responseText || r.statusText || r.status));
-				window.setTimeout(function() { uci_status_message(false); }, uci_apply_display * 1000);
-			}
-		});
-	}
-
-	function uci_revert() {
-		uci_status_message('notice spinning', '<p><%:Reverting configuration…%></p>');
-
-		xhr.post('<%=url("admin/uci/revert")%>', uci_apply_auth, function(r) {
-			if (r.status === 200) {
-				uci_status_message('notice', '<p><%:Changes have been reverted.%></p>');
-				window.setTimeout(function() {
-					<% if redirect_ok then -%>
-						location.href = decodeURIComponent('<%=luci.util.urlencode(redirect_ok)%>');
-					<%- else -%>
-						window.location = window.location.href.split('#')[0];
-					<%- end %>
-				}, uci_apply_display * 1000);
-			}
-			else {
-				uci_status_message('warning', '<p><%_Revert request failed with status <code>%h</code>%></p>'.format(r.statusText || r.status));
-				window.setTimeout(function() { uci_status_message(false); }, uci_apply_display * 1000);
-			}
-		});
-	}
-//]]></script>
-<%-	end) %>
diff --git a/modules/luci-base/luasrc/view/footer.htm b/modules/luci-base/luasrc/view/footer.htm
index 1667d3aa9a..ba14ec8678 100644
--- a/modules/luci-base/luasrc/view/footer.htm
+++ b/modules/luci-base/luasrc/view/footer.htm
@@ -1,6 +1,6 @@
 <%#
  Copyright 2008 Steven Barth <steven@midlink.org>
- Copyright 2008 Jo-Philipp Wich <jow@openwrt.org>
+ Copyright 2008-2019 Jo-Philipp Wich <jo@mein.io>
  Licensed to the public under the Apache License 2.0.
 -%>
 
@@ -8,18 +8,15 @@
 	local is_rollback_pending, rollback_time_remaining, rollback_session, rollback_token = luci.model.uci:rollback_pending()
 
 	if is_rollback_pending or trigger_apply or trigger_revert then
-		include("cbi/apply_widget")
-		cbi_apply_widget(redirect, rollback_token)
 %>
-	<div class="alert-message" id="cbi_apply_status" style="display:none"></div>
 	<script type="text/javascript">
-		document.addEventListener("DOMContentLoaded", function() {
+		document.addEventListener("luci-loaded", function() {
 			<% if trigger_apply then -%>
-				uci_apply(true);
+				L.ui.changes.apply(true);
 			<%- elseif trigger_revert then -%>
-				uci_revert();
+				L.ui.changes.revert();
 			<%- else -%>
-				uci_confirm(true, Date.now() + <%=rollback_time_remaining%> * 1000);
+				L.ui.changes.confirm(true, Date.now() + <%=rollback_time_remaining%> * 1000, <%=luci.http.write_json(rollback_token)%>);
 			<%- end %>
 		});
 	</script>
diff --git a/modules/luci-base/luasrc/view/header.htm b/modules/luci-base/luasrc/view/header.htm
index 70839c5d82..1ef0e5b013 100644
--- a/modules/luci-base/luasrc/view/header.htm
+++ b/modules/luci-base/luasrc/view/header.htm
@@ -1,6 +1,6 @@
 <%#
  Copyright 2008 Steven Barth <steven@midlink.org>
- Copyright 2008 Jo-Philipp Wich <jow@openwrt.org>
+ Copyright 2008-2019 Jo-Philipp Wich <jo@mein.io>
  Licensed to the public under the Apache License 2.0.
 -%>
 
@@ -9,17 +9,25 @@
 		include("themes/" .. theme .. "/header")
 		luci.dispatcher.context.template_header_sent = true
 	end
+
+	local applyconf = luci.config and luci.config.apply
 %>
 
 <script type="text/javascript" src="<%=resource%>/promis.min.js"></script>
 <script type="text/javascript" src="<%=resource%>/luci.js"></script>
 <script type="text/javascript">
 	L = new LuCI(<%= luci.http.write_json({
-		token       = token,
-		resource    = resource,
-		scriptname  = luci.http.getenv("SCRIPT_NAME"),
-		pathinfo    = luci.http.getenv("PATH_INFO"),
-		requestpath = luci.dispatcher.context.requestpath,
-		pollinterval    = luci.config.main.pollinterval or 5
+		token          = token,
+		resource       = resource,
+		scriptname     = luci.http.getenv("SCRIPT_NAME"),
+		pathinfo       = luci.http.getenv("PATH_INFO"),
+		requestpath    = luci.dispatcher.context.requestpath,
+		pollinterval   = luci.config.main.pollinterval or 5,
+		sessionid      = luci.dispatcher.context.authsession,
+		apply_rollback = math.max(applyconf and applyconf.rollback or 30, 30),
+		apply_holdoff  = math.max(applyconf and applyconf.holdoff or 4, 1),
+		apply_timeout  = math.max(applyconf and applyconf.timeout or 5, 1),
+		apply_display  = math.max(applyconf and applyconf.display or 1.5, 1),
+		rollback_token = rollback_token
 	}) %>);
 </script>