summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorJo-Philipp Wich <jo@mein.io>2021-06-05 16:16:14 +0200
committerJo-Philipp Wich <jo@mein.io>2021-06-05 16:17:37 +0200
commit3c6b59504aaa6ee33a2ee768aafc0aeaefb06004 (patch)
treec064ecae64feb62342da0338a9f4ad7a7216663c
parent1bfeec69948c4743ec61f0778919f14643844bd5 (diff)
luci-mod-interfaces: simplify configuring MAC address of 802.1q devices
Treat not explicitly configured, preexisting VLAN interfaces as simple network devices when adding configuration for them, since it is more likely that people want to set general device properties such as MAC address instead of reconfiguring ingress/egress QoS mapping, which is the only editable property of preexisting VLAN device config dialogs. Ref: https://github.com/openwrt/luci/issues/5102 Signed-off-by: Jo-Philipp Wich <jo@mein.io>
-rw-r--r--modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js12
1 files changed, 12 insertions, 0 deletions
diff --git a/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js b/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js
index a8e289c480..ee946f836e 100644
--- a/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js
+++ b/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js
@@ -1124,6 +1124,18 @@ return view.extend({
if (m) {
var devtype = getDevType(section_id);
+ /* Treat not explicitly configured, preexisting VLAN interfaces
+ as simple network devices when adding configuration for them,
+ since it is more likely that people want to set general device
+ properties such as MAC address instead of reconfiguring ingress/
+ egress QoS mapping, which is the only editable property of
+ preexisting VLAN device config dialogs.
+
+ Ref: https://github.com/openwrt/luci/issues/5102
+ */
+ if (devtype == '8021q')
+ devtype = 'ethernet';
+
section_id = uci.add('network', 'device');
uci.set('network', section_id, 'name', m[1]);