diff options
| author | Hannu Nyman <hannu.nyman@iki.fi> | 2016-02-02 14:22:16 +0200 |
|---|---|---|
| committer | Hannu Nyman <hannu.nyman@iki.fi> | 2016-02-02 14:34:10 +0200 |
| commit | 8f8957f90f2c593e233d867cab48519a2215b8a0 (patch) | |
| tree | 8f7831dc0885d91c93a8d85ed3fd93f4c8db81aa | |
| parent | d65235f64a83ee5ebb54c5e6f97689c8ae5dcba9 (diff) | |
luci-app-statistics: Remove usually empty std.dev. graph from ping page
Remove the usually empty standard deviation graph from the ping page.
The graph is empty for most users as collectd measures standard deviation
of individual pings inside the general interval of statistics collection.
Default setting for both ping interval and general collection interval
is 30s in Luci statistics, meaning just 1 ping per interval, which
leads to empty graph.
(To provide relveant data, the ping interval should be 1/4-1/5 of the
general collection interval. Even then the graph does not look very
informative due to different scaling than the latency graph.)
Note that this commit does not change collectd itself, which continues
to collect and calculate also the std.dev. data, which can be fetched
with 'rrdtool' if needed.
Signed-off-by: Hannu Nyman <hannu.nyman@iki.fi>
| -rw-r--r-- | applications/luci-app-statistics/luasrc/statistics/rrdtool/definitions/ping.lua | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/applications/luci-app-statistics/luasrc/statistics/rrdtool/definitions/ping.lua b/applications/luci-app-statistics/luasrc/statistics/rrdtool/definitions/ping.lua index f0a5948169..6ecdb5c8ad 100644 --- a/applications/luci-app-statistics/luasrc/statistics/rrdtool/definitions/ping.lua +++ b/applications/luci-app-statistics/luasrc/statistics/rrdtool/definitions/ping.lua @@ -23,16 +23,6 @@ function rrdargs( graph, plugin, plugin_instance, dtype ) types = { "ping_droprate" }, options = { ping_droprate = { noarea = true, overlay = true, title = "%di" } } - } }, - - -- Ping standard deviation - { title = "%H: ICMP Standard Deviation", - vlabel = "ms", - number_format = "%5.2lf ms", - data = { - types = { "ping_stddev" }, - options = { ping_stddev = { - noarea = true, overlay = true, title = "%di" } } - } }, + } } } end |