summaryrefslogtreecommitdiffhomepage
diff options
context:
space:
mode:
authorKevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>2017-05-17 14:29:43 +0100
committerKevin Darbyshire-Bryant <6500011+ldir-EDB0@users.noreply.github.com>2018-11-12 15:38:36 +0000
commit2e37a8ba10c4ba5b23e93c1f34ef580472d83248 (patch)
treecdb929e41e0d23d5b720b350df1bad456293b047
parent8e6af11715eddc0d186ee4462f4f8fb5ee102016 (diff)
luci-mod-admin-full: dnsmasq clarify non-wildcard mode
'non-wildcard' interfaces enables dnsmasq's '--bind-dynamic' mode. This binds dynamically to interfaces rather than wildcard addresses *and* keeps track of interface comings/goings via a unique Linux api. Quoting dnsmasq's author "bind-dynamic (bind individual addresses, keep up with changes in interface config) ... On linux, there's actually no sane reason not to use --bind-dynamic, and it's only not the default for historical reasons." listen/exclude interfaces may be used independently of bind dynamic mode so removed the bogus dependency of 'nonwildcard' enabling access to 'listen/exclude' interfaces - they may be used in any mode.. In fact the dnsmasq init script takes notice of include/exclude interfaces irrespective of the 'nonwildcard' parameter. Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
-rw-r--r--modules/luci-mod-network/luasrc/model/cbi/admin_network/dhcp.lua6
1 files changed, 2 insertions, 4 deletions
diff --git a/modules/luci-mod-network/luasrc/model/cbi/admin_network/dhcp.lua b/modules/luci-mod-network/luasrc/model/cbi/admin_network/dhcp.lua
index 3ac49d635d..e886d84224 100644
--- a/modules/luci-mod-network/luasrc/model/cbi/admin_network/dhcp.lua
+++ b/modules/luci-mod-network/luasrc/model/cbi/admin_network/dhcp.lua
@@ -250,21 +250,19 @@ o.rmempty = false
o = s:taboption("general", Flag, "nonwildcard",
translate("Non-wildcard"),
- translate("Bind only to specific interfaces rather than wildcard address."))
+ translate("Bind dynamically to interfaces rather than wildcard address (recommended as linux default)"))
o.optional = false
-o.rmempty = false
+o.rmempty = true
o = s:taboption("general", DynamicList, "interface",
translate("Listen Interfaces"),
translate("Limit listening to these interfaces, and loopback."))
o.optional = true
-o:depends("nonwildcard", true)
o = s:taboption("general", DynamicList, "notinterface",
translate("Exclude interfaces"),
translate("Prevent listening on these interfaces."))
o.optional = true
-o:depends("nonwildcard", true)
m:section(SimpleSection).template = "lease_status"