summaryrefslogtreecommitdiffhomepage
path: root/dhcpv4/bsdp/bsdp_test.go
diff options
context:
space:
mode:
Diffstat (limited to 'dhcpv4/bsdp/bsdp_test.go')
-rw-r--r--dhcpv4/bsdp/bsdp_test.go280
1 files changed, 224 insertions, 56 deletions
diff --git a/dhcpv4/bsdp/bsdp_test.go b/dhcpv4/bsdp/bsdp_test.go
index fc1aedf..6029d49 100644
--- a/dhcpv4/bsdp/bsdp_test.go
+++ b/dhcpv4/bsdp/bsdp_test.go
@@ -52,43 +52,31 @@ func TestNeedsReplyPort(t *testing.T) {
require.False(t, needsReplyPort(dhcpv4.ClientPort))
}
-// TODO(get9): Remove when #99 lands.
-func newInform() *dhcpv4.DHCPv4 {
- p, _ := dhcpv4.New()
- p.SetClientIPAddr(net.IP{1, 2, 3, 4})
- p.SetGatewayIPAddr(net.IP{4, 3, 2, 1})
- p.SetHwType(iana.HwTypeEthernet)
- hwAddr := [16]byte{1, 2, 3, 4, 5, 6}
- p.SetClientHwAddr(hwAddr[:])
- p.SetHwAddrLen(6)
- return p
-}
-
-func TestNewReplyForInformList_NoDefaultImage(t *testing.T) {
+func TestNewReplyForInformSelect_NoSelectedImage(t *testing.T) {
inform := newInform()
- _, err := NewReplyForInformList(inform, ReplyConfig{})
+ _, err := NewReplyForInformSelect(inform, ReplyConfig{})
require.Error(t, err)
}
-func TestNewReplyForInformList_NoImages(t *testing.T) {
+func TestNewReplyForInformSelect_NoImages(t *testing.T) {
inform := newInform()
fakeImage := BootImage{
ID: BootImageID{ImageType: BootImageTypeMacOSX},
}
- _, err := NewReplyForInformList(inform, ReplyConfig{
- Images: []BootImage{},
- DefaultImage: &fakeImage,
+ _, err := NewReplyForInformSelect(inform, ReplyConfig{
+ Images: []BootImage{},
+ SelectedImage: &fakeImage,
})
require.Error(t, err)
- _, err = NewReplyForInformList(inform, ReplyConfig{
+ _, err = NewReplyForInformSelect(inform, ReplyConfig{
Images: nil,
SelectedImage: &fakeImage,
})
+ require.Error(t, err)
}
-// TODO (get9): clean up when #99 lands.
-func TestNewReplyForInformList(t *testing.T) {
+func TestNewReplyForInformSelect(t *testing.T) {
inform := newInform()
images := []BootImage{
BootImage{
@@ -110,12 +98,12 @@ func TestNewReplyForInformList(t *testing.T) {
}
config := ReplyConfig{
Images: images,
- DefaultImage: &images[0],
+ SelectedImage: &images[0],
ServerIP: net.IP{9, 9, 9, 9},
ServerHostname: "bsdp.foo.com",
ServerPriority: 0x7070,
}
- ack, err := NewReplyForInformList(inform, config)
+ ack, err := NewReplyForInformSelect(inform, config)
require.NoError(t, err)
require.Equal(t, net.IP{1, 2, 3, 4}, ack.ClientIPAddr())
require.Equal(t, net.IPv4zero, ack.YourIPAddr())
@@ -144,62 +132,221 @@ func TestNewReplyForInformList(t *testing.T) {
vendorOpts := ack.GetOneOption(dhcpv4.OptionVendorSpecificInformation).(*OptVendorSpecificInformation)
require.Equal(
t,
- &OptMessageType{Type: MessageTypeList},
+ &OptMessageType{Type: MessageTypeSelect},
vendorOpts.GetOneOption(OptionMessageType).(*OptMessageType),
)
require.Equal(
t,
- &OptServerPriority{Priority: 0x7070},
- vendorOpts.GetOneOption(OptionServerPriority).(*OptServerPriority),
- )
- require.Equal(
- t,
- &OptDefaultBootImageID{ID: images[0].ID},
- vendorOpts.GetOneOption(OptionDefaultBootImageID).(*OptDefaultBootImageID),
- )
- require.Equal(
- t,
- &OptBootImageList{Images: images},
- vendorOpts.GetOneOption(OptionBootImageList).(*OptBootImageList),
- )
-
- // Add in selected boot image, ensure it's in the generated ACK.
- config.SelectedImage = &images[0]
- ack, err = NewReplyForInformList(inform, config)
- require.NoError(t, err)
- vendorOpts = ack.GetOneOption(dhcpv4.OptionVendorSpecificInformation).(*OptVendorSpecificInformation)
- require.Equal(
- t,
&OptSelectedBootImageID{ID: images[0].ID},
vendorOpts.GetOneOption(OptionSelectedBootImageID).(*OptSelectedBootImageID),
)
}
-func TestNewReplyForInformSelect_NoSelectedImage(t *testing.T) {
+func TestNewInformList_NoReplyPort(t *testing.T) {
+ hwAddr := net.HardwareAddr{1, 2, 3, 4, 5, 6}
+ localIP := net.IPv4(10, 10, 11, 11)
+ m, err := NewInformList(hwAddr, localIP, 0)
+
+ require.NoError(t, err)
+ require.True(t, dhcpv4.HasOption(m, dhcpv4.OptionVendorSpecificInformation))
+ require.True(t, dhcpv4.HasOption(m, dhcpv4.OptionParameterRequestList))
+ require.True(t, dhcpv4.HasOption(m, dhcpv4.OptionMaximumDHCPMessageSize))
+ require.True(t, dhcpv4.HasOption(m, dhcpv4.OptionEnd))
+
+ opt := m.GetOneOption(dhcpv4.OptionVendorSpecificInformation)
+ require.NotNil(t, opt, "vendor opts not present")
+ vendorInfo := opt.(*OptVendorSpecificInformation)
+ require.True(t, dhcpv4.HasOption(vendorInfo, OptionMessageType))
+ require.True(t, dhcpv4.HasOption(vendorInfo, OptionVersion))
+
+ opt = vendorInfo.GetOneOption(OptionMessageType)
+ require.Equal(t, MessageTypeList, opt.(*OptMessageType).Type)
+}
+
+func TestNewInformList_ReplyPort(t *testing.T) {
+ hwAddr := net.HardwareAddr{1, 2, 3, 4, 5, 6}
+ localIP := net.IPv4(10, 10, 11, 11)
+ replyPort := uint16(11223)
+
+ // Bad reply port
+ _, err := NewInformList(hwAddr, localIP, replyPort)
+ require.Error(t, err)
+
+ // Good reply port
+ replyPort = uint16(999)
+ m, err := NewInformList(hwAddr, localIP, replyPort)
+ require.NoError(t, err)
+
+ opt := m.GetOneOption(dhcpv4.OptionVendorSpecificInformation)
+ vendorInfo := opt.(*OptVendorSpecificInformation)
+ require.True(t, dhcpv4.HasOption(vendorInfo, OptionReplyPort))
+
+ opt = vendorInfo.GetOneOption(OptionReplyPort)
+ require.Equal(t, replyPort, opt.(*OptReplyPort).Port)
+}
+
+func newAck(hwAddr []byte, transactionID uint32) *dhcpv4.DHCPv4 {
+ ack, _ := dhcpv4.New()
+ ack.SetTransactionID(transactionID)
+ ack.SetHwType(iana.HwTypeEthernet)
+ ack.SetClientHwAddr(hwAddr)
+ ack.SetHwAddrLen(uint8(len(hwAddr)))
+ ack.AddOption(&dhcpv4.OptMessageType{MessageType: dhcpv4.MessageTypeAck})
+ ack.AddOption(&dhcpv4.OptionGeneric{OptionCode: dhcpv4.OptionEnd})
+ return ack
+}
+
+func TestInformSelectForAck_Broadcast(t *testing.T) {
+ hwAddr := []byte{0x11, 0x22, 0x33, 0x44, 0x55, 0x66}
+ tid := uint32(22)
+ serverID := net.IPv4(1, 2, 3, 4)
+ bootImage := BootImage{
+ ID: BootImageID{
+ IsInstall: true,
+ ImageType: BootImageTypeMacOSX,
+ Index: 0x1000,
+ },
+ Name: "bsdp-1",
+ }
+ ack := newAck(hwAddr, tid)
+ ack.SetBroadcast()
+ ack.AddOption(&dhcpv4.OptServerIdentifier{ServerID: serverID})
+
+ m, err := InformSelectForAck(*ack, 0, bootImage)
+ require.NoError(t, err)
+ require.Equal(t, dhcpv4.OpcodeBootRequest, m.Opcode())
+ require.Equal(t, ack.HwType(), m.HwType())
+ require.Equal(t, ack.ClientHwAddr(), m.ClientHwAddr())
+ require.Equal(t, ack.TransactionID(), m.TransactionID())
+ require.True(t, m.IsBroadcast())
+
+ // Validate options.
+ require.True(t, dhcpv4.HasOption(m, dhcpv4.OptionClassIdentifier))
+ require.True(t, dhcpv4.HasOption(m, dhcpv4.OptionParameterRequestList))
+ require.True(t, dhcpv4.HasOption(m, dhcpv4.OptionDHCPMessageType))
+ opt := m.GetOneOption(dhcpv4.OptionDHCPMessageType)
+ require.Equal(t, dhcpv4.MessageTypeInform, opt.(*dhcpv4.OptMessageType).MessageType)
+ require.True(t, dhcpv4.HasOption(m, dhcpv4.OptionEnd))
+
+ // Validate vendor opts.
+ require.True(t, dhcpv4.HasOption(m, dhcpv4.OptionVendorSpecificInformation))
+ opt = m.GetOneOption(dhcpv4.OptionVendorSpecificInformation)
+ vendorInfo := opt.(*OptVendorSpecificInformation)
+ require.True(t, dhcpv4.HasOption(vendorInfo, OptionMessageType))
+ opt = vendorInfo.GetOneOption(OptionMessageType)
+ require.Equal(t, MessageTypeSelect, opt.(*OptMessageType).Type)
+ require.True(t, dhcpv4.HasOption(vendorInfo, OptionVersion))
+ require.True(t, dhcpv4.HasOption(vendorInfo, OptionSelectedBootImageID))
+ opt = vendorInfo.GetOneOption(OptionSelectedBootImageID)
+ require.Equal(t, bootImage.ID, opt.(*OptSelectedBootImageID).ID)
+ require.True(t, dhcpv4.HasOption(vendorInfo, OptionServerIdentifier))
+ opt = vendorInfo.GetOneOption(OptionServerIdentifier)
+ require.True(t, serverID.Equal(opt.(*OptServerIdentifier).ServerID))
+}
+
+func TestInformSelectForAck_NoServerID(t *testing.T) {
+ hwAddr := []byte{0x11, 0x22, 0x33, 0x44, 0x55, 0x66}
+ tid := uint32(22)
+ bootImage := BootImage{
+ ID: BootImageID{
+ IsInstall: true,
+ ImageType: BootImageTypeMacOSX,
+ Index: 0x1000,
+ },
+ Name: "bsdp-1",
+ }
+ ack := newAck(hwAddr, tid)
+
+ _, err := InformSelectForAck(*ack, 0, bootImage)
+ require.Error(t, err, "expect error for no server identifier option")
+}
+
+func TestInformSelectForAck_BadReplyPort(t *testing.T) {
+ hwAddr := []byte{0x11, 0x22, 0x33, 0x44, 0x55, 0x66}
+ tid := uint32(22)
+ serverID := net.IPv4(1, 2, 3, 4)
+ bootImage := BootImage{
+ ID: BootImageID{
+ IsInstall: true,
+ ImageType: BootImageTypeMacOSX,
+ Index: 0x1000,
+ },
+ Name: "bsdp-1",
+ }
+ ack := newAck(hwAddr, tid)
+ ack.SetBroadcast()
+ ack.AddOption(&dhcpv4.OptServerIdentifier{ServerID: serverID})
+
+ _, err := InformSelectForAck(*ack, 11223, bootImage)
+ require.Error(t, err, "expect error for > 1024 replyPort")
+}
+
+func TestInformSelectForAck_ReplyPort(t *testing.T) {
+ hwAddr := []byte{0x11, 0x22, 0x33, 0x44, 0x55, 0x66}
+ tid := uint32(22)
+ serverID := net.IPv4(1, 2, 3, 4)
+ bootImage := BootImage{
+ ID: BootImageID{
+ IsInstall: true,
+ ImageType: BootImageTypeMacOSX,
+ Index: 0x1000,
+ },
+ Name: "bsdp-1",
+ }
+ ack := newAck(hwAddr, tid)
+ ack.SetBroadcast()
+ ack.AddOption(&dhcpv4.OptServerIdentifier{ServerID: serverID})
+
+ replyPort := uint16(999)
+ m, err := InformSelectForAck(*ack, replyPort, bootImage)
+ require.NoError(t, err)
+
+ require.True(t, dhcpv4.HasOption(m, dhcpv4.OptionVendorSpecificInformation))
+ opt := m.GetOneOption(dhcpv4.OptionVendorSpecificInformation)
+ vendorInfo := opt.(*OptVendorSpecificInformation)
+ require.True(t, dhcpv4.HasOption(vendorInfo, OptionReplyPort))
+ opt = vendorInfo.GetOneOption(OptionReplyPort)
+ require.Equal(t, replyPort, opt.(*OptReplyPort).Port)
+}
+
+// TODO(get9): Remove when #99 lands.
+func newInform() *dhcpv4.DHCPv4 {
+ p, _ := dhcpv4.New()
+ p.SetClientIPAddr(net.IP{1, 2, 3, 4})
+ p.SetGatewayIPAddr(net.IP{4, 3, 2, 1})
+ p.SetHwType(iana.HwTypeEthernet)
+ hwAddr := [16]byte{1, 2, 3, 4, 5, 6}
+ p.SetClientHwAddr(hwAddr[:])
+ p.SetHwAddrLen(6)
+ return p
+}
+
+func TestNewReplyForInformList_NoDefaultImage(t *testing.T) {
inform := newInform()
- _, err := NewReplyForInformSelect(inform, ReplyConfig{})
+ _, err := NewReplyForInformList(inform, ReplyConfig{})
require.Error(t, err)
}
-func TestNewReplyForInformSelect_NoImages(t *testing.T) {
+func TestNewReplyForInformList_NoImages(t *testing.T) {
inform := newInform()
fakeImage := BootImage{
ID: BootImageID{ImageType: BootImageTypeMacOSX},
}
- _, err := NewReplyForInformSelect(inform, ReplyConfig{
- Images: []BootImage{},
- SelectedImage: &fakeImage,
+ _, err := NewReplyForInformList(inform, ReplyConfig{
+ Images: []BootImage{},
+ DefaultImage: &fakeImage,
})
require.Error(t, err)
- _, err = NewReplyForInformSelect(inform, ReplyConfig{
+ _, err = NewReplyForInformList(inform, ReplyConfig{
Images: nil,
SelectedImage: &fakeImage,
})
require.Error(t, err)
}
-func TestNewReplyForInformSelect(t *testing.T) {
+// TODO (get9): clean up when #99 lands.
+func TestNewReplyForInformList(t *testing.T) {
inform := newInform()
images := []BootImage{
BootImage{
@@ -221,12 +368,12 @@ func TestNewReplyForInformSelect(t *testing.T) {
}
config := ReplyConfig{
Images: images,
- SelectedImage: &images[0],
+ DefaultImage: &images[0],
ServerIP: net.IP{9, 9, 9, 9},
ServerHostname: "bsdp.foo.com",
ServerPriority: 0x7070,
}
- ack, err := NewReplyForInformSelect(inform, config)
+ ack, err := NewReplyForInformList(inform, config)
require.NoError(t, err)
require.Equal(t, net.IP{1, 2, 3, 4}, ack.ClientIPAddr())
require.Equal(t, net.IPv4zero, ack.YourIPAddr())
@@ -255,11 +402,32 @@ func TestNewReplyForInformSelect(t *testing.T) {
vendorOpts := ack.GetOneOption(dhcpv4.OptionVendorSpecificInformation).(*OptVendorSpecificInformation)
require.Equal(
t,
- &OptMessageType{Type: MessageTypeSelect},
+ &OptMessageType{Type: MessageTypeList},
vendorOpts.GetOneOption(OptionMessageType).(*OptMessageType),
)
require.Equal(
t,
+ &OptServerPriority{Priority: 0x7070},
+ vendorOpts.GetOneOption(OptionServerPriority).(*OptServerPriority),
+ )
+ require.Equal(
+ t,
+ &OptDefaultBootImageID{ID: images[0].ID},
+ vendorOpts.GetOneOption(OptionDefaultBootImageID).(*OptDefaultBootImageID),
+ )
+ require.Equal(
+ t,
+ &OptBootImageList{Images: images},
+ vendorOpts.GetOneOption(OptionBootImageList).(*OptBootImageList),
+ )
+
+ // Add in selected boot image, ensure it's in the generated ACK.
+ config.SelectedImage = &images[0]
+ ack, err = NewReplyForInformList(inform, config)
+ require.NoError(t, err)
+ vendorOpts = ack.GetOneOption(dhcpv4.OptionVendorSpecificInformation).(*OptVendorSpecificInformation)
+ require.Equal(
+ t,
&OptSelectedBootImageID{ID: images[0].ID},
vendorOpts.GetOneOption(OptionSelectedBootImageID).(*OptSelectedBootImageID),
)
generated by cgit v1.2.3 (git 2.39.1) at 2025-02-03 01:28:44 +0000