1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
|
// Copyright 2019 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// Package nogo implements binary analysis similar to bazel's nogo,
// or the unitchecker package. It exists in order to provide additional
// facilities for analysis, namely plumbing through the output from
// dumping the generated binary (to analyze actual produced code).
package nogo
import (
"encoding/json"
"errors"
"fmt"
"go/ast"
"go/build"
"go/parser"
"go/token"
"go/types"
"io"
"io/ioutil"
"log"
"os"
"path"
"path/filepath"
"reflect"
"strings"
"golang.org/x/tools/go/analysis"
"golang.org/x/tools/go/analysis/internal/facts"
"golang.org/x/tools/go/gcexportdata"
// Special case: flags live here and change overall behavior.
"gvisor.dev/gvisor/tools/checkescape"
)
// StdlibConfig is serialized as the configuration.
//
// This contains everything required for stdlib analysis.
type StdlibConfig struct {
Srcs []string
GOOS string
GOARCH string
Tags []string
}
// PackageConfig is serialized as the configuration.
//
// This contains everything required for single package analysis.
type PackageConfig struct {
ImportPath string
GoFiles []string
NonGoFiles []string
Tags []string
GOOS string
GOARCH string
ImportMap map[string]string
FactMap map[string]string
StdlibFacts string
}
// loader is a fact-loader function.
type loader func(string) ([]byte, error)
// saver is a fact-saver function.
type saver func([]byte) error
// factLoader returns a function that loads facts.
//
// This resolves all standard library facts and imported package facts up
// front. The returned loader function will never return an error, only
// empty facts.
//
// This is done because all stdlib data is stored together, and we don't want
// to load this data many times over.
func (c *PackageConfig) factLoader() (loader, error) {
allFacts := make(map[string][]byte)
if c.StdlibFacts != "" {
data, err := ioutil.ReadFile(c.StdlibFacts)
if err != nil {
return nil, fmt.Errorf("error loading stdlib facts from %q: %w", c.StdlibFacts, err)
}
var stdlibFacts map[string][]byte
if err := json.Unmarshal(data, &stdlibFacts); err != nil {
return nil, fmt.Errorf("error loading stdlib facts: %w", err)
}
for pkg, data := range stdlibFacts {
allFacts[pkg] = data
}
}
for pkg, file := range c.FactMap {
data, err := ioutil.ReadFile(file)
if err != nil {
return nil, fmt.Errorf("error loading %q: %w", file, err)
}
allFacts[pkg] = data
}
return func(path string) ([]byte, error) {
return allFacts[path], nil
}, nil
}
// shouldInclude indicates whether the file should be included.
//
// NOTE: This does only basic parsing of tags.
func (c *PackageConfig) shouldInclude(path string) (bool, error) {
ctx := build.Default
ctx.GOOS = c.GOOS
ctx.GOARCH = c.GOARCH
ctx.BuildTags = c.Tags
return ctx.MatchFile(filepath.Dir(path), filepath.Base(path))
}
// importer is an implementation of go/types.Importer.
//
// This wraps a configuration, which provides the map of package names to
// files, and the facts. Note that this importer implementation will always
// pass when a given package is not available.
type importer struct {
*PackageConfig
fset *token.FileSet
cache map[string]*types.Package
lastErr error
callback func(string) error
}
// Import implements types.Importer.Import.
func (i *importer) Import(path string) (*types.Package, error) {
if path == "unsafe" {
// Special case: go/types has pre-defined type information for
// unsafe. We ensure that this package is correct, in case any
// analyzers are specifically looking for this.
return types.Unsafe, nil
}
// Call the internal callback. This is used to resolve loading order
// for the standard library. See checkStdlib.
if i.callback != nil {
if err := i.callback(path); err != nil {
i.lastErr = err
return nil, err
}
}
// Actually load the data.
realPath, ok := i.ImportMap[path]
var (
rc io.ReadCloser
err error
)
if !ok {
// Not found in the import path. Attempt to find the package
// via the standard library.
rc, err = findStdPkg(i.GOOS, i.GOARCH, path)
} else {
// Open the file.
rc, err = os.Open(realPath)
}
if err != nil {
i.lastErr = err
return nil, err
}
defer rc.Close()
// Load all exported data.
r, err := gcexportdata.NewReader(rc)
if err != nil {
return nil, err
}
return gcexportdata.Read(r, i.fset, i.cache, path)
}
// ErrSkip indicates the package should be skipped.
var ErrSkip = errors.New("skipped")
// CheckStdlib checks the standard library.
//
// This constructs a synthetic package configuration for each library in the
// standard library sources, and call CheckPackage repeatedly.
//
// Note that not all parts of the source are expected to build. We skip obvious
// test files, and cmd files, which should not be dependencies.
func CheckStdlib(config *StdlibConfig, analyzers []*analysis.Analyzer) (allFindings []Finding, facts []byte, err error) {
if len(config.Srcs) == 0 {
return nil, nil, nil
}
// Ensure all paths are normalized.
for i := 0; i < len(config.Srcs); i++ {
config.Srcs[i] = path.Clean(config.Srcs[i])
}
// Calculate the root source directory. This is always a directory
// named 'src', of which we simply take the first we find. This is a
// bit fragile, but works for all currently known Go source
// configurations.
//
// Note that there may be extra files outside of the root source
// directory; we simply ignore those.
rootSrcPrefix := ""
for _, file := range config.Srcs {
const src = "/src/"
i := strings.Index(file, src)
if i == -1 {
// Superfluous file.
continue
}
// Index of first character after /src/.
i += len(src)
rootSrcPrefix = file[:i]
break
}
// Aggregate all files by directory.
packages := make(map[string]*PackageConfig)
for _, file := range config.Srcs {
if !strings.HasPrefix(file, rootSrcPrefix) {
// Superflouous file.
continue
}
d := path.Dir(file)
if len(rootSrcPrefix) >= len(d) {
continue // Not a file.
}
pkg := d[len(rootSrcPrefix):]
// Skip cmd packages and obvious test files: see above.
if strings.HasPrefix(pkg, "cmd/") || strings.HasSuffix(file, "_test.go") {
continue
}
c, ok := packages[pkg]
if !ok {
c = &PackageConfig{
ImportPath: pkg,
GOOS: config.GOOS,
GOARCH: config.GOARCH,
Tags: config.Tags,
}
packages[pkg] = c
}
// Add the files appropriately. Note that they will be further
// filtered by architecture and build tags below, so this need
// not be done immediately.
if strings.HasSuffix(file, ".go") {
c.GoFiles = append(c.GoFiles, file)
} else {
c.NonGoFiles = append(c.NonGoFiles, file)
}
}
// Closure to check a single package.
stdlibFacts := make(map[string][]byte)
stdlibErrs := make(map[string]error)
var checkOne func(pkg string) error // Recursive.
checkOne = func(pkg string) error {
// Is this already done?
if _, ok := stdlibFacts[pkg]; ok {
return nil
}
// Did this fail previously?
if _, ok := stdlibErrs[pkg]; ok {
return nil
}
// Lookup the configuration.
config, ok := packages[pkg]
if !ok {
return nil // Not known.
}
// Find the binary package, and provide to objdump.
rc, err := findStdPkg(config.GOOS, config.GOARCH, pkg)
if err != nil {
// If there's no binary for this package, it is likely
// not built with the distribution. That's fine, we can
// just skip analysis.
stdlibErrs[pkg] = err
return nil
}
// Provide the input.
oldReader := checkescape.Reader
checkescape.Reader = rc // For analysis.
defer func() {
rc.Close()
checkescape.Reader = oldReader // Restore.
}()
// Run the analysis.
findings, factData, err := CheckPackage(config, analyzers, checkOne)
if err != nil {
// If we can't analyze a package from the standard library,
// then we skip it. It will simply not have any findings.
stdlibErrs[pkg] = err
return nil
}
stdlibFacts[pkg] = factData
allFindings = append(allFindings, findings...)
return nil
}
// Check all packages.
//
// Note that this may call checkOne recursively, so it's not guaranteed
// to evaluate in the order provided here. We do ensure however, that
// all packages are evaluated.
for pkg := range packages {
if err := checkOne(pkg); err != nil {
return nil, nil, err
}
}
// Sanity check.
if len(stdlibFacts) == 0 {
return nil, nil, fmt.Errorf("no stdlib facts found: misconfiguration?")
}
// Write out all findings.
factData, err := json.Marshal(stdlibFacts)
if err != nil {
return nil, nil, fmt.Errorf("error saving stdlib facts: %w", err)
}
// Write out all errors.
for pkg, err := range stdlibErrs {
log.Printf("WARNING: error while processing %v: %v", pkg, err)
}
// Return all findings.
return allFindings, factData, nil
}
// CheckPackage runs all given analyzers.
//
// The implementation was adapted from [1], which was in turn adpated from [2].
// This returns a list of matching analysis issues, or an error if the analysis
// could not be completed.
//
// [1] bazelbuid/rules_go/tools/builders/nogo_main.go
// [2] golang.org/x/tools/go/checker/internal/checker
func CheckPackage(config *PackageConfig, analyzers []*analysis.Analyzer, importCallback func(string) error) (findings []Finding, factData []byte, err error) {
imp := &importer{
PackageConfig: config,
fset: token.NewFileSet(),
cache: make(map[string]*types.Package),
callback: importCallback,
}
// Load all source files.
var syntax []*ast.File
for _, file := range config.GoFiles {
include, err := config.shouldInclude(file)
if err != nil {
return nil, nil, fmt.Errorf("error evaluating file %q: %v", file, err)
}
if !include {
continue
}
s, err := parser.ParseFile(imp.fset, file, nil, parser.ParseComments)
if err != nil {
return nil, nil, fmt.Errorf("error parsing file %q: %v", file, err)
}
syntax = append(syntax, s)
}
// Check type information.
typesSizes := types.SizesFor("gc", config.GOARCH)
typeConfig := types.Config{Importer: imp}
typesInfo := &types.Info{
Types: make(map[ast.Expr]types.TypeAndValue),
Uses: make(map[*ast.Ident]types.Object),
Defs: make(map[*ast.Ident]types.Object),
Implicits: make(map[ast.Node]types.Object),
Scopes: make(map[ast.Node]*types.Scope),
Selections: make(map[*ast.SelectorExpr]*types.Selection),
}
types, err := typeConfig.Check(config.ImportPath, imp.fset, syntax, typesInfo)
if err != nil && imp.lastErr != ErrSkip {
return nil, nil, fmt.Errorf("error checking types: %w", err)
}
// Load all package facts.
loader, err := config.factLoader()
if err != nil {
return nil, nil, fmt.Errorf("error loading facts: %w", err)
}
facts, err := facts.Decode(types, loader)
if err != nil {
return nil, nil, fmt.Errorf("error decoding facts: %w", err)
}
// Register fact types and establish dependencies between analyzers.
// The visit closure will execute recursively, and populate results
// will all required analysis results.
results := make(map[*analysis.Analyzer]interface{})
var visit func(*analysis.Analyzer) error // For recursion.
visit = func(a *analysis.Analyzer) error {
if _, ok := results[a]; ok {
return nil
}
// Run recursively for all dependencies.
for _, req := range a.Requires {
if err := visit(req); err != nil {
return err
}
}
// Run the analysis.
factFilter := make(map[reflect.Type]bool)
for _, f := range a.FactTypes {
factFilter[reflect.TypeOf(f)] = true
}
p := &analysis.Pass{
Analyzer: a,
Fset: imp.fset,
Files: syntax,
Pkg: types,
TypesInfo: typesInfo,
ResultOf: results, // All results.
Report: func(d analysis.Diagnostic) {
findings = append(findings, Finding{
Category: AnalyzerName(a.Name),
Position: imp.fset.Position(d.Pos),
Message: d.Message,
})
},
ImportPackageFact: facts.ImportPackageFact,
ExportPackageFact: facts.ExportPackageFact,
ImportObjectFact: facts.ImportObjectFact,
ExportObjectFact: facts.ExportObjectFact,
AllPackageFacts: func() []analysis.PackageFact { return facts.AllPackageFacts(factFilter) },
AllObjectFacts: func() []analysis.ObjectFact { return facts.AllObjectFacts(factFilter) },
TypesSizes: typesSizes,
}
result, err := a.Run(p)
if err != nil {
return fmt.Errorf("error running analysis %s: %v", a, err)
}
// Sanity check & save the result.
if got, want := reflect.TypeOf(result), a.ResultType; got != want {
return fmt.Errorf("error: analyzer %s returned a result of type %v, but declared ResultType %v", a, got, want)
}
results[a] = result
return nil // Success.
}
// Visit all analyzers recursively.
for _, a := range analyzers {
if imp.lastErr == ErrSkip {
continue // No local analysis.
}
if err := visit(a); err != nil {
return nil, nil, err // Already has context.
}
}
// Return all findings.
return findings, facts.Encode(), nil
}
|