1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
|
// Copyright 2020 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// Package marshal_test contains manual tests for the marshal interface. These
// are intended to test behaviour not covered by the automatically generated
// tests.
package marshal_test
import (
"bytes"
"encoding/binary"
"fmt"
"reflect"
"runtime"
"testing"
"unsafe"
"github.com/google/go-cmp/cmp"
"gvisor.dev/gvisor/pkg/marshal"
"gvisor.dev/gvisor/pkg/syserror"
"gvisor.dev/gvisor/pkg/usermem"
"gvisor.dev/gvisor/tools/go_marshal/analysis"
"gvisor.dev/gvisor/tools/go_marshal/test"
)
var simulatedErr error = syserror.EFAULT
// mockCopyContext implements marshal.CopyContext.
type mockCopyContext struct {
taskMem usermem.BytesIO
}
// populate fills the task memory with the contents of val.
func (t *mockCopyContext) populate(val interface{}) {
var buf bytes.Buffer
// Use binary.Write so we aren't testing go-marshal against its own
// potentially buggy implementation.
if err := binary.Write(&buf, usermem.ByteOrder, val); err != nil {
panic(err)
}
t.taskMem.Bytes = buf.Bytes()
}
func (t *mockCopyContext) setLimit(n int) {
if len(t.taskMem.Bytes) < n {
grown := make([]byte, n)
copy(grown, t.taskMem.Bytes)
t.taskMem.Bytes = grown
return
}
t.taskMem.Bytes = t.taskMem.Bytes[:n]
}
// CopyScratchBuffer implements marshal.CopyContext.CopyScratchBuffer.
func (t *mockCopyContext) CopyScratchBuffer(size int) []byte {
return make([]byte, size)
}
// CopyOutBytes implements marshal.CopyContext.CopyOutBytes. The implementation
// completely ignores the target address and stores a copy of b in its
// internally buffer, overriding any previous contents.
func (t *mockCopyContext) CopyOutBytes(_ usermem.Addr, b []byte) (int, error) {
return t.taskMem.CopyOut(nil, 0, b, usermem.IOOpts{})
}
// CopyInBytes implements marshal.CopyContext.CopyInBytes. The implementation
// completely ignores the source address and always fills b from the begining of
// its internal buffer.
func (t *mockCopyContext) CopyInBytes(_ usermem.Addr, b []byte) (int, error) {
return t.taskMem.CopyIn(nil, 0, b, usermem.IOOpts{})
}
// unsafeMemory returns the underlying memory for m. The returned slice is only
// valid for the lifetime for m. The garbage collector isn't aware that the
// returned slice is related to m, the caller must ensure m lives long enough.
func unsafeMemory(m marshal.Marshallable) []byte {
if !m.Packed() {
// We can't return a slice pointing to the underlying memory
// since the layout isn't packed. Allocate a temporary buffer
// and marshal instead.
var buf bytes.Buffer
if err := binary.Write(&buf, usermem.ByteOrder, m); err != nil {
panic(err)
}
return buf.Bytes()
}
// reflect.ValueOf(m)
// .Elem() // Unwrap interface to inner concrete object
// .Addr() // Pointer value to object
// .Pointer() // Actual address from the pointer value
ptr := reflect.ValueOf(m).Elem().Addr().Pointer()
size := m.SizeBytes()
var mem []byte
hdr := (*reflect.SliceHeader)(unsafe.Pointer(&mem))
hdr.Data = ptr
hdr.Len = size
hdr.Cap = size
return mem
}
// unsafeMemorySlice returns the underlying memory for m. The returned slice is
// only valid for the lifetime for m. The garbage collector isn't aware that the
// returned slice is related to m, the caller must ensure m lives long enough.
//
// Precondition: m must be a slice.
func unsafeMemorySlice(m interface{}, elt marshal.Marshallable) []byte {
kind := reflect.TypeOf(m).Kind()
if kind != reflect.Slice {
panic("unsafeMemorySlice called on non-slice")
}
if !elt.Packed() {
// We can't return a slice pointing to the underlying memory
// since the layout isn't packed. Allocate a temporary buffer
// and marshal instead.
var buf bytes.Buffer
if err := binary.Write(&buf, usermem.ByteOrder, m); err != nil {
panic(err)
}
return buf.Bytes()
}
v := reflect.ValueOf(m)
length := v.Len() * elt.SizeBytes()
var mem []byte
hdr := (*reflect.SliceHeader)(unsafe.Pointer(&mem))
hdr.Data = v.Pointer() // This is a pointer to the first elem for slices.
hdr.Len = length
hdr.Cap = length
return mem
}
func isZeroes(buf []byte) bool {
for _, b := range buf {
if b != 0 {
return false
}
}
return true
}
// compareMemory compares the first n bytes of two chuncks of memory represented
// by expected and actual.
func compareMemory(t *testing.T, expected, actual []byte, n int) {
t.Logf("Expected (%d): %v (%d) + (%d) %v\n", len(expected), expected[:n], n, len(expected)-n, expected[n:])
t.Logf("Actual (%d): %v (%d) + (%d) %v\n", len(actual), actual[:n], n, len(actual)-n, actual[n:])
if diff := cmp.Diff(expected[:n], actual[:n]); diff != "" {
t.Errorf("Memory buffers don't match:\n--- expected only\n+++ actual only\n%v", diff)
}
}
// limitedCopyIn populates task memory with src, then unmarshals task memory to
// dst. The task signals an error at limit bytes during copy-in, which should
// result in a truncated unmarshalling.
func limitedCopyIn(t *testing.T, src, dst marshal.Marshallable, limit int) {
var cc mockCopyContext
cc.populate(src)
cc.setLimit(limit)
n, err := dst.CopyIn(&cc, usermem.Addr(0))
if n != limit {
t.Errorf("CopyIn copied unexpected number of bytes, expected %d, got %d", limit, n)
}
if err != simulatedErr {
t.Errorf("CopyIn returned unexpected error, expected %v, got %v", simulatedErr, err)
}
expectedMem := unsafeMemory(src)
defer runtime.KeepAlive(src)
actualMem := unsafeMemory(dst)
defer runtime.KeepAlive(dst)
compareMemory(t, expectedMem, actualMem, n)
// The last n bytes should be zero for actual, since actual was
// zero-initialized, and CopyIn shouldn't have touched those bytes. However
// we can only guarantee we didn't touch anything in the last n bytes if the
// layout is packed.
if dst.Packed() && !isZeroes(actualMem[n:]) {
t.Errorf("Expected the last %d bytes of copied in object to be zeroes, got %v\n", dst.SizeBytes()-n, actualMem)
}
}
// limitedCopyOut marshals src to task memory. The task signals an error at
// limit bytes during copy-out, which should result in a truncated marshalling.
func limitedCopyOut(t *testing.T, src marshal.Marshallable, limit int) {
var cc mockCopyContext
cc.setLimit(limit)
n, err := src.CopyOut(&cc, usermem.Addr(0))
if n != limit {
t.Errorf("CopyOut copied unexpected number of bytes, expected %d, got %d", limit, n)
}
if err != simulatedErr {
t.Errorf("CopyOut returned unexpected error, expected %v, got %v", simulatedErr, err)
}
expectedMem := unsafeMemory(src)
defer runtime.KeepAlive(src)
actualMem := cc.taskMem.Bytes
compareMemory(t, expectedMem, actualMem, n)
}
// copyOutN marshals src to task memory, requesting the marshalling to be
// limited to limit bytes.
func copyOutN(t *testing.T, src marshal.Marshallable, limit int) {
var cc mockCopyContext
cc.setLimit(limit)
n, err := src.CopyOutN(&cc, usermem.Addr(0), limit)
if err != nil {
t.Errorf("CopyOut returned unexpected error: %v", err)
}
if n != limit {
t.Errorf("CopyOut copied unexpected number of bytes, expected %d, got %d", limit, n)
}
expectedMem := unsafeMemory(src)
defer runtime.KeepAlive(src)
actualMem := cc.taskMem.Bytes
t.Logf("Expected: %v + %v\n", expectedMem[:n], expectedMem[n:])
t.Logf("Actual : %v + %v\n", actualMem[:n], actualMem[n:])
compareMemory(t, expectedMem, actualMem, n)
}
// TestLimitedMarshalling verifies marshalling/unmarshalling succeeds when the
// underyling copy in/out operations partially succeed.
func TestLimitedMarshalling(t *testing.T) {
types := []reflect.Type{
// Packed types.
reflect.TypeOf((*test.Type2)(nil)),
reflect.TypeOf((*test.Type3)(nil)),
reflect.TypeOf((*test.Timespec)(nil)),
reflect.TypeOf((*test.Stat)(nil)),
reflect.TypeOf((*test.InetAddr)(nil)),
reflect.TypeOf((*test.SignalSet)(nil)),
reflect.TypeOf((*test.SignalSetAlias)(nil)),
// Non-packed types.
reflect.TypeOf((*test.Type1)(nil)),
reflect.TypeOf((*test.Type4)(nil)),
reflect.TypeOf((*test.Type5)(nil)),
reflect.TypeOf((*test.Type6)(nil)),
reflect.TypeOf((*test.Type7)(nil)),
reflect.TypeOf((*test.Type8)(nil)),
}
for _, tyPtr := range types {
// Remove one level of pointer-indirection from the type. We get this
// back when we pass the type to reflect.New.
ty := tyPtr.Elem()
// Partial copy-in.
t.Run(fmt.Sprintf("PartialCopyIn_%v", ty), func(t *testing.T) {
expected := reflect.New(ty).Interface().(marshal.Marshallable)
actual := reflect.New(ty).Interface().(marshal.Marshallable)
analysis.RandomizeValue(expected)
limitedCopyIn(t, expected, actual, expected.SizeBytes()/2)
})
// Partial copy-out.
t.Run(fmt.Sprintf("PartialCopyOut_%v", ty), func(t *testing.T) {
expected := reflect.New(ty).Interface().(marshal.Marshallable)
analysis.RandomizeValue(expected)
limitedCopyOut(t, expected, expected.SizeBytes()/2)
})
// Explicitly request partial copy-out.
t.Run(fmt.Sprintf("PartialCopyOutN_%v", ty), func(t *testing.T) {
expected := reflect.New(ty).Interface().(marshal.Marshallable)
analysis.RandomizeValue(expected)
copyOutN(t, expected, expected.SizeBytes()/2)
})
}
}
// TestLimitedMarshalling verifies marshalling/unmarshalling of slices of
// marshallable types succeed when the underyling copy in/out operations
// partially succeed.
func TestLimitedSliceMarshalling(t *testing.T) {
types := []struct {
arrayPtrType reflect.Type
copySliceIn func(cc marshal.CopyContext, addr usermem.Addr, dstSlice interface{}) (int, error)
copySliceOut func(cc marshal.CopyContext, addr usermem.Addr, srcSlice interface{}) (int, error)
unsafeMemory func(arrPtr interface{}) []byte
}{
// Packed types.
{
reflect.TypeOf((*[20]test.Stat)(nil)),
func(cc marshal.CopyContext, addr usermem.Addr, dst interface{}) (int, error) {
slice := dst.(*[20]test.Stat)[:]
return test.CopyStatSliceIn(cc, addr, slice)
},
func(cc marshal.CopyContext, addr usermem.Addr, src interface{}) (int, error) {
slice := src.(*[20]test.Stat)[:]
return test.CopyStatSliceOut(cc, addr, slice)
},
func(a interface{}) []byte {
slice := a.(*[20]test.Stat)[:]
return unsafeMemorySlice(slice, &slice[0])
},
},
{
reflect.TypeOf((*[1]test.Stat)(nil)),
func(cc marshal.CopyContext, addr usermem.Addr, dst interface{}) (int, error) {
slice := dst.(*[1]test.Stat)[:]
return test.CopyStatSliceIn(cc, addr, slice)
},
func(cc marshal.CopyContext, addr usermem.Addr, src interface{}) (int, error) {
slice := src.(*[1]test.Stat)[:]
return test.CopyStatSliceOut(cc, addr, slice)
},
func(a interface{}) []byte {
slice := a.(*[1]test.Stat)[:]
return unsafeMemorySlice(slice, &slice[0])
},
},
{
reflect.TypeOf((*[5]test.SignalSetAlias)(nil)),
func(cc marshal.CopyContext, addr usermem.Addr, dst interface{}) (int, error) {
slice := dst.(*[5]test.SignalSetAlias)[:]
return test.CopySignalSetAliasSliceIn(cc, addr, slice)
},
func(cc marshal.CopyContext, addr usermem.Addr, src interface{}) (int, error) {
slice := src.(*[5]test.SignalSetAlias)[:]
return test.CopySignalSetAliasSliceOut(cc, addr, slice)
},
func(a interface{}) []byte {
slice := a.(*[5]test.SignalSetAlias)[:]
return unsafeMemorySlice(slice, &slice[0])
},
},
// Non-packed types.
{
reflect.TypeOf((*[20]test.Type1)(nil)),
func(cc marshal.CopyContext, addr usermem.Addr, dst interface{}) (int, error) {
slice := dst.(*[20]test.Type1)[:]
return test.CopyType1SliceIn(cc, addr, slice)
},
func(cc marshal.CopyContext, addr usermem.Addr, src interface{}) (int, error) {
slice := src.(*[20]test.Type1)[:]
return test.CopyType1SliceOut(cc, addr, slice)
},
func(a interface{}) []byte {
slice := a.(*[20]test.Type1)[:]
return unsafeMemorySlice(slice, &slice[0])
},
},
{
reflect.TypeOf((*[1]test.Type1)(nil)),
func(cc marshal.CopyContext, addr usermem.Addr, dst interface{}) (int, error) {
slice := dst.(*[1]test.Type1)[:]
return test.CopyType1SliceIn(cc, addr, slice)
},
func(cc marshal.CopyContext, addr usermem.Addr, src interface{}) (int, error) {
slice := src.(*[1]test.Type1)[:]
return test.CopyType1SliceOut(cc, addr, slice)
},
func(a interface{}) []byte {
slice := a.(*[1]test.Type1)[:]
return unsafeMemorySlice(slice, &slice[0])
},
},
{
reflect.TypeOf((*[7]test.Type8)(nil)),
func(cc marshal.CopyContext, addr usermem.Addr, dst interface{}) (int, error) {
slice := dst.(*[7]test.Type8)[:]
return test.CopyType8SliceIn(cc, addr, slice)
},
func(cc marshal.CopyContext, addr usermem.Addr, src interface{}) (int, error) {
slice := src.(*[7]test.Type8)[:]
return test.CopyType8SliceOut(cc, addr, slice)
},
func(a interface{}) []byte {
slice := a.(*[7]test.Type8)[:]
return unsafeMemorySlice(slice, &slice[0])
},
},
}
for _, tt := range types {
// The body of this loop is generic over the type tt.arrayPtrType, with
// the help of reflection. To aid in readability, comments below show
// the equivalent go code assuming
// tt.arrayPtrType = typeof(*[20]test.Stat).
// Equivalent:
// var x *[20]test.Stat
// arrayTy := reflect.TypeOf(*x)
arrayTy := tt.arrayPtrType.Elem()
// Partial copy-in of slices.
t.Run(fmt.Sprintf("PartialCopySliceIn_%v", arrayTy), func(t *testing.T) {
// Equivalent:
// var x [20]test.Stat
// length := len(x)
length := arrayTy.Len()
if length < 1 {
panic("Test type can't be zero-length array")
}
// Equivalent:
// elem := new(test.Stat).(marshal.Marshallable)
elem := reflect.New(arrayTy.Elem()).Interface().(marshal.Marshallable)
// Equivalent:
// var expected, actual interface{}
// expected = new([20]test.Stat)
// actual = new([20]test.Stat)
expected := reflect.New(arrayTy).Interface()
actual := reflect.New(arrayTy).Interface()
analysis.RandomizeValue(expected)
limit := (length * elem.SizeBytes()) / 2
// Also make sure the limit is partially inside one of the elements.
limit += elem.SizeBytes() / 2
analysis.RandomizeValue(expected)
var cc mockCopyContext
cc.populate(expected)
cc.setLimit(limit)
n, err := tt.copySliceIn(&cc, usermem.Addr(0), actual)
if n != limit {
t.Errorf("CopyIn copied unexpected number of bytes, expected %d, got %d", limit, n)
}
if n < length*elem.SizeBytes() && err != simulatedErr {
t.Errorf("CopyIn returned unexpected error, expected %v, got %v", simulatedErr, err)
}
expectedMem := tt.unsafeMemory(expected)
defer runtime.KeepAlive(expected)
actualMem := tt.unsafeMemory(actual)
defer runtime.KeepAlive(actual)
compareMemory(t, expectedMem, actualMem, n)
// The last n bytes should be zero for actual, since actual was
// zero-initialized, and CopyIn shouldn't have touched those bytes. However
// we can only guarantee we didn't touch anything in the last n bytes if the
// layout is packed.
if elem.Packed() && !isZeroes(actualMem[n:]) {
t.Errorf("Expected the last %d bytes of copied in object to be zeroes, got %v\n", (elem.SizeBytes()*length)-n, actualMem)
}
})
// Partial copy-out of slices.
t.Run(fmt.Sprintf("PartialCopySliceOut_%v", arrayTy), func(t *testing.T) {
// Equivalent:
// var x [20]test.Stat
// length := len(x)
length := arrayTy.Len()
if length < 1 {
panic("Test type can't be zero-length array")
}
// Equivalent:
// elem := new(test.Stat).(marshal.Marshallable)
elem := reflect.New(arrayTy.Elem()).Interface().(marshal.Marshallable)
// Equivalent:
// var expected, actual interface{}
// expected = new([20]test.Stat)
// actual = new([20]test.Stat)
expected := reflect.New(arrayTy).Interface()
analysis.RandomizeValue(expected)
limit := (length * elem.SizeBytes()) / 2
// Also make sure the limit is partially inside one of the elements.
limit += elem.SizeBytes() / 2
analysis.RandomizeValue(expected)
var cc mockCopyContext
cc.populate(expected)
cc.setLimit(limit)
n, err := tt.copySliceOut(&cc, usermem.Addr(0), expected)
if n != limit {
t.Errorf("CopyIn copied unexpected number of bytes, expected %d, got %d", limit, n)
}
if n < length*elem.SizeBytes() && err != simulatedErr {
t.Errorf("CopyIn returned unexpected error, expected %v, got %v", simulatedErr, err)
}
expectedMem := tt.unsafeMemory(expected)
defer runtime.KeepAlive(expected)
actualMem := cc.taskMem.Bytes
compareMemory(t, expectedMem, actualMem, n)
})
}
}
|