1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
|
// Copyright 2020 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package test
func testClosureInvalid(tc *oneGuardStruct) {
// This is expected to fail.
callClosure(func() {
tc.guardedField = 1 // +checklocksfail
})
}
func testClosureUnsupported(tc *oneGuardStruct) {
// Locked outside the closure, so may or may not be valid. This cannot
// be handled and we should explicitly fail. This can't be handled
// because of the call through callClosure, below, which means the
// closure will actually be passed as a value somewhere.
tc.mu.Lock()
callClosure(func() {
tc.guardedField = 1 // +checklocksfail
})
tc.mu.Unlock()
}
func testClosureValid(tc *oneGuardStruct) {
// All locking happens within the closure. This should not present a
// problem for analysis.
callClosure(func() {
tc.mu.Lock()
tc.guardedField = 1
tc.mu.Unlock()
})
}
func testClosureInline(tc *oneGuardStruct) {
// If the closure is being dispatching inline only, then we should be
// able to analyze this call and give it a thumbs up.
tc.mu.Lock()
func() {
tc.guardedField = 1
}()
tc.mu.Unlock()
}
// +checklocksignore
func testClosureIgnore(tc *oneGuardStruct) {
// Inherit the checklocksignore.
x := func() {
tc.guardedField = 1
}
x()
}
func testAnonymousInvalid(tc *oneGuardStruct) {
// Invalid, as per testClosureInvalid above.
callAnonymous(func(tc *oneGuardStruct) {
tc.guardedField = 1 // +checklocksfail
}, tc)
}
func testAnonymousUnsupported(tc *oneGuardStruct) {
// Not supportable, as per testClosureUnsupported above.
tc.mu.Lock()
callAnonymous(func(tc *oneGuardStruct) {
tc.guardedField = 1 // +checklocksfail
}, tc)
tc.mu.Unlock()
}
func testAnonymousValid(tc *oneGuardStruct) {
// Valid, as per testClosureValid above.
callAnonymous(func(tc *oneGuardStruct) {
tc.mu.Lock()
tc.guardedField = 1
tc.mu.Unlock()
}, tc)
}
func testAnonymousInline(tc *oneGuardStruct) {
// Unlike the closure case, we are able to dynamically infer the set of
// preconditions for the function dispatch and assert that this is
// a valid call.
tc.mu.Lock()
func(tc *oneGuardStruct) {
tc.guardedField = 1
}(tc)
tc.mu.Unlock()
}
// +checklocksignore
func testAnonymousIgnore(tc *oneGuardStruct) {
// Inherit the checklocksignore.
x := func(tc *oneGuardStruct) {
tc.guardedField = 1
}
x(tc)
}
//go:noinline
func callClosure(fn func()) {
fn()
}
//go:noinline
func callAnonymous(fn func(*oneGuardStruct), tc *oneGuardStruct) {
fn(tc)
}
|
