1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
|
// Copyright 2021 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package shim
import (
"testing"
specs "github.com/opencontainers/runtime-spec/specs-go"
"gvisor.dev/gvisor/pkg/shim/utils"
)
func TestCgroupPath(t *testing.T) {
for _, tc := range []struct {
name string
path string
want string
}{
{
name: "simple",
path: "foo/pod123/container",
want: "foo/pod123",
},
{
name: "absolute",
path: "/foo/pod123/container",
want: "/foo/pod123",
},
{
name: "no-container",
path: "foo/pod123",
want: "foo/pod123",
},
{
name: "no-container-absolute",
path: "/foo/pod123",
want: "/foo/pod123",
},
{
name: "double-pod",
path: "/foo/podium/pod123/container",
want: "/foo/podium/pod123",
},
{
name: "start-pod",
path: "pod123/container",
want: "pod123",
},
{
name: "start-pod-absolute",
path: "/pod123/container",
want: "/pod123",
},
{
name: "slashes",
path: "///foo/////pod123//////container",
want: "/foo/pod123",
},
{
name: "no-pod",
path: "/foo/nopod123/container",
want: "/foo/nopod123/container",
},
} {
t.Run(tc.name, func(t *testing.T) {
spec := specs.Spec{
Linux: &specs.Linux{
CgroupsPath: tc.path,
},
}
updated := updateCgroup(&spec)
if spec.Linux.CgroupsPath != tc.want {
t.Errorf("updateCgroup(%q), want: %q, got: %q", tc.path, tc.want, spec.Linux.CgroupsPath)
}
if shouldUpdate := tc.path != tc.want; shouldUpdate != updated {
t.Errorf("updateCgroup(%q)=%v, want: %v", tc.path, updated, shouldUpdate)
}
})
}
}
// Test cases that cgroup path should not be updated.
func TestCgroupNoUpdate(t *testing.T) {
for _, tc := range []struct {
name string
spec *specs.Spec
}{
{
name: "empty",
spec: &specs.Spec{},
},
{
name: "subcontainer",
spec: &specs.Spec{
Linux: &specs.Linux{
CgroupsPath: "foo/pod123/container",
},
Annotations: map[string]string{
utils.ContainerTypeAnnotation: utils.ContainerTypeContainer,
},
},
},
} {
t.Run(tc.name, func(t *testing.T) {
if updated := updateCgroup(tc.spec); updated {
t.Errorf("updateCgroup(%+v), got: %v, want: false", tc.spec.Linux, updated)
}
})
}
}
|
