1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
|
// Copyright 2018 The gVisor Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
package fs
import (
"syscall"
"testing"
"gvisor.dev/gvisor/pkg/context"
"gvisor.dev/gvisor/pkg/sentry/contexttest"
)
func newMockDirInode(ctx context.Context, cache *DirentCache) *Inode {
return NewMockInode(ctx, NewMockMountSource(cache), StableAttr{Type: Directory})
}
func TestWalkPositive(t *testing.T) {
// refs == 0 -> one reference.
// refs == -1 -> has been destroyed.
ctx := contexttest.Context(t)
root := NewDirent(ctx, newMockDirInode(ctx, nil), "root")
if got := root.ReadRefs(); got != 1 {
t.Fatalf("root has a ref count of %d, want %d", got, 1)
}
name := "d"
d, err := root.walk(ctx, root, name, false)
if err != nil {
t.Fatalf("root.walk(root, %q) got %v, want nil", name, err)
}
if got := root.ReadRefs(); got != 2 {
t.Fatalf("root has a ref count of %d, want %d", got, 2)
}
if got := d.ReadRefs(); got != 1 {
t.Fatalf("child name = %q has a ref count of %d, want %d", d.name, got, 1)
}
d.DecRef(ctx)
if got := root.ReadRefs(); got != 1 {
t.Fatalf("root has a ref count of %d, want %d", got, 1)
}
if got := d.ReadRefs(); got != 0 {
t.Fatalf("child name = %q has a ref count of %d, want %d", d.name, got, 0)
}
root.flush(ctx)
if got := len(root.children); got != 0 {
t.Fatalf("root has %d children, want %d", got, 0)
}
}
func TestWalkNegative(t *testing.T) {
// refs == 0 -> one reference.
// refs == -1 -> has been destroyed.
ctx := contexttest.Context(t)
root := NewDirent(ctx, NewEmptyDir(ctx, nil), "root")
mn := root.Inode.InodeOperations.(*mockInodeOperationsLookupNegative)
if got := root.ReadRefs(); got != 1 {
t.Fatalf("root has a ref count of %d, want %d", got, 1)
}
name := "d"
for i := 0; i < 100; i++ {
_, err := root.walk(ctx, root, name, false)
if err != syscall.ENOENT {
t.Fatalf("root.walk(root, %q) got %v, want %v", name, err, syscall.ENOENT)
}
}
if got := root.ReadRefs(); got != 1 {
t.Fatalf("root has a ref count of %d, want %d", got, 1)
}
if got := len(root.children); got != 1 {
t.Fatalf("root has %d children, want %d", got, 1)
}
w, ok := root.children[name]
if !ok {
t.Fatalf("root wants child at %q", name)
}
child := w.Get()
if child == nil {
t.Fatalf("root wants to resolve weak reference")
}
if !child.(*Dirent).IsNegative() {
t.Fatalf("root found positive child at %q, want negative", name)
}
if got := child.(*Dirent).ReadRefs(); got != 2 {
t.Fatalf("child has a ref count of %d, want %d", got, 2)
}
child.DecRef(ctx)
if got := child.(*Dirent).ReadRefs(); got != 1 {
t.Fatalf("child has a ref count of %d, want %d", got, 1)
}
if got := len(root.children); got != 1 {
t.Fatalf("root has %d children, want %d", got, 1)
}
root.DecRef(ctx)
if got := root.ReadRefs(); got != 0 {
t.Fatalf("root has a ref count of %d, want %d", got, 0)
}
AsyncBarrier()
if got := mn.releaseCalled; got != true {
t.Fatalf("root.Close was called %v, want true", got)
}
}
type mockInodeOperationsLookupNegative struct {
*MockInodeOperations
releaseCalled bool
}
func NewEmptyDir(ctx context.Context, cache *DirentCache) *Inode {
m := NewMockMountSource(cache)
return NewInode(ctx, &mockInodeOperationsLookupNegative{
MockInodeOperations: NewMockInodeOperations(ctx),
}, m, StableAttr{Type: Directory})
}
func (m *mockInodeOperationsLookupNegative) Lookup(ctx context.Context, dir *Inode, p string) (*Dirent, error) {
return NewNegativeDirent(p), nil
}
func (m *mockInodeOperationsLookupNegative) Release(context.Context) {
m.releaseCalled = true
}
func TestHashNegativeToPositive(t *testing.T) {
// refs == 0 -> one reference.
// refs == -1 -> has been destroyed.
ctx := contexttest.Context(t)
root := NewDirent(ctx, NewEmptyDir(ctx, nil), "root")
name := "d"
_, err := root.walk(ctx, root, name, false)
if err != syscall.ENOENT {
t.Fatalf("root.walk(root, %q) got %v, want %v", name, err, syscall.ENOENT)
}
if got := root.exists(ctx, root, name); got != false {
t.Fatalf("got %q exists, want does not exist", name)
}
f, err := root.Create(ctx, root, name, FileFlags{}, FilePermissions{})
if err != nil {
t.Fatalf("root.Create(%q, _), got error %v, want nil", name, err)
}
d := f.Dirent
if d.IsNegative() {
t.Fatalf("got negative Dirent, want positive")
}
if got := d.ReadRefs(); got != 1 {
t.Fatalf("child %q has a ref count of %d, want %d", name, got, 1)
}
if got := root.ReadRefs(); got != 2 {
t.Fatalf("root has a ref count of %d, want %d", got, 2)
}
if got := len(root.children); got != 1 {
t.Fatalf("got %d children, want %d", got, 1)
}
w, ok := root.children[name]
if !ok {
t.Fatalf("failed to find weak reference to %q", name)
}
child := w.Get()
if child == nil {
t.Fatalf("want to resolve weak reference")
}
if child.(*Dirent) != d {
t.Fatalf("got foreign child")
}
}
func TestRevalidate(t *testing.T) {
// refs == 0 -> one reference.
// refs == -1 -> has been destroyed.
for _, test := range []struct {
// desc is the test's description.
desc string
// Whether to make negative Dirents.
makeNegative bool
}{
{
desc: "Revalidate negative Dirent",
makeNegative: true,
},
{
desc: "Revalidate positive Dirent",
makeNegative: false,
},
} {
t.Run(test.desc, func(t *testing.T) {
ctx := contexttest.Context(t)
root := NewDirent(ctx, NewMockInodeRevalidate(ctx, test.makeNegative), "root")
name := "d"
d1, err := root.walk(ctx, root, name, false)
if !test.makeNegative && err != nil {
t.Fatalf("root.walk(root, %q) got %v, want nil", name, err)
}
d2, err := root.walk(ctx, root, name, false)
if !test.makeNegative && err != nil {
t.Fatalf("root.walk(root, %q) got %v, want nil", name, err)
}
if !test.makeNegative && d1 == d2 {
t.Fatalf("revalidating walk got same *Dirent, want different")
}
if got := len(root.children); got != 1 {
t.Errorf("revalidating walk got %d children, want %d", got, 1)
}
})
}
}
type MockInodeOperationsRevalidate struct {
*MockInodeOperations
makeNegative bool
}
func NewMockInodeRevalidate(ctx context.Context, makeNegative bool) *Inode {
mn := NewMockInodeOperations(ctx)
m := NewMockMountSource(nil)
m.MountSourceOperations.(*MockMountSourceOps).revalidate = true
return NewInode(ctx, &MockInodeOperationsRevalidate{MockInodeOperations: mn, makeNegative: makeNegative}, m, StableAttr{Type: Directory})
}
func (m *MockInodeOperationsRevalidate) Lookup(ctx context.Context, dir *Inode, p string) (*Dirent, error) {
if !m.makeNegative {
return m.MockInodeOperations.Lookup(ctx, dir, p)
}
return NewNegativeDirent(p), nil
}
func TestCreateExtraRefs(t *testing.T) {
// refs == 0 -> one reference.
// refs == -1 -> has been destroyed.
ctx := contexttest.Context(t)
for _, test := range []struct {
// desc is the test's description.
desc string
// root is the Dirent to create from.
root *Dirent
// expected references on walked Dirent.
refs int64
}{
{
desc: "Create caching",
root: NewDirent(ctx, NewEmptyDir(ctx, NewDirentCache(1)), "root"),
refs: 2,
},
{
desc: "Create not caching",
root: NewDirent(ctx, NewEmptyDir(ctx, nil), "root"),
refs: 1,
},
} {
t.Run(test.desc, func(t *testing.T) {
name := "d"
f, err := test.root.Create(ctx, test.root, name, FileFlags{}, FilePermissions{})
if err != nil {
t.Fatalf("root.Create(root, %q) failed: %v", name, err)
}
d := f.Dirent
if got := d.ReadRefs(); got != test.refs {
t.Errorf("dirent has a ref count of %d, want %d", got, test.refs)
}
})
}
}
func TestRemoveExtraRefs(t *testing.T) {
// refs == 0 -> one reference.
// refs == -1 -> has been destroyed.
ctx := contexttest.Context(t)
for _, test := range []struct {
// desc is the test's description.
desc string
// root is the Dirent to make and remove from.
root *Dirent
}{
{
desc: "Remove caching",
root: NewDirent(ctx, NewEmptyDir(ctx, NewDirentCache(1)), "root"),
},
{
desc: "Remove not caching",
root: NewDirent(ctx, NewEmptyDir(ctx, nil), "root"),
},
} {
t.Run(test.desc, func(t *testing.T) {
name := "d"
f, err := test.root.Create(ctx, test.root, name, FileFlags{}, FilePermissions{})
if err != nil {
t.Fatalf("root.Create(%q, _) failed: %v", name, err)
}
d := f.Dirent
if err := test.root.Remove(contexttest.Context(t), test.root, name, false /* dirPath */); err != nil {
t.Fatalf("root.Remove(root, %q) failed: %v", name, err)
}
if got := d.ReadRefs(); got != 1 {
t.Fatalf("dirent has a ref count of %d, want %d", got, 1)
}
d.DecRef(ctx)
test.root.flush(ctx)
if got := len(test.root.children); got != 0 {
t.Errorf("root has %d children, want %d", got, 0)
}
})
}
}
func TestRenameExtraRefs(t *testing.T) {
// refs == 0 -> one reference.
// refs == -1 -> has been destroyed.
for _, test := range []struct {
// desc is the test's description.
desc string
// cache of extra Dirent references, may be nil.
cache *DirentCache
}{
{
desc: "Rename no caching",
cache: nil,
},
{
desc: "Rename caching",
cache: NewDirentCache(5),
},
} {
t.Run(test.desc, func(t *testing.T) {
ctx := contexttest.Context(t)
dirAttr := StableAttr{Type: Directory}
oldParent := NewDirent(ctx, NewMockInode(ctx, NewMockMountSource(test.cache), dirAttr), "old_parent")
newParent := NewDirent(ctx, NewMockInode(ctx, NewMockMountSource(test.cache), dirAttr), "new_parent")
renamed, err := oldParent.Walk(ctx, oldParent, "old_child")
if err != nil {
t.Fatalf("Walk(oldParent, %q) got error %v, want nil", "old_child", err)
}
replaced, err := newParent.Walk(ctx, oldParent, "new_child")
if err != nil {
t.Fatalf("Walk(newParent, %q) got error %v, want nil", "new_child", err)
}
if err := Rename(contexttest.RootContext(t), oldParent /*root */, oldParent, "old_child", newParent, "new_child"); err != nil {
t.Fatalf("Rename got error %v, want nil", err)
}
oldParent.flush(ctx)
newParent.flush(ctx)
// Expect to have only active references.
if got := renamed.ReadRefs(); got != 1 {
t.Errorf("renamed has ref count %d, want only active references %d", got, 1)
}
if got := replaced.ReadRefs(); got != 1 {
t.Errorf("replaced has ref count %d, want only active references %d", got, 1)
}
})
}
}
|