groups: # We define three basic groups: generated (all generated files), # external (all files outside the repository), and internal (all # files within the local repository). We can't enforce many style # checks on generated and external code, so enable those cases # selectively for analyzers below. - name: generated regex: "^(bazel-genfiles|bazel-out|bazel-bin)/" default: true - name: external regex: "^external/" default: false - name: internal regex: ".*" default: true global: generated: suppress: # Suppress the basic style checks for # generated code, but keep the analysis # that are required for quality & security. - "should not use ALL_CAPS in Go names" - "should not use underscores" - "comment on exported" - "methods on the same type should have the same receiver name" - "at least one file in a package" - "package comment should be of the form" # Generated code may have dead code paths. - "identical build constraints" - "no value of type" - "is never used" # go_embed_data rules generate unicode literals. - "string literal contains the Unicode format character" - "string literal contains the Unicode control character" - "string literal contains Unicode control characters" - "string literal contains Unicode format and control characters" # Some external code will generate protov1 # implementations. These should be ignored. - "proto.* is deprecated" - "xxx_messageInfo_.*" - "receiver name should be a reflection of its identity" # Generated gRPC code is not compliant either. - "error strings should not be capitalized" - "grpc.Errorf is deprecated" # Generated proto code does not always follow capitalization conventions. - "(field|method|struct|type) .* should be .*" # Generated proto code sometimes duplicates imports with aliases. - "duplicate import" # TODO(b/179817829): Upgrade to flock to v0.8.0. - "flock.NewFlock is deprecated: Use New instead" internal: suppress: # We use ALL_CAPS for system definitions, # which are common enough in the code base # that we shouldn't annotate exceptions. # # Same story for underscores. - "should not use ALL_CAPS in Go names" - "should not use underscores in Go names" # TODO(b/179817829): Upgrade to flock to v0.8.0. - "flock.NewFlock is deprecated: Use New instead" exclude: # Generated: exempt all. - pkg/shim/runtimeoptions/runtimeoptions_cri.go analyzers: asmdecl: external: # Enabled. assign: external: exclude: - gazelle/walk/walk.go atomic: external: # Enabled. bools: external: # Enabled. buildtag: external: # Enabled. cgocall: external: # Enabled. checklocks: internal: exclude: - "^-$" # b/181776900: analyzer fails on buildkite - pkg/sentry/fs/dirent.go # unsupported usage. - pkg/sentry/fs/fsutil/inode_cached.go # unsupported usage. - pkg/sentry/fs/gofer/inode_state.go # unsupported usage. - pkg/sentry/fs/gofer/session.go # unsupported usage. - pkg/sentry/fs/ramfs/dir.go # unsupported usage. - pkg/sentry/fsimpl/fuse/connection.go # unsupported usage. - pkg/sentry/fsimpl/kernfs/filesystem.go # unsupported usage. - pkg/sentry/fsimpl/kernfs/inode_impl_util.go # unsupported usage. - pkg/sentry/fsimpl/fuse/dev_test.go # unsupported usage. - pkg/sentry/fsimpl/gofer/filesystem.go # unsupported usage. - pkg/sentry/fsimpl/gofer/gofer.go # unsupported usage. - pkg/sentry/fsimpl/gofer/regular_file.go # unsupported usage. - pkg/sentry/fsimpl/gofer/special_file.go # unsupported usage. - pkg/sentry/fsimpl/gofer/symlink.go # unsupported usage. - pkg/sentry/fsimpl/overlay/copy_up.go # unsupported usage. - pkg/sentry/fsimpl/overlay/filesystem.go # unsupported usage. - pkg/sentry/fsimpl/tmpfs/filesystem.go # unsupported usage. - pkg/sentry/fsimpl/verity/filesystem.go # unsupported usage. - pkg/sentry/kernel/futex/futex.go # unsupported usage. - pkg/sentry/kernel/pipe/vfs.go # unsupported usage. - pkg/sentry/mm/syscalls.go # unsupported usage. - pkg/sentry/kernel/fd_table.go # unsupported usage. - pkg/sentry/kernel/ptrace.go # unsupported usage. - pkg/sentry/time/calibrated_clock_test.go # unsupported usage. - pkg/sentry/kernel/task_context.go # unsupported usage. - pkg/sentry/pgalloc/pgalloc.go # unsupported usage. - pkg/sentry/socket/unix/transport/connectioned.go # unsupported usage. - pkg/sentry/vfs/dentry.go # unsupported usage. - pkg/tcpip/network/internal/ip/generic_multicast_protocol_test.go # unsupported usage. - pkg/tcpip/stack/conntrack.go # unsupported usage. - pkg/tcpip/transport/packet/endpoint_state.go # unsupported usage. - pkg/tcpip/transport/raw/endpoint_state.go # unsupported usage. - pkg/tcpip/transport/icmp/endpoint.go # unsupported usage. - pkg/tcpip/transport/icmp/endpoint_state.go # unsupported usage. - pkg/tcpip/transport/tcp/accept.go # unsupported usage. - pkg/tcpip/transport/tcp/connect.go # unsupported usage. - pkg/tcpip/transport/tcp/dispatcher.go # unsupported usage (TryLock) - pkg/tcpip/transport/tcp/endpoint.go # unsupported usage. - pkg/tcpip/transport/tcp/endpoint_state.go # unsupported usage. - pkg/tcpip/transport/udp/endpoint.go # unsupported usage (defer unlock in anonymous function) - pkg/tcpip/transport/udp/endpoint_state.go # unsupported usage (missing nested mutex annotation support) shadow: # Disable for now. generated: exclude: [".*"] internal: exclude: [".*"] composites: # Disable for now. generated: exclude: [".*"] internal: exclude: [".*"] errorsas: external: # Enabled. httpresponse: external: # Enabled. loopclosure: external: # Enabled. nilfunc: external: # Enabled. nilness: internal: exclude: - pkg/sentry/platform/kvm/kvm_test.go # Intentional. - tools/bigquery/bigquery.go # False positive. printf: external: # Enabled. shift: generated: # Disabled for generated code; these shifts are well-defined. exclude: [".*"] external: # Enabled. stringintconv: external: exclude: - ".*protobuf/.*.go" # Bad conversions. - ".*flate/huffman_bit_writer.go" # Bad conversion. # Runtime internal violations. - ".*reflect/value.go" - ".*encoding/xml/xml.go" - ".*runtime/pprof/internal/profile/proto.go" - ".*fmt/scan.go" - ".*go/types/conversions.go" - ".*golang.org/x/net/dns/dnsmessage/message.go" tests: external: # Enabled. unmarshal: external: # Enabled. unreachable: external: # Enabled. unsafeptr: internal: exclude: - ".*_test.go" # Exclude tests. - "pkg/flipcall/.*_unsafe.go" # Special case. - pkg/gohacks/gohacks_unsafe.go # Special case. - pkg/ring0/pagetables/allocator_unsafe.go # Special case. - pkg/sentry/fs/fsutil/host_file_mapper_unsafe.go # Special case. - pkg/sentry/platform/kvm/bluepill_unsafe.go # Special case. - pkg/sentry/platform/kvm/machine_unsafe.go # Special case. - pkg/sentry/platform/safecopy/safecopy_unsafe.go # Special case. - pkg/sentry/vfs/mount_unsafe.go # Special case. - pkg/state/decode_unsafe.go # Special case. unusedresult: external: # Enabled. checkescape: external: # Enabled. SA4016: internal: exclude: - pkg/gohacks/gohacks_unsafe.go # x ^ 0 always equals x. SA2001: internal: exclude: - pkg/sentry/fs/fs.go # Intentional. - pkg/sentry/fs/gofer/inode.go # Intentional. - pkg/refs/refcounter_test.go # Intentional. ST1019: generated: exclude: # package ".../kubeapi/core/v1/v1" is being imported more than once - generated.gen.pb.go ST1021: internal: suppress: - "comment on exported type Translation" # Intentional. - "comment on exported type PinnedRange" # Intentional. SA5011: internal: exclude: # https://github.com/dominikh/go-tools/issues/924 - pkg/sentry/fs/fdpipe/pipe_opener_test.go - pkg/tcpip/tests/integration/link_resolution_test.go