From 955e09dfbdb8a4cdae0a0b625001a567f6f15758 Mon Sep 17 00:00:00 2001
From: Ghanan Gowripalan <ghanan@google.com>
Date: Fri, 6 Nov 2020 01:45:12 -0800
Subject: Do not send to the zero port

Port 0 is not meant to identify any remote port so attempting to send
a packet to it should return an error.

PiperOrigin-RevId: 341009528
---
 test/syscalls/linux/udp_socket.cc | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

(limited to 'test')

diff --git a/test/syscalls/linux/udp_socket.cc b/test/syscalls/linux/udp_socket.cc
index bc5bd9218..d65275fd3 100644
--- a/test/syscalls/linux/udp_socket.cc
+++ b/test/syscalls/linux/udp_socket.cc
@@ -1887,6 +1887,22 @@ TEST_P(UdpSocketTest, GetSocketDetachFilter) {
       SyscallFailsWithErrno(ENOPROTOOPT));
 }
 
+TEST_P(UdpSocketTest, SendToZeroPort) {
+  char buf[8];
+  struct sockaddr_storage addr = InetLoopbackAddr();
+
+  // Sending to an invalid port should fail.
+  SetPort(&addr, 0);
+  EXPECT_THAT(sendto(sock_.get(), buf, sizeof(buf), 0,
+                     reinterpret_cast<struct sockaddr*>(&addr), sizeof(addr)),
+              SyscallFailsWithErrno(EINVAL));
+
+  SetPort(&addr, 1234);
+  EXPECT_THAT(sendto(sock_.get(), buf, sizeof(buf), 0,
+                     reinterpret_cast<struct sockaddr*>(&addr), sizeof(addr)),
+              SyscallSucceedsWithValue(sizeof(buf)));
+}
+
 INSTANTIATE_TEST_SUITE_P(AllInetTests, UdpSocketTest,
                          ::testing::Values(AddressFamily::kIpv4,
                                            AddressFamily::kIpv6,
-- 
cgit v1.2.3