From 282a4dd52b337dccfb578e9d32dd1005c864dd8d Mon Sep 17 00:00:00 2001
From: Ghanan Gowripalan <ghanan@google.com>
Date: Thu, 16 Sep 2021 11:50:51 -0700
Subject: Don't allow binding to broadcast on ICMP sockets

...to match Linux behaviour.

Fixes #5711.

PiperOrigin-RevId: 397132671
---
 test/syscalls/linux/ping_socket.cc | 6 ------
 1 file changed, 6 deletions(-)

(limited to 'test')

diff --git a/test/syscalls/linux/ping_socket.cc b/test/syscalls/linux/ping_socket.cc
index 684983a4c..025c9568f 100644
--- a/test/syscalls/linux/ping_socket.cc
+++ b/test/syscalls/linux/ping_socket.cc
@@ -128,9 +128,6 @@ std::vector<std::tuple<SocketKind, BindTestCase>> ICMPTestCases() {
           {
               .bind_to = V4Broadcast(),
               .want = EADDRNOTAVAIL,
-              // TODO(gvisor.dev/issue/5711): Remove want_gvisor once ICMP
-              // sockets are no longer allowed to bind to broadcast addresses.
-              .want_gvisor = 0,
           },
           {
               .bind_to = V4Loopback(),
@@ -139,9 +136,6 @@ std::vector<std::tuple<SocketKind, BindTestCase>> ICMPTestCases() {
           {
               .bind_to = V4LoopbackSubnetBroadcast(),
               .want = EADDRNOTAVAIL,
-              // TODO(gvisor.dev/issue/5711): Remove want_gvisor once ICMP
-              // sockets are no longer allowed to bind to broadcast addresses.
-              .want_gvisor = 0,
           },
           {
               .bind_to = V4Multicast(),
-- 
cgit v1.2.3