From 27cc5a883a3cc077da884c0d058b69b607ec02f2 Mon Sep 17 00:00:00 2001
From: Kevin Krakauer <krakauer@google.com>
Date: Mon, 28 Jun 2021 10:38:34 -0700
Subject: check explicitly that AF_PACKET sockets can't write in gVisor

PiperOrigin-RevId: 381896875
---
 test/syscalls/linux/packet_socket.cc     | 11 ++++++++---
 test/syscalls/linux/packet_socket_raw.cc | 11 ++++++++---
 2 files changed, 16 insertions(+), 6 deletions(-)

(limited to 'test/syscalls')

diff --git a/test/syscalls/linux/packet_socket.cc b/test/syscalls/linux/packet_socket.cc
index 4f68de176..1e246c421 100644
--- a/test/syscalls/linux/packet_socket.cc
+++ b/test/syscalls/linux/packet_socket.cc
@@ -231,9 +231,6 @@ TEST_P(CookedPacketTest, Receive) {
 
 // Send via a packet socket.
 TEST_P(CookedPacketTest, Send) {
-  // We don't implement writing to packet sockets on gVisor.
-  SKIP_IF(IsRunningOnGvisor());
-
   // Let's send a UDP packet and receive it using a regular UDP socket.
   FileDescriptor udp_sock =
       ASSERT_NO_ERRNO_AND_VALUE(Socket(AF_INET, SOCK_DGRAM, 0));
@@ -287,6 +284,14 @@ TEST_P(CookedPacketTest, Send) {
   memcpy(send_buf + sizeof(iphdr), &udphdr, sizeof(udphdr));
   memcpy(send_buf + sizeof(iphdr) + sizeof(udphdr), kMessage, sizeof(kMessage));
 
+  // We don't implement writing to packet sockets on gVisor.
+  if (IsRunningOnGvisor()) {
+    ASSERT_THAT(sendto(socket_, send_buf, sizeof(send_buf), 0,
+                       reinterpret_cast<struct sockaddr*>(&dest), sizeof(dest)),
+                SyscallFailsWithErrno(EINVAL));
+    GTEST_SKIP();
+  }
+
   // Send it.
   ASSERT_THAT(sendto(socket_, send_buf, sizeof(send_buf), 0,
                      reinterpret_cast<struct sockaddr*>(&dest), sizeof(dest)),
diff --git a/test/syscalls/linux/packet_socket_raw.cc b/test/syscalls/linux/packet_socket_raw.cc
index 9b54dda8b..7e439466e 100644
--- a/test/syscalls/linux/packet_socket_raw.cc
+++ b/test/syscalls/linux/packet_socket_raw.cc
@@ -235,9 +235,6 @@ TEST_P(RawPacketTest, Receive) {
 
 // Send via a packet socket.
 TEST_P(RawPacketTest, Send) {
-  // We don't implement writing to packet sockets on gVisor.
-  SKIP_IF(IsRunningOnGvisor());
-
   // Let's send a UDP packet and receive it using a regular UDP socket.
   FileDescriptor udp_sock =
       ASSERT_NO_ERRNO_AND_VALUE(Socket(AF_INET, SOCK_DGRAM, 0));
@@ -299,6 +296,14 @@ TEST_P(RawPacketTest, Send) {
   memcpy(send_buf + sizeof(ethhdr) + sizeof(iphdr) + sizeof(udphdr), kMessage,
          sizeof(kMessage));
 
+  // We don't implement writing to packet sockets on gVisor.
+  if (IsRunningOnGvisor()) {
+    ASSERT_THAT(sendto(s_, send_buf, sizeof(send_buf), 0,
+                       reinterpret_cast<struct sockaddr*>(&dest), sizeof(dest)),
+                SyscallFailsWithErrno(EINVAL));
+    GTEST_SKIP();
+  }
+
   // Send it.
   ASSERT_THAT(sendto(s_, send_buf, sizeof(send_buf), 0,
                      reinterpret_cast<struct sockaddr*>(&dest), sizeof(dest)),
-- 
cgit v1.2.3