From 3075ede86edf04117f120b3cf110e699034b759c Mon Sep 17 00:00:00 2001 From: Mithun Iyer Date: Sat, 5 Dec 2020 01:45:47 -0800 Subject: Fix zero receive window advertisements. With the recent changes db36d948fa63ce950d94a5e8e9ebc37956543661, we try to balance the receive window advertisements between payload lengths vs segment overhead length. This works fine when segment size are much higher than the overhead, but not otherwise. In cases where the segment length is smaller than the segment overhead, we may end up not advertising zero receive window for long time and end up tail-dropping segments. This is especially pronounced when application socket reads are slow or stopped. In this change we do not grow the right edge of the receive window for smaller segment sizes similar to Linux. Also, we keep track of the socket buffer usage and let the window grow if the application is actively reading data. Fixes #4903 PiperOrigin-RevId: 345832012 --- test/packetimpact/runner/defs.bzl | 3 +++ 1 file changed, 3 insertions(+) (limited to 'test/packetimpact/runner') diff --git a/test/packetimpact/runner/defs.bzl b/test/packetimpact/runner/defs.bzl index 86833eade..c6c95546a 100644 --- a/test/packetimpact/runner/defs.bzl +++ b/test/packetimpact/runner/defs.bzl @@ -223,6 +223,9 @@ ALL_TESTS = [ PacketimpactTestInfo( name = "tcp_user_timeout", ), + PacketimpactTestInfo( + name = "tcp_zero_receive_window", + ), PacketimpactTestInfo( name = "tcp_queue_receive_in_syn_sent", ), -- cgit v1.2.3