From ec20f4f38ef49efc8756595e6ec3fb3e578cc097 Mon Sep 17 00:00:00 2001 From: Zach Koopmans Date: Thu, 18 Feb 2021 12:59:22 -0800 Subject: Make b.N increase by KB not bytes on iperf. Currently, iperf runs a client that scales by bytes sent. In practice, this causes b.N to scale slowly and have several short lived containers. Instead, scale by KB to more quickly reach required time. PiperOrigin-RevId: 358244926 --- test/benchmarks/network/iperf_test.go | 2 +- test/benchmarks/tools/iperf.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'test/benchmarks') diff --git a/test/benchmarks/network/iperf_test.go b/test/benchmarks/network/iperf_test.go index 296f9b1ac..6ac7717b1 100644 --- a/test/benchmarks/network/iperf_test.go +++ b/test/benchmarks/network/iperf_test.go @@ -97,7 +97,7 @@ func BenchmarkIperf(b *testing.B) { } iperf := tools.Iperf{ - Num: b.N, + Num: b.N, // KB for the client to send. } // Run the client. diff --git a/test/benchmarks/tools/iperf.go b/test/benchmarks/tools/iperf.go index abf296731..8f410a9e8 100644 --- a/test/benchmarks/tools/iperf.go +++ b/test/benchmarks/tools/iperf.go @@ -26,7 +26,7 @@ const length = 64 * 1024 // Iperf is for the client side of `iperf`. type Iperf struct { - Num int + Num int // Number of bytes to send in KB. } // MakeCmd returns a iperf client command. @@ -34,8 +34,8 @@ func (i *Iperf) MakeCmd(ip net.IP, port int) []string { return []string{ "iperf", "--format", "K", // Output in KBytes. - "--realtime", // Measured in realtime. - "--num", fmt.Sprintf("%d", i.Num), + "--realtime", // Measured in realtime. + "--num", fmt.Sprintf("%dK", i.Num), // Number of bytes to send in KB. "--length", fmt.Sprintf("%d", length), "--client", ip.String(), "--port", fmt.Sprintf("%d", port), -- cgit v1.2.3