From a376a0baf362506549fcc58861465fa89ed33f7f Mon Sep 17 00:00:00 2001 From: Ghanan Gowripalan Date: Sat, 26 Sep 2020 19:23:01 -0700 Subject: Remove generic ICMP errors Generic ICMP errors were required because the transport dispatcher was given the responsibility of sending ICMP errors in response to transport packet delivery failures. Instead, the transport dispatcher should let network layer know it failed to deliver a packet (and why) and let the network layer make the decision as to what error to send (if any). Fixes #4068 PiperOrigin-RevId: 333962333 --- pkg/tcpip/tcpip.go | 11 ----------- 1 file changed, 11 deletions(-) (limited to 'pkg/tcpip/tcpip.go') diff --git a/pkg/tcpip/tcpip.go b/pkg/tcpip/tcpip.go index fa73cfa47..464608dee 100644 --- a/pkg/tcpip/tcpip.go +++ b/pkg/tcpip/tcpip.go @@ -1987,14 +1987,3 @@ func DeleteDanglingEndpoint(e Endpoint) { // AsyncLoading is the global barrier for asynchronous endpoint loading // activities. var AsyncLoading sync.WaitGroup - -// ICMPReason is a marker interface for network protocol agnostic ICMP errors. -type ICMPReason interface { - isICMP() -} - -// ICMPReasonPortUnreachable is an error where the transport protocol has no -// listener and no alternative means to inform the sender. -type ICMPReasonPortUnreachable struct{} - -func (*ICMPReasonPortUnreachable) isICMP() {} -- cgit v1.2.3