From 8db147b55423d7dbe5f9af4e6154eab2d19025e1 Mon Sep 17 00:00:00 2001 From: Sam Balana Date: Fri, 23 Oct 2020 12:31:11 -0700 Subject: Wait before transitioning NUD entries from Probe to Failed Wait an additional RetransmitTimer duration after the last probe before transitioning to Failed. The previous implementation transitions immediately to Failed after sending the last probe, which is erroneous behavior. PiperOrigin-RevId: 338723794 --- pkg/tcpip/stack/neighbor_entry.go | 6 ------ 1 file changed, 6 deletions(-) (limited to 'pkg/tcpip/stack/neighbor_entry.go') diff --git a/pkg/tcpip/stack/neighbor_entry.go b/pkg/tcpip/stack/neighbor_entry.go index 0f16feaa5..1f0365460 100644 --- a/pkg/tcpip/stack/neighbor_entry.go +++ b/pkg/tcpip/stack/neighbor_entry.go @@ -238,12 +238,6 @@ func (e *neighborEntry) setStateLocked(next NeighborState) { } retryCounter++ - if retryCounter == config.MaxUnicastProbes { - e.dispatchRemoveEventLocked() - e.setStateLocked(Failed) - return - } - e.job = e.nic.stack.newJob(&e.mu, sendUnicastProbe) e.job.Schedule(config.RetransmitTimer) } -- cgit v1.2.3