From 8afbd974da2483d8f81e3abde5c9d689719263cb Mon Sep 17 00:00:00 2001
From: Kevin Krakauer <krakauer@google.com>
Date: Fri, 7 Jun 2019 12:54:53 -0700
Subject: Address Ian's comments.

Change-Id: I7445033b1970cbba3f2ed0682fe520dce02d8fad
---
 pkg/tcpip/iptables/iptables.go | 36 +++++++++++-------------------------
 1 file changed, 11 insertions(+), 25 deletions(-)

(limited to 'pkg/tcpip/iptables/iptables.go')

diff --git a/pkg/tcpip/iptables/iptables.go b/pkg/tcpip/iptables/iptables.go
index ee1ed4666..bd54ef5a6 100644
--- a/pkg/tcpip/iptables/iptables.go
+++ b/pkg/tcpip/iptables/iptables.go
@@ -34,9 +34,9 @@ const (
 // all packets.
 func DefaultTables() *IPTables {
 	tables := IPTables{
-		Tables: map[string]*Table{
-			tablenameNat: &Table{
-				BuiltinChains: map[Hook]*Chain{
+		Tables: map[string]Table{
+			tablenameNat: Table{
+				BuiltinChains: map[Hook]Chain{
 					Prerouting:  unconditionalAcceptChain(chainNamePrerouting),
 					Input:       unconditionalAcceptChain(chainNameInput),
 					Output:      unconditionalAcceptChain(chainNameOutput),
@@ -48,10 +48,10 @@ func DefaultTables() *IPTables {
 					Output:      UnconditionalAcceptTarget{},
 					Postrouting: UnconditionalAcceptTarget{},
 				},
-				UserChains: map[string]*Chain{},
+				UserChains: map[string]Chain{},
 			},
-			tablenameMangle: &Table{
-				BuiltinChains: map[Hook]*Chain{
+			tablenameMangle: Table{
+				BuiltinChains: map[Hook]Chain{
 					Prerouting: unconditionalAcceptChain(chainNamePrerouting),
 					Output:     unconditionalAcceptChain(chainNameOutput),
 				},
@@ -59,7 +59,7 @@ func DefaultTables() *IPTables {
 					Prerouting: UnconditionalAcceptTarget{},
 					Output:     UnconditionalAcceptTarget{},
 				},
-				UserChains: map[string]*Chain{},
+				UserChains: map[string]Chain{},
 			},
 		},
 		Priorities: map[Hook][]string{
@@ -68,28 +68,14 @@ func DefaultTables() *IPTables {
 		},
 	}
 
-	// Initialize each table's Chains field.
-	tables.Tables[tablenameNat].Chains = map[string]*Chain{
-		chainNamePrerouting:  tables.Tables[tablenameNat].BuiltinChains[Prerouting],
-		chainNameInput:       tables.Tables[tablenameNat].BuiltinChains[Input],
-		chainNameOutput:      tables.Tables[tablenameNat].BuiltinChains[Output],
-		chainNamePostrouting: tables.Tables[tablenameNat].BuiltinChains[Postrouting],
-	}
-	tables.Tables[tablenameMangle].Chains = map[string]*Chain{
-		chainNamePrerouting:  tables.Tables[tablenameMangle].BuiltinChains[Prerouting],
-		chainNameInput:       tables.Tables[tablenameMangle].BuiltinChains[Input],
-		chainNameOutput:      tables.Tables[tablenameMangle].BuiltinChains[Output],
-		chainNamePostrouting: tables.Tables[tablenameMangle].BuiltinChains[Postrouting],
-	}
-
 	return &tables
 }
 
-func unconditionalAcceptChain(name string) *Chain {
-	return &Chain{
+func unconditionalAcceptChain(name string) Chain {
+	return Chain{
 		Name: name,
-		Rules: []*Rule{
-			&Rule{
+		Rules: []Rule{
+			Rule{
 				Target: UnconditionalAcceptTarget{},
 			},
 		},
-- 
cgit v1.2.3