From 99f9230e3fbd3b3ede5628eeeb8458175bc9c1a0 Mon Sep 17 00:00:00 2001 From: Noah Fontes Date: Tue, 22 Jun 2021 14:17:26 -0700 Subject: Ensure shim propagates errors over gRPC correctly This change wraps containerd's errdefs.ToGRPC function with one that understands Go 1.13-style error wrapping style, which is used pervasively throughout the shim. With this change, errors that have been marked with, e.g., `errdefs.ErrNotFound`, will be correctly propagated back to the containerd server. --- pkg/shim/BUILD | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) (limited to 'pkg/shim/BUILD') diff --git a/pkg/shim/BUILD b/pkg/shim/BUILD index 367765209..d8086688c 100644 --- a/pkg/shim/BUILD +++ b/pkg/shim/BUILD @@ -8,6 +8,7 @@ go_library( "api.go", "debug.go", "epoll.go", + "errors.go", "options.go", "service.go", "service_linux.go", @@ -44,6 +45,8 @@ go_library( "@com_github_gogo_protobuf//types:go_default_library", "@com_github_opencontainers_runtime_spec//specs-go:go_default_library", "@com_github_sirupsen_logrus//:go_default_library", + "@org_golang_google_grpc//codes:go_default_library", + "@org_golang_google_grpc//status:go_default_library", "@org_golang_x_sys//unix:go_default_library", ], ) @@ -51,7 +54,10 @@ go_library( go_test( name = "shim_test", size = "small", - srcs = ["service_test.go"], + srcs = [ + "errors_test.go", + "service_test.go", + ], library = ":shim", deps = [ "//pkg/shim/utils", -- cgit v1.2.3