From 1776ab28f0fb934d399361e6012945c70dcd996f Mon Sep 17 00:00:00 2001
From: Nicolas Lacasse <nlacasse@google.com>
Date: Tue, 2 Apr 2019 17:27:30 -0700
Subject: Add test that symlinking over a directory returns EEXIST.
Also remove comments in InodeOperations that required that implementation of
some Create* operations ensure that the name does not already exist, since
these checks are all centralized in the Dirent.
PiperOrigin-RevId: 241637335
Change-Id: Id098dc6063ff7c38347af29d1369075ad1e89a58
---
pkg/sentry/fs/ramfs/dir.go | 4 ----
1 file changed, 4 deletions(-)
(limited to 'pkg/sentry/fs/ramfs')
diff --git a/pkg/sentry/fs/ramfs/dir.go b/pkg/sentry/fs/ramfs/dir.go
index b60dab243..05d716afb 100644
--- a/pkg/sentry/fs/ramfs/dir.go
+++ b/pkg/sentry/fs/ramfs/dir.go
@@ -268,10 +268,6 @@ func (d *Dir) createInodeOperationsCommon(ctx context.Context, name string, make
d.mu.Lock()
defer d.mu.Unlock()
- if _, ok := d.children[name]; ok {
- return nil, syscall.EEXIST
- }
-
inode, err := makeInodeOperations()
if err != nil {
return nil, err
--
cgit v1.2.3