From b941e357615a7b0e04dbf6535cafacfbb4b7e276 Mon Sep 17 00:00:00 2001 From: Jamie Liu Date: Fri, 4 Oct 2019 14:55:11 -0700 Subject: Return EIO from p9 if flipcall.Endpoint.Connect() fails. Also ensure that all flipcall transport errors not returned by p9 (converted to EIO by the client, or dropped on the floor by channel server goroutines) are logged. PiperOrigin-RevId: 272963663 --- pkg/p9/server.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'pkg/p9/server.go') diff --git a/pkg/p9/server.go b/pkg/p9/server.go index 69c886a5d..e717e6161 100644 --- a/pkg/p9/server.go +++ b/pkg/p9/server.go @@ -452,7 +452,9 @@ func (cs *connState) initializeChannels() (err error) { cs.channelWg.Add(1) go func() { // S/R-SAFE: Server side. defer cs.channelWg.Done() - res.service(cs) + if err := res.service(cs); err != nil { + log.Warningf("p9.channel.service: %v", err) + } }() } -- cgit v1.2.3