From ec542dbedf2f454b8c3e126a19b6910cd9425e92 Mon Sep 17 00:00:00 2001 From: Fabricio Voznika Date: Thu, 20 May 2021 17:11:15 -0700 Subject: Suppress log message when there is no error PiperOrigin-RevId: 374981100 --- runsc/sandbox/sandbox.go | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/runsc/sandbox/sandbox.go b/runsc/sandbox/sandbox.go index 8d31e33b2..29e202b7d 100644 --- a/runsc/sandbox/sandbox.go +++ b/runsc/sandbox/sandbox.go @@ -131,8 +131,9 @@ func New(conf *config.Config, args *Args) (*Sandbox, error) { // The Cleanup object cleans up partially created sandboxes when an error // occurs. Any errors occurring during cleanup itself are ignored. c := cleanup.Make(func() { - err := s.destroy() - log.Warningf("error destroying sandbox: %v", err) + if err := s.destroy(); err != nil { + log.Warningf("error destroying sandbox: %v", err) + } }) defer c.Clean() -- cgit v1.2.3