| Age | Commit message (Collapse) | Author | |
|---|---|---|---|
| 2020-10-23 | Merge release-20201019.0-34-g9ca66ec59 (automated) | gVisor bot | |
| 2020-10-23 | Rewrite reference leak checker without finalizers. | Dean Deng | |
| Our current reference leak checker uses finalizers to verify whether an object has reached zero references before it is garbage collected. There are multiple problems with this mechanism, so a rewrite is in order. With finalizers, there is no way to guarantee that a finalizer will run before the program exits. When an unreachable object with a finalizer is garbage collected, its finalizer will be added to a queue and run asynchronously. The best we can do is run garbage collection upon sandbox exit to make sure that all finalizers are enqueued. Furthermore, if there is a chain of finalized objects, e.g. A points to B points to C, garbage collection needs to run multiple times before all of the finalizers are enqueued. The first GC run will register the finalizer for A but not free it. It takes another GC run to free A, at which point B's finalizer can be registered. As a result, we need to run GC as many times as the length of the longest such chain to have a somewhat reliable leak checker. Finally, a cyclical chain of structs pointing to one another will never be garbage collected if a finalizer is set. This is a well-known issue with Go finalizers (https://github.com/golang/go/issues/7358). Using leak checking on filesystem objects that produce cycles will not work and even result in memory leaks. The new leak checker stores reference counted objects in a global map when leak check is enabled and removes them once they are destroyed. At sandbox exit, any remaining objects in the map are considered as leaked. This provides a deterministic way of detecting leaks without relying on the complexities of finalizers and garbage collection. This approach has several benefits over the former, including: - Always detects leaks of objects that should be destroyed very close to sandbox exit. The old checker very rarely detected these leaks, because it relied on garbage collection to be run in a short window of time. - Panics if we forgot to enable leak check on a ref-counted object (we will try to remove it from the map when it is destroyed, but it will never have been added). - Can store extra logging information in the map values without adding to the size of the ref count struct itself. With the size of just an int64, the ref count object remains compact, meaning frequent operations like IncRef/DecRef are more cache-efficient. - Can aggregate leak results in a single report after the sandbox exits. Instead of having warnings littered in the log, which were non-deterministically triggered by garbage collection, we can print all warning messages at once. Note that this could also be a limitation--the sandbox must exit properly for leaks to be detected. Some basic benchmarking indicates that this change does not significantly affect performance when leak checking is enabled, which is understandable since registering/unregistering is only done once for each filesystem object. Updates #1486. PiperOrigin-RevId: 338685972 | |||
| 2020-10-09 | Merge release-20200928.0-78-g743327817 (automated) | gVisor bot | |
| 2020-10-08 | Merge release-20200928.0-72-g6bad4851d (automated) | gVisor bot | |
| 2020-10-08 | Implement MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ. | Jamie Liu | |
| cf. 2a36ab717e8f "rseq/membarrier: Add MEMBARRIER_CMD_PRIVATE_EXPEDITED_RSEQ" PiperOrigin-RevId: 336186795 | |||
| 2020-10-08 | Merge release-20200928.0-66-ga55bd73d4 (automated) | gVisor bot | |
| 2020-10-07 | Add staticcheck and staticstyle analyzers. | Adin Scannell | |
| This change also adds support to go_stateify for detecting an appropriate receiver name, avoiding a large number of false positives. PiperOrigin-RevId: 335994587 | |||
| 2020-10-06 | Merge release-20200928.0-55-g1336af78d (automated) | gVisor bot | |
| 2020-10-06 | Implement membarrier(2) commands other than *_SYNC_CORE. | Jamie Liu | |
| Updates #267 PiperOrigin-RevId: 335713923 | |||
| 2020-09-23 | Merge release-20200914.0-137-g99decaadd (automated) | gVisor bot | |
| 2020-09-23 | Merge release-20200914.0-136-gb54dbdfdc (automated) | gVisor bot | |
| 2020-09-23 | Merge release-20200914.0-135-gc0f21bb19 (automated) | gVisor bot | |
| 2020-09-22 | Merge release-20200914.0-134-gcf3cef117 (automated) | gVisor bot | |
| 2020-09-22 | Merge release-20200914.0-133-g20dc83c9e (automated) | gVisor bot | |
| 2020-09-22 | Merge release-20200914.0-132-g778c36717 (automated) | gVisor bot | |
| 2020-09-22 | Merge release-20200914.0-130-g13a9a622e (automated) | gVisor bot | |
| 2020-09-22 | Merge release-20200914.0-129-gf134f873f (automated) | gVisor bot | |
| 2020-09-21 | Merge release-20200914.0-127-g059d90b9f (automated) | gVisor bot | |
| 2020-09-21 | Merge release-20200914.0-125-g06dbd5b7b (automated) | gVisor bot | |
| 2020-09-21 | Merge release-20200914.0-124-g10dcefbc7 (automated) | gVisor bot | |
| 2020-09-21 | Merge release-20200914.0-123-ga129204cf (automated) | gVisor bot | |
| 2020-09-21 | Merge release-20200914.0-122-gd72022373 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-153-g4ba86e625 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-151-g6c9989cb8 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-150-gc23e39f41 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-149-gb8ba0893e (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-148-gca4ecf481 (automated) | gVisor bot | |
| 2020-09-18 | Use a tmpfs file for shared anonymous and /dev/zero mmap on VFS2. | Jamie Liu | |
| This is more consistent with Linux (see comment on MM.NewSharedAnonMappable()). We don't do the same thing on VFS1 for reasons documented by the updated comment. PiperOrigin-RevId: 332514849 | |||
| 2020-09-18 | Merge release-20200907.0-147-gf911b43f0 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-146-gddf37cb19 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-144-gdedef4392 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-142-gfcf8d7c6d (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-140-gef7d9a6fc (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-139-g313e1988c (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-138-g360006d89 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-137-g07d832dbb (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-136-g2fbd31e72 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-134-gd34bda027 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-133-gc0b74be54 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-132-g23fcbd872 (automated) | gVisor bot | |
| 2020-09-18 | Merge release-20200907.0-131-g1e8beb5f1 (automated) | gVisor bot | |
| 2020-09-17 | Merge release-20200907.0-130-gf1f844daa (automated) | gVisor bot | |
| 2020-09-17 | Merge release-20200907.0-129-g319d1b8ba (automated) | gVisor bot | |
| 2020-09-17 | Merge release-20200907.0-126-ga4db85fff (automated) | gVisor bot | |
| 2020-09-17 | Merge release-20200907.0-125-gd796b100e (automated) | gVisor bot | |
| 2020-09-17 | Merge release-20200907.0-123-gf0b1bd434 (automated) | gVisor bot | |
| 2020-09-17 | Merge release-20200907.0-124-gda07e38f7 (automated) | gVisor bot | |
| 2020-09-16 | Merge release-20200907.0-67-gb6d165fe9 (automated) | gVisor bot | |
| 2020-09-16 | Merge release-20200907.0-66-g29ce0ad16 (automated) | gVisor bot | |
| 2020-09-16 | Merge release-20200907.0-65-g3749e70a6 (automated) | gVisor bot | |
 |
index : gvisor | |
| Container Runtime Sandbox |
| summaryrefslogtreecommitdiffhomepage |