summaryrefslogtreecommitdiffhomepage
path: root/pkg/sentry/fsimpl
AgeCommit message (Collapse)Author
2020-08-20Merge release-20200810.0-74-g129018ab3 (automated)gVisor bot
2020-08-20Consistent precondition formattingMichael Pratt
Our "Preconditions:" blocks are very useful to determine the input invariants, but they are bit inconsistent throughout the codebase, which makes them harder to read (particularly cases with 5+ conditions in a single paragraph). I've reformatted all of the cases to fit in simple rules: 1. Cases with a single condition are placed on a single line. 2. Cases with multiple conditions are placed in a bulleted list. This format has been added to the style guide. I've also mentioned "Postconditions:", though those are much less frequently used, and all uses already match this style. PiperOrigin-RevId: 327687465
2020-08-20Merge release-20200810.0-72-g7ca62b9da (automated)gVisor bot
2020-08-20Merge release-20200810.0-71-g710adf23c (automated)gVisor bot
2020-08-20Merge release-20200810.0-70-gd2e32395c (automated)gVisor bot
2020-08-20Merge release-20200810.0-69-gbe76c7ce6 (automated)gVisor bot
2020-08-20Merge release-20200810.0-68-g633570462 (automated)gVisor bot
2020-08-19Remove path walk from localFile.MknodFabricio Voznika
Replace mknod call with mknodat equivalent to protect against symlink attacks. Also added Mknod tests. Remove goferfs reliance on gofer to check for file existence before creating a synthetic entry. Updates #2923 PiperOrigin-RevId: 327544516
2020-08-19Merge release-20200810.0-66-gf8a948300 (automated)gVisor bot
2020-08-19Merge release-20200810.0-65-g182f66ee5 (automated)gVisor bot
2020-08-19Merge release-20200810.0-62-g41777e90e (automated)gVisor bot
2020-08-19Merge release-20200810.0-61-g333172229 (automated)gVisor bot
2020-08-19Merge release-20200810.0-60-g33c60b893 (automated)gVisor bot
2020-08-19Merge release-20200810.0-59-g35dc7fe7e (automated)gVisor bot
2020-08-18[vfs] Allow offsets for special files other than regular files.Ayush Ranjan
Some character and block devices can be seekable. So allow their FD to maintain file offset. PiperOrigin-RevId: 327370684
2020-08-19Merge release-20200810.0-58-ge5f05d9bf (automated)gVisor bot
2020-08-18Get rid of kernfs.Inode.Destroy.Dean Deng
This interface method is unneeded. PiperOrigin-RevId: 327370325
2020-08-19Merge release-20200810.0-57-gf2822da54 (automated)gVisor bot
2020-08-18Move ERESTART* error definitions to syserror package.Dean Deng
This is needed to avoid circular dependencies between the vfs and kernel packages. PiperOrigin-RevId: 327355524
2020-08-19Merge release-20200810.0-56-g9da77d00f (automated)gVisor bot
2020-08-18Don't set atime if mount is readonlyFabricio Voznika
Updates #1035 PiperOrigin-RevId: 327351475
2020-08-18Merge release-20200810.0-53-g4184a7d5f (automated)gVisor bot
2020-08-18Merge release-20200810.0-52-g6405525b0 (automated)gVisor bot
2020-08-18Avoid holding locks when opening files in VFS2.Jamie Liu
Fixes #3243, #3521 PiperOrigin-RevId: 327308890
2020-08-18Merge release-20200810.0-49-gb3141b680 (automated)gVisor bot
2020-08-18Merge release-20200810.0-48-gb9d87ae7a (automated)gVisor bot
2020-08-18[vfs2] Implement /proc/sys/net/ipv4/tcp_rmem and /proc/sys/net/ipv4/tcp_wmem.Ayush Ranjan
Updates #1035 PiperOrigin-RevId: 327253907
2020-08-18Merge release-20200810.0-47-g673b6cc7f (automated)gVisor bot
2020-08-18Merge release-20200810.0-46-gda5c2ea6d (automated)gVisor bot
2020-08-17Add a skeleton for verity file systemgVisor bot
PiperOrigin-RevId: 327123477
2020-08-17Merge release-20200810.0-44-gd42d01b97 (automated)gVisor bot
2020-08-17Merge release-20200810.0-43-g1b938ba72 (automated)gVisor bot
2020-08-17Merge release-20200810.0-42-g988ab2705 (automated)gVisor bot
2020-08-17Merge release-20200810.0-41-ge3e1b3689 (automated)gVisor bot
2020-08-17[vfs] Do O_DIRECTORY check after resolving symlinks.Ayush Ranjan
Fixes python runtime test test_glob. Updates #3515 We were checking is the to-be-opened dentry is a dir or not before resolving symlinks. We should check that after resolving symlinks. This was preventing us from opening a symlink which pointed to a directory with O_DIRECTORY. Also added this check in tmpfs and removed a duplicate check. PiperOrigin-RevId: 327085895
2020-08-17Merge release-20200810.0-40-ge3c4bbd10 (automated)gVisor bot
2020-08-17Merge release-20200810.0-39-g3bd066d50 (automated)gVisor bot
2020-08-15Merge release-20200810.0-36-g9a7b5830a (automated)gVisor bot
2020-08-15Merge release-20200810.0-35-g1736b2208 (automated)gVisor bot
2020-08-14Merge release-20200810.0-28-gd6520e1d0 (automated)gVisor bot
2020-08-13[vfs2][gofer] Fix file creation flags sent to gofer.Ayush Ranjan
Fixes php runtime test ext/standard/tests/file/readfile_basic.phpt Fixes #3516 fsgofers only want the access mode in the OpenFlags passed to Create(). If more flags are supplied (like O_APPEND in this case), read/write from that fd will fail with EBADF. See runsc/fsgofer/fsgofer.go:WriteAt() VFS2 was providing more than just access modes. So filtering the flags using p9.OpenFlagsModeMask == linux.O_ACCMODE fixes the issue. Gofer in VFS1 also only extracts the access mode flags while making the create RPC. See pkg/sentry/fs/gofer/path.go:Create() Even in VFS2, when we open a handle, we extract out only the access mode flags + O_TRUNC. See third_party/gvisor/pkg/sentry/fsimpl/gofer/handle.go:openHandle() Added a test for this. PiperOrigin-RevId: 326574829
2020-08-14Merge release-20200810.0-27-gd3bb50ebf (automated)gVisor bot
2020-08-14Merge release-20200810.0-26-g20be1c0e6 (automated)gVisor bot
2020-08-14Merge release-20200810.0-24-g5036f135e (automated)gVisor bot
2020-08-13Merge release-20200810.0-23-g47515f475 (automated)gVisor bot
2020-08-13Merge release-20200810.0-21-g36134667b (automated)gVisor bot
2020-08-12Add reference leak checking to vfs2 tmpfs.inode.Dean Deng
Updates #1486. PiperOrigin-RevId: 326354750
2020-08-13Merge release-20200810.0-20-g42b610d56 (automated)gVisor bot
2020-08-12[vfs2][gofer] Return appropriate errors when opening and creating files.Ayush Ranjan
Fixes php test ext/standard/tests/file/touch_variation5.phpt on vfs2. Updates #3516 Also spotted a bug with O_EXCL, where we did not return EEXIST when we tried to open the root of the filesystem with O_EXCL | O_CREAT. Added some more tests for open() corner cases. PiperOrigin-RevId: 326346863
2020-08-12Merge release-20200810.0-16-ge6df6222a (automated)gVisor bot