summaryrefslogtreecommitdiffhomepage
path: root/CONTRIBUTING.md
AgeCommit message (Collapse)Author
2021-08-20Merge pull request #6484 from dqminh:fix-go-mod-instructionsgVisor bot
PiperOrigin-RevId: 392036519
2021-08-20Fix instructions refer to `tools/go_mod.sh`Daniel Dao
`tools/go_mod.sh` is not in the repo. In order to update the WORKSPACE dependencies, we can use the same gazelle command in BUILD file. Also changed `go mod get` to `go get`, the former does not exist anymore. Signed-off-by: Daniel Dao <dqminh89@gmail.com>
2021-08-13Fix minor typoMichael Pratt
PiperOrigin-RevId: 390659097
2021-08-13Update `core` allowed dependenciesMichael Pratt
This list has gotten a little out-of-date. Note that `clockwork` used to be used but was removed in gvisor.dev/pr/5384. PiperOrigin-RevId: 390644841
2020-10-19Remove legacy bazel configurations.Adin Scannell
Using the newer bazel rules necessitates a transition from proto1 to proto2. In order to resolve the incompatibility between proto2 and gogoproto, the cri runtimeoptions proto must be vendored. Further, some of the semantics of bazel caching changed during the transition. It is now necessary to: - Ensure that :gopath depends only on pure library targets, as the propagation of go_binary build attributes (pure, static) will affected the generated files (though content remains the same, there are conflicts with respect to the gopath). - Update bazel.mk to include the possibility of binaries in the bazel-out directory, as it will now put runsc and others there. This required some refinements to the mechanism of extracting paths, since some the existing regex resulted in false positives. - Change nogo rules to prevent escape generation on binary targets. For some reason, the newer version of bazel attempted to run the nogo analysis on the binary targets, which fails due to the fact that objdump does not work on the final binary. This must be due to a change in the semantics of aspects in bazel3. PiperOrigin-RevId: 337958324
2020-06-26Add style guide.Ian Gudger
PiperOrigin-RevId: 318591900
2020-05-06Adapt website to use g3doc sources and bazel.Adin Scannell
This adapts the merged website repository to use the image and bazel build framework. It explicitly avoids the container_image rules provided by bazel, opting instead to build with direct docker commands when necessary. The relevant build commands are incorporated into the top-level Makefile.
2020-04-24Standardize all Docker images.Adin Scannell
This change moves all Docker images to a standard location, and abstracts the build process so that they can be maintained in an automated fashion. This also allows the images to be architecture-independent. All images will now be referred to by the test framework via the canonical `gvisor.dev/images/<name>`, where `<name>` is a function of the path within the source tree. In a subsequent change, continuous integration will be added so that the images will always be correct and available locally. In the end, using `bazel` for Docker containers is simply not possible. Given that we already have the need to use `make` with the base container (for Docker), we extend this approach to get more flexibility. This change also adds a self-documenting and powerful Makefile that is intended to replace the collection of scripts in scripts. Canonical (self-documenting) targets can be added here for targets that understand which images need to be loaded and/or built. PiperOrigin-RevId: 308322438
2020-02-28Add ability to execute go.mod in gopath context.Adin Scannell
2020-02-10Clean-up comments in runsc/BUILD and CONTRIBUTING.md.Adin Scannell
PiperOrigin-RevId: 294300437
2020-01-27Fix header ordering and format all C++ code.Adin Scannell
PiperOrigin-RevId: 291844200
2019-09-16Bring back to life features lost in recent refactorFabricio Voznika
- Sandbox logs are generated when running tests - Kokoro uploads the sandbox logs - Supports multiple parallel runs - Revive script to install locally built runsc with docker PiperOrigin-RevId: 269337274
2019-07-12Merge pull request #350 from kshithijiyer:patch-1gVisor bot
PiperOrigin-RevId: 257887940
2019-07-12CONTRIBUTING: add logs access instructions.Adin Scannell
PiperOrigin-RevId: 257870018
2019-06-11Removing trailing whitespaces and adding a blank line after titleKshithij Iyer
2019-06-11Adding missing title in contributing.mdKshithij Iyer
2019-05-30Update CONTRIBUTING.mdAdin Scannell
PiperOrigin-RevId: 250730726
2019-04-30CONTRIBUTING: fix broken repository linkAdin Scannell
PiperOrigin-RevId: 246079174 Change-Id: I423078a065e0cc5d258d674b4f2f0680a5db0aee
2019-04-29Allow and document bug ids in gVisor codebase.Nicolas Lacasse
PiperOrigin-RevId: 245818639 Change-Id: I03703ef0fb9b6675955637b9fe2776204c545789
2019-04-11CONTRIBUTING: add style guide pointerAdin Scannell
Change-Id: I93a78a6b2bb2eaa69046c6cfecee2e4cfcf20e44 PiperOrigin-RevId: 243140359
2019-04-04BUILD: Add useful go_path targetAdin Scannell
Change-Id: Ibd6d8a1a63826af6e62a0f0669f8f0866c8091b4 PiperOrigin-RevId: 242037969
2019-02-04Note //third_party in coding guidelinesMichael Pratt
PiperOrigin-RevId: 232375745 Change-Id: I26146ad65fac1dcdc5fcb4b11a1580133f9ca46d
2018-09-28Clarify CLA requirements and Gerrit errorMichael Pratt
Call out the error that Gerrit returns if there is no CLA on file. PiperOrigin-RevId: 214964718 Change-Id: I3d92e3eb73f178e8c4c52b5defbe8d21db536215
2018-07-12Format documentationMichael Pratt
PiperOrigin-RevId: 204323728 Change-Id: I1ff9aa062ffa12583b2e38ec94c87db7a3711971
2018-06-15Update contributing guidelines with an example.Adin Scannell
Fixes #69 PiperOrigin-RevId: 200683809 Change-Id: I1312ebb3775d5f9088e9108359c19e2dedbb7b70
2018-05-03CONTRIBUTING.md: fix golang.org/x/sys/unix package nameTobias Klauser
This should be org_golang_x_sys instead of com_golang_x_sys PiperOrigin-RevId: 195305212 Change-Id: I970a7edbcc871ccd4fcec184b1702fbd15b68e20
2018-05-02Fix links in README and CONTRIBUTING.Nicolas Lacasse
PiperOrigin-RevId: 195068006 Change-Id: I2d04a0c600b3850321f845fbdc0b6104dd178b3f
2018-05-01Fix link in CONTRIBUTING.md.Nicolas Lacasse
PiperOrigin-RevId: 194929266 Change-Id: Ib93d5a38c64b01b6851f76a9324b184aefddce9d
2018-04-28Check in gVisor.Googler
PiperOrigin-RevId: 194583126 Change-Id: Ica1d8821a90f74e7e745962d71801c598c652463
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-01 08:31:38 +0000