summaryrefslogtreecommitdiffhomepage
AgeCommit message (Collapse)Author
2020-03-03Merge release-20200219.0-84-g43abb24 (automated)gVisor bot
2020-03-02Fix panic caused by invalid address for Bind in packet sockets.Nayana Bidari
PiperOrigin-RevId: 298476533
2020-03-02Merge release-20200219.0-83-gd80b6a6 (automated)gVisor bot
2020-03-02Merge pull request #2039 from avagin:update-golang.org-x-sysgVisor bot
PiperOrigin-RevId: 298457842
2020-03-02Merge release-20200219.0-81-g3310175 (automated)gVisor bot
2020-03-02Fix data-race when reading/writing e.amss.Bhasker Hariharan
PiperOrigin-RevId: 298451319
2020-03-02Update golang.org/x/sysAndrei Vagin
It was downgraded by mistake in e5d9a4010bdb ("Add ability to execute go.mod in gopath context.") Signed-off-by: Andrei Vagin <avagin@gmail.com>
2020-03-02Merge release-20200219.0-80-g8821a71 (automated)gVisor bot
2020-03-02Do not read-lock NIC recursivelyGhanan Gowripalan
A deadlock may occur if a write lock on a RWMutex is blocked between nested read lock attempts as the inner read lock attempt will be blocked in this scenario. Example (T1 and T2 are differnt goroutines): T1: obtain read-lock T2: attempt write-lock (blocks) T1: attempt inner/nested read-lock (blocks) Here we can see that T1 and T2 are deadlocked. Tests: Existing tests pass. PiperOrigin-RevId: 298426678
2020-03-02Merge release-20200219.0-79-gf03e19d (automated)gVisor bot
2020-03-02Merge pull request #1885 from avagin:arm64-pcidsgVisor bot
PiperOrigin-RevId: 298405064
2020-03-02Merge release-20200219.0-77-g42fb7d3 (automated)gVisor bot
2020-03-02socket: take readMu to access readViewAndrei Vagin
DATA RACE in netstack.(*SocketOperations).fetchReadView Write at 0x00c001dca138 by goroutine 1001: gvisor.dev/gvisor/pkg/sentry/socket/netstack.(*SocketOperations).fetchReadView() pkg/sentry/socket/netstack/netstack.go:418 +0x85 gvisor.dev/gvisor/pkg/sentry/socket/netstack.(*SocketOperations).coalescingRead() pkg/sentry/socket/netstack/netstack.go:2309 +0x67 gvisor.dev/gvisor/pkg/sentry/socket/netstack.(*SocketOperations).nonBlockingRead() pkg/sentry/socket/netstack/netstack.go:2378 +0x183d Previous read at 0x00c001dca138 by goroutine 1111: gvisor.dev/gvisor/pkg/sentry/socket/netstack.(*SocketOperations).Ioctl() pkg/sentry/socket/netstack/netstack.go:2666 +0x533 gvisor.dev/gvisor/pkg/sentry/syscalls/linux.Ioctl() Reported-by: syzbot+d4c3885fcc346f08deb6@syzkaller.appspotmail.com PiperOrigin-RevId: 298387377
2020-03-02Merge release-20200219.0-76-g62bd3ca (automated)gVisor bot
2020-03-02Take write lock when removing xattrMichael Pratt
PiperOrigin-RevId: 298380654
2020-02-29Merge release-20200219.0-75-g3d9ddeb (automated)gVisor bot
2020-02-28Merge pull request #1929 from avagin:arm64-cpuidgVisor bot
PiperOrigin-RevId: 297982488
2020-02-29Merge release-20200219.0-73-gab7ecdd (automated)gVisor bot
2020-02-28watchdog: print panic error message before other messagesAndrei Vagin
This is needed for syzkaller to proper classify issues. Right now, all watchdog issues are duped to one with the subject "panic: Sentry detected stuck task(s). See stack trace and message above for more details". PiperOrigin-RevId: 297975363
2020-02-28Define CPUIDInstruction for arm64Andrei Vagin
There is no cpuid instruction on arm64, so we need to defined it just to avoid a compile time error. Signed-off-by: Andrei Vagin <avagin@gmail.com>
2020-02-28Merge release-20200219.0-72-gce4d1e4 (automated)gVisor bot
2020-02-28Run `./tools/go_mod.sh tidy`.Nicolas Lacasse
These dependencies do not need to be in our go.mod or go.sum files. PiperOrigin-RevId: 297942163
2020-02-28pcids.go isn't arch-specificAndrei Vagin
Signed-off-by: Andrei Vagin <avagin@gmail.com>
2020-02-28Merge release-20200219.0-71-gccecf29 (automated)gVisor bot
2020-02-28Bump rules_go to 0.22.0 and go toolchain to 1.14.Nicolas Lacasse
PiperOrigin-RevId: 297915917
2020-02-28Merge release-20200219.0-70-gdf8740b (automated)gVisor bot
2020-02-28Mark gettid and getdents as nogotsanZach Koopmans
PiperOrigin-RevId: 297915815
2020-02-28Merge release-20200219.0-69-g463f421 (automated)gVisor bot
2020-02-28Make pipe buffer implementation standard.Adin Scannell
A follow-up change will convert the networking code to use this standard pipe implementation. PiperOrigin-RevId: 297903206
2020-02-28Merge release-20200219.0-68-g6a3a8be (automated)gVisor bot
2020-02-28Merge pull request #1827 from amscanne:fix_go_modgVisor bot
PiperOrigin-RevId: 297895651
2020-02-28Merge release-20200219.0-66-g322dbfe (automated)gVisor bot
2020-02-28Allow to specify a separate log for GO's runtime messagesAndrei Vagin
GO's runtime calls the write system call twice to print "panic:" and "the reason of this panic", so here is a race window when other threads can print something to the log and we will see something like this: panic: log messages from another thread The reason of the panic. This confuses the syzkaller blacklist and dedup detection. It also makes the logs generally difficult to read. e.g., data races often have one side of the race, followed by a large "diagnosis" dump, finally followed by the other side of the race. PiperOrigin-RevId: 297887895
2020-02-28Merge release-20200219.0-65-g6b4d36e (automated)gVisor bot
2020-02-28Hide /dev/net/tun when using hostinet.Ting-Yu Wang
/dev/net/tun does not currently work with hostinet. This has caused some program starts failing because it thinks the feature exists. PiperOrigin-RevId: 297876196
2020-02-28Add ability to execute go.mod in gopath context.Adin Scannell
2020-02-28Merge release-20200219.0-64-g0f8a9e3 (automated)gVisor bot
2020-02-28Change dup2 call to dup3Fabricio Voznika
We changed syscalls to allow dup3 for ARM64. Updates #1198 PiperOrigin-RevId: 297870816
2020-02-27Merge release-20200219.0-63-gc96bb4d (automated)gVisor bot
2020-02-27Fix apt-get reliability issues.Adin Scannell
This is frequently causing the core build scripts to fail. The core ubuntu distribution will perform an auto-update at first start, which may cause the lock file to be held. All apt-get commands may be done in a loop in order to retry to avoid this issue. We may want to consider retrying other pieces, but for now this should avoid the most frequent cause of build flakes. PiperOrigin-RevId: 297704789
2020-02-27Merge release-20200219.0-62-g88f7369 (automated)gVisor bot
2020-02-27Log oom_score_adj value on errorFabricio Voznika
Updates #1873 PiperOrigin-RevId: 297695241
2020-02-27Merge release-20200219.0-61-gaa9f8ab (automated)gVisor bot
2020-02-27Implement automated marshalling for newtypes on arrays.Rahat Mahmood
PiperOrigin-RevId: 297693838
2020-02-27Merge release-20200219.0-60-g2cccf3d (automated)gVisor bot
2020-02-27Merge pull request #1346 from ↵gVisor bot
google:dependabot/bundler/benchmarks/workloads/ruby/puma-3.12.2 PiperOrigin-RevId: 297690302
2020-02-27Merge release-20200219.0-58-gc6bdc6b (automated)gVisor bot
2020-02-27Fix a race in TCP endpoint teardown and teardown the stack in tcp_test.Ian Gudger
Call stack.Close on stacks when we are done with them in tcp_test. This avoids leaking resources and reduces the test's flakiness when race/gotsan is enabled. It also provides test coverage for the race also fixed in this change, which can be reliably triggered with the stack.Close change (and without the other changes) when race/gotsan is enabled. The race was possible when calling Abort (via stack.Close) on an endpoint processing a SYN segment as part of a passive connect. Updates #1564 PiperOrigin-RevId: 297685432
2020-02-27Merge release-20200219.0-57-gd9ee811 (automated)gVisor bot
2020-02-27Merge of a369c88c0c4ece5239855000d28df045111c1be7gVisor bot
PiperOrigin-RevId: 297674924