diff options
| author | Bhasker Hariharan <bhaskerh@google.com> | 2021-03-03 12:18:04 -0800 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2021-03-03 12:24:21 -0800 |
| commit | 3e69f5d088d121f1d3c4bf44ca637a48f13c4819 (patch) | |
| tree | 153fa7d51f509c8a5cf066a7aea90fd334a08899 /tools/nogo | |
| parent | 80bc67c268dba0126cd258075c06d744399e0f02 (diff) | |
Add checklocks analyzer.
This validates that struct fields if annotated with "// checklocks:mu" where
"mu" is a mutex field in the same struct then access to the field is only
done with "mu" locked.
All types that are guarded by a mutex must be annotated with
// +checklocks:<mutex field name>
For more details please refer to README.md.
PiperOrigin-RevId: 360729328
Diffstat (limited to 'tools/nogo')
| -rw-r--r-- | tools/nogo/BUILD | 1 | ||||
| -rw-r--r-- | tools/nogo/analyzers.go | 2 |
2 files changed, 3 insertions, 0 deletions
diff --git a/tools/nogo/BUILD b/tools/nogo/BUILD index 7976c7521..5fc60d8d8 100644 --- a/tools/nogo/BUILD +++ b/tools/nogo/BUILD @@ -35,6 +35,7 @@ go_library( visibility = ["//:sandbox"], deps = [ "//tools/checkescape", + "//tools/checklocks", "//tools/checkunsafe", "@co_honnef_go_tools//staticcheck:go_default_library", "@co_honnef_go_tools//stylecheck:go_default_library", diff --git a/tools/nogo/analyzers.go b/tools/nogo/analyzers.go index b919bc2f8..8b4bff3b6 100644 --- a/tools/nogo/analyzers.go +++ b/tools/nogo/analyzers.go @@ -47,6 +47,7 @@ import ( "honnef.co/go/tools/stylecheck" "gvisor.dev/gvisor/tools/checkescape" + "gvisor.dev/gvisor/tools/checklocks" "gvisor.dev/gvisor/tools/checkunsafe" ) @@ -79,6 +80,7 @@ var AllAnalyzers = []*analysis.Analyzer{ unusedresult.Analyzer, checkescape.Analyzer, checkunsafe.Analyzer, + checklocks.Analyzer, } // EscapeAnalyzers is a list of escape-related analyzers. |