summaryrefslogtreecommitdiffhomepage
path: root/tools/go_stateify
diff options
context:
space:
mode:
authorBhasker Hariharan <bhaskerh@google.com>2020-12-10 20:06:13 -0800
committergVisor bot <gvisor-bot@google.com>2020-12-10 20:08:59 -0800
commitbcb97a3bb7560fab49ac35d8c184a510cb81f801 (patch)
treef3bee115bcbbe5eab86aa195470e369e584b251c /tools/go_stateify
parent28c3260d74930a556febafdfaf9e2cecae1b9d3e (diff)
Disable host reassembly for fragments.
fdbased endpoint was enabling fragment reassembly on the host AF_PACKET socket to ensure that fragments are delivered inorder to the right dispatcher. But this prevents fragments from being delivered to gvisor at all and makes testing of gvisor's fragment reassembly code impossible. The potential impact from this is minimal since IP Fragmentation is not really that prevelant and in cases where we do get fragments we may deliver the fragment out of order to the TCP layer as multiple network dispatchers may process the fragments and deliver a reassembled fragment after the next packet has been delivered to the TCP endpoint. While not desirable I believe the impact from this is minimal due to low prevalence of fragmentation. Also removed PktType and Hatype fields when binding the socket as these are not used when binding. Its just confusing to have them specified. See: https://man7.org/linux/man-pages/man7/packet.7.html "Fields used for binding are sll_family (should be AF_PACKET), sll_protocol, and sll_ifindex." Fixes #5055 PiperOrigin-RevId: 346919439
Diffstat (limited to 'tools/go_stateify')
0 files changed, 0 insertions, 0 deletions