diff options
author | Adin Scannell <ascannell@google.com> | 2020-09-29 13:14:52 -0700 |
---|---|---|
committer | gVisor bot <gvisor-bot@google.com> | 2020-09-29 13:16:54 -0700 |
commit | 994c90e2d2dc3806350f1635839f601e2fac5bb6 (patch) | |
tree | bc44e8d5e17b474c16656c1f7f984baa075f420a /tools/github/reviver/github_test.go | |
parent | 44c7d550747a61baa6a85643de439fa45c2b9633 (diff) |
Add nogo check annotations to GitHub.
When nogo checks are violated, they will automatically posted
as annotations on the specific GitHub commit. This allows us
to ensure analysis & style rules and have them called out.
PiperOrigin-RevId: 334447285
Diffstat (limited to 'tools/github/reviver/github_test.go')
-rw-r--r-- | tools/github/reviver/github_test.go | 55 |
1 files changed, 55 insertions, 0 deletions
diff --git a/tools/github/reviver/github_test.go b/tools/github/reviver/github_test.go new file mode 100644 index 000000000..5df7e3624 --- /dev/null +++ b/tools/github/reviver/github_test.go @@ -0,0 +1,55 @@ +// Copyright 2020 The gVisor Authors. +// +// Licensed under the Apache License, Version 2.0 (the "License"); +// you may not use this file except in compliance with the License. +// You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package reviver + +import ( + "testing" +) + +func TestParseIssueNo(t *testing.T) { + testCases := []struct { + issue string + expectErr bool + expected int + }{ + { + issue: "gvisor.dev/issue/123", + expected: 123, + }, + { + issue: "gvisor.dev/issue/123/", + expected: 123, + }, + { + issue: "not a url", + expected: 0, + }, + { + issue: "gvisor.dev/issue//", + expectErr: true, + }, + } + + for _, tc := range testCases { + t.Run(tc.issue, func(t *testing.T) { + id, err := parseIssueNo(tc.issue) + if err != nil && !tc.expectErr { + t.Errorf("got error: %v", err) + } else if tc.expected != id { + t.Errorf("got: %v, want: %v", id, tc.expected) + } + }) + } +} |