diff options
| author | Adin Scannell <ascannell@google.com> | 2021-01-12 12:36:17 -0800 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2021-01-12 12:38:22 -0800 |
| commit | 4e03e87547853523d4ff941935a6ef1712518c61 (patch) | |
| tree | e930ce0e5f15f7041e7b74daca05acc7afbd2558 /tools/github/nogo | |
| parent | a20da708291e2e5bdece5176dce61c1b4b10b7d9 (diff) | |
Fix simple mistakes identified by goreportcard.
These are primarily simplification and lint mistakes. However, minor
fixes are also included and tests added where appropriate.
PiperOrigin-RevId: 351425971
Diffstat (limited to 'tools/github/nogo')
| -rw-r--r-- | tools/github/nogo/nogo.go | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/github/nogo/nogo.go b/tools/github/nogo/nogo.go index 27ab1b8eb..894a0e7c3 100644 --- a/tools/github/nogo/nogo.go +++ b/tools/github/nogo/nogo.go @@ -84,7 +84,7 @@ func (p *FindingsPoster) Walk(paths []string) error { func (p *FindingsPoster) Post() error { // Just show results? if p.dryRun { - for finding, _ := range p.findings { + for finding := range p.findings { // Pretty print, so that this is useful for debugging. fmt.Printf("%s: (%s+%d) %s\n", finding.Category, finding.Position.Filename, finding.Position.Line, finding.Message) } @@ -114,7 +114,7 @@ func (p *FindingsPoster) Post() error { }, } annotationLevel := "failure" // Always. - for finding, _ := range p.findings { + for finding := range p.findings { title := string(finding.Category) opts.Output.Annotations = append(opts.Output.Annotations, &github.CheckRunAnnotation{ Path: &finding.Position.Filename, |