diff options
| author | Ayush Ranjan <ayushranjan@google.com> | 2021-08-17 23:35:10 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2021-08-17 23:37:29 -0700 |
| commit | 216b740663bd897dad177b57953c59860105020d (patch) | |
| tree | bf1ee782e370ad73a68c44f09d1d251bbcd34795 /tools/checklocks/state.go | |
| parent | b495ae599aeff85511449ef17bd50d656d40bc28 (diff) | |
[op] Deflake SNMP Metric proc_net tests.
Earlier the tests were checking for equality of system-wide metrics before and
after some network related operations. That is inherently racy for native tests
because depending on the testing infrastructure, multiple tests might run
parallely hence trampling over each other's metrics.
Tests should only compare metrics that are increasing in nature. The comparison
should not be a hard comparison, instead a less-than/greater-than relation test.
I have changed the checks and also removed tests for tcpCurrEstab metric which
has "SYNTAX Gauge" and hence can not be tested reliably.
PiperOrigin-RevId: 391460081
Diffstat (limited to 'tools/checklocks/state.go')
0 files changed, 0 insertions, 0 deletions