diff options
| author | Ghanan Gowripalan <ghanan@google.com> | 2021-09-16 11:50:51 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2021-09-16 11:53:49 -0700 |
| commit | 282a4dd52b337dccfb578e9d32dd1005c864dd8d (patch) | |
| tree | 63323d5ce90d63c72ab23f579e75939c76ff9a51 /test | |
| parent | eb07b91e61ca47ecf6b9b3122a5527817cc74211 (diff) | |
Don't allow binding to broadcast on ICMP sockets
...to match Linux behaviour.
Fixes #5711.
PiperOrigin-RevId: 397132671
Diffstat (limited to 'test')
| -rw-r--r-- | test/syscalls/linux/ping_socket.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/test/syscalls/linux/ping_socket.cc b/test/syscalls/linux/ping_socket.cc index 684983a4c..025c9568f 100644 --- a/test/syscalls/linux/ping_socket.cc +++ b/test/syscalls/linux/ping_socket.cc @@ -128,9 +128,6 @@ std::vector<std::tuple<SocketKind, BindTestCase>> ICMPTestCases() { { .bind_to = V4Broadcast(), .want = EADDRNOTAVAIL, - // TODO(gvisor.dev/issue/5711): Remove want_gvisor once ICMP - // sockets are no longer allowed to bind to broadcast addresses. - .want_gvisor = 0, }, { .bind_to = V4Loopback(), @@ -139,9 +136,6 @@ std::vector<std::tuple<SocketKind, BindTestCase>> ICMPTestCases() { { .bind_to = V4LoopbackSubnetBroadcast(), .want = EADDRNOTAVAIL, - // TODO(gvisor.dev/issue/5711): Remove want_gvisor once ICMP - // sockets are no longer allowed to bind to broadcast addresses. - .want_gvisor = 0, }, { .bind_to = V4Multicast(), |