diff options
| author | Michael Pratt <mpratt@google.com> | 2019-09-16 11:56:59 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2019-09-16 11:58:27 -0700 |
| commit | 56cb0042181cc4840d8c3995f0970c0c41d4212b (patch) | |
| tree | 4c755f1fe2d2252a55798ef2c2ec4e908cf88c5c /test/util | |
| parent | 010b0932583711ab3f6a88b1136cf8d87c2a53d2 (diff) | |
Migrate from gflags to absl flags
absl flags are more modern and we can easily depend on them directly.
The repo now successfully builds with --incompatible_load_cc_rules_from_bzl.
PiperOrigin-RevId: 269387081
Diffstat (limited to 'test/util')
| -rw-r--r-- | test/util/BUILD | 3 | ||||
| -rw-r--r-- | test/util/test_util.cc | 4 | ||||
| -rw-r--r-- | test/util/test_util.h | 1 |
3 files changed, 5 insertions, 3 deletions
diff --git a/test/util/BUILD b/test/util/BUILD index 64daa0597..52f8b9e1f 100644 --- a/test/util/BUILD +++ b/test/util/BUILD @@ -228,8 +228,9 @@ cc_library( ":logging", ":posix_error", ":save_util", - "@com_github_gflags_gflags//:gflags", "@com_google_absl//absl/base:core_headers", + "@com_google_absl//absl/flags:flag", + "@com_google_absl//absl/flags:parse", "@com_google_absl//absl/strings", "@com_google_absl//absl/strings:str_format", "@com_google_absl//absl/time", diff --git a/test/util/test_util.cc b/test/util/test_util.cc index e42bba04a..ba0dcf7d0 100644 --- a/test/util/test_util.cc +++ b/test/util/test_util.cc @@ -28,6 +28,8 @@ #include <vector> #include "absl/base/attributes.h" +#include "absl/flags/flag.h" // IWYU pragma: keep +#include "absl/flags/parse.h" // IWYU pragma: keep #include "absl/strings/numbers.h" #include "absl/strings/str_cat.h" #include "absl/strings/str_split.h" @@ -224,7 +226,7 @@ bool Equivalent(uint64_t current, uint64_t target, double tolerance) { void TestInit(int* argc, char*** argv) { ::testing::InitGoogleTest(argc, *argv); - ::gflags::ParseCommandLineFlags(argc, argv, true); + ::absl::ParseCommandLine(*argc, *argv); // Always mask SIGPIPE as it's common and tests aren't expected to handle it. struct sigaction sa = {}; diff --git a/test/util/test_util.h b/test/util/test_util.h index cdbe8bfd1..b9d2dc2ba 100644 --- a/test/util/test_util.h +++ b/test/util/test_util.h @@ -185,7 +185,6 @@ #include <utility> #include <vector> -#include <gflags/gflags.h> #include "gmock/gmock.h" #include "absl/strings/str_cat.h" #include "absl/strings/str_format.h" |