summaryrefslogtreecommitdiffhomepage
path: root/test/syscalls
diff options
context:
space:
mode:
authorFabricio Voznika <fvoznika@google.com>2021-04-22 20:04:17 -0700
committergVisor bot <gvisor-bot@google.com>2021-04-22 20:06:37 -0700
commit9e4aa04ad1f6e63f4aa99f516b19e4ff2592918b (patch)
treeee636bcd7428f8f4e20d84c08c8487d806b69ce3 /test/syscalls
parentd1859fe179bae1614ba91a45497ad63400210863 (diff)
Remove side effect from mount tests
Dropping CAP_SYS_ADMIN and not restoring it causes other tests to be skipped. PiperOrigin-RevId: 370002644
Diffstat (limited to 'test/syscalls')
-rw-r--r--test/syscalls/linux/mount.cc4
1 files changed, 1 insertions, 3 deletions
diff --git a/test/syscalls/linux/mount.cc b/test/syscalls/linux/mount.cc
index cdc223d07..92d0fb05c 100644
--- a/test/syscalls/linux/mount.cc
+++ b/test/syscalls/linux/mount.cc
@@ -67,9 +67,7 @@ TEST(MountTest, MountInvalidTarget) {
TEST(MountTest, MountPermDenied) {
// Clear CAP_SYS_ADMIN.
- if (ASSERT_NO_ERRNO_AND_VALUE(HaveCapability(CAP_SYS_ADMIN))) {
- EXPECT_NO_ERRNO(SetCapability(CAP_SYS_ADMIN, false));
- }
+ AutoCapability cap(CAP_SYS_ADMIN, false);
// Linux expects a valid target before checking capability.
auto const dir = ASSERT_NO_ERRNO_AND_VALUE(TempPath::CreateDir());