diff options
| author | Michael Pratt <mpratt@google.com> | 2019-03-05 13:53:36 -0800 |
|---|---|---|
| committer | Shentubot <shentubot@google.com> | 2019-03-05 13:54:38 -0800 |
| commit | bd46185e24e03b93ac551a5ddfffb06975f157c8 (patch) | |
| tree | 7a9ad36b72a017e4e960408a0e9e1743aaf32d8e /test/syscalls/linux/open.cc | |
| parent | dcb634ce73f51a1c32e1632d5b5011b3cf56a862 (diff) | |
Add NoRandomSave to tests with correctness DisableSave
Tests using DisableSave because a portion of the test is *incompatible*
with S/R clearly cannot use random S/R, as the saves may occur in the
DisableSave critical section.
Most such tests already have NoRandomSave. Add it to the rest.
PiperOrigin-RevId: 236914708
Change-Id: Iee1cf044cfa7cb8d5aba21ddc130926218210c48
Diffstat (limited to 'test/syscalls/linux/open.cc')
| -rw-r--r-- | test/syscalls/linux/open.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/syscalls/linux/open.cc b/test/syscalls/linux/open.cc index 5770680cd..cdc226300 100644 --- a/test/syscalls/linux/open.cc +++ b/test/syscalls/linux/open.cc @@ -293,7 +293,7 @@ TEST_F(OpenTest, CanTruncateReadOnly) { // If we don't have read permission on the file, opening with // O_TRUNC should fail. -TEST_F(OpenTest, CanTruncateReadOnlyNoWritePermission) { +TEST_F(OpenTest, CanTruncateReadOnlyNoWritePermission_NoRandomSave) { // Drop capabilities that allow us to override file permissions. ASSERT_NO_ERRNO(SetCapability(CAP_DAC_OVERRIDE, false)); @@ -314,7 +314,7 @@ TEST_F(OpenTest, CanTruncateReadOnlyNoWritePermission) { // If we don't have read permission but have write permission, opening O_WRONLY // and O_TRUNC should succeed. -TEST_F(OpenTest, CanTruncateWriteOnlyNoReadPermission) { +TEST_F(OpenTest, CanTruncateWriteOnlyNoReadPermission_NoRandomSave) { const DisableSave ds; // Permissions are dropped. EXPECT_THAT(fchmod(test_file_fd_.get(), S_IWUSR | S_IWGRP), |