diff options
| author | Nicolas Lacasse <nlacasse@google.com> | 2019-04-29 10:29:14 -0700 |
|---|---|---|
| committer | Shentubot <shentubot@google.com> | 2019-04-29 10:30:24 -0700 |
| commit | 2df64cd6d2c835ce5b37a8b9111d24ad382b5d3d (patch) | |
| tree | c6a051741939cefb927ebb059ec893e5d510b618 /test/syscalls/linux/creat.cc | |
| parent | 66bca6fc221393c9553cbaa0486e07c8124e2477 (diff) | |
createAt should return all errors from FindInode except ENOENT.
Previously, createAt was eating all errors from FindInode except for EACCES and
proceeding with the creation. This is incorrect, as FindInode can return many
other errors (like ENAMETOOLONG) that should stop creation.
This CL changes createAt to return all errors encountered except for ENOENT,
which we can ignore because we are about to create the thing.
PiperOrigin-RevId: 245773222
Change-Id: I1b317021de70f0550fb865506f6d8147d4aebc56
Diffstat (limited to 'test/syscalls/linux/creat.cc')
| -rw-r--r-- | test/syscalls/linux/creat.cc | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/test/syscalls/linux/creat.cc b/test/syscalls/linux/creat.cc index 72a016b4c..df2cc0d5c 100644 --- a/test/syscalls/linux/creat.cc +++ b/test/syscalls/linux/creat.cc @@ -51,6 +51,17 @@ TEST(CreatTest, CreatTruncatesExistingFile) { EXPECT_EQ("", new_contents); } +TEST(CreatTest, CreatWithNameTooLong) { + // Start with a unique name, and pad it to NAME_MAX + 1; + std::string name = NewTempRelPath(); + int padding = (NAME_MAX + 1) - name.size(); + name.append(padding, 'x'); + const std::string& path = JoinPath(GetAbsoluteTestTmpdir(), name); + + // Creation should return ENAMETOOLONG. + ASSERT_THAT(creat(path.c_str(), kMode), SyscallFailsWithErrno(ENAMETOOLONG)); +} + } // namespace } // namespace testing |