diff options
| author | gVisor bot <gvisor-bot@google.com> | 2020-05-14 18:16:10 -0700 |
|---|---|---|
| committer | gVisor bot <gvisor-bot@google.com> | 2020-05-14 18:17:33 -0700 |
| commit | 326abf5e3643f954a295a8bbfaa6f6a47db59767 (patch) | |
| tree | ca8bf557aecb58840f6a07f45c08ddfcbfc7bc0a /test/packetimpact | |
| parent | f589a85889c815cebac624122aebe14c8263a574 (diff) | |
Internal change.
PiperOrigin-RevId: 311645222
Diffstat (limited to 'test/packetimpact')
| -rw-r--r-- | test/packetimpact/tests/BUILD | 8 | ||||
| -rw-r--r-- | test/packetimpact/tests/defs.bzl | 10 |
2 files changed, 9 insertions, 9 deletions
diff --git a/test/packetimpact/tests/BUILD b/test/packetimpact/tests/BUILD index fff7787c8..d4fcf31fa 100644 --- a/test/packetimpact/tests/BUILD +++ b/test/packetimpact/tests/BUILD @@ -19,7 +19,7 @@ packetimpact_go_test( name = "udp_recv_multicast", srcs = ["udp_recv_multicast_test.go"], # TODO(b/152813495): Fix netstack then remove the line below. - netstack = False, + expect_netstack_failure = True, deps = [ "//pkg/tcpip", "//pkg/tcpip/header", @@ -32,7 +32,7 @@ packetimpact_go_test( name = "udp_icmp_error_propagation", srcs = ["udp_icmp_error_propagation_test.go"], # TODO(b/153926291): Fix netstack then remove the line below. - netstack = False, + expect_netstack_failure = True, deps = [ "//pkg/tcpip", "//pkg/tcpip/header", @@ -116,7 +116,7 @@ packetimpact_go_test( name = "tcp_should_piggyback", srcs = ["tcp_should_piggyback_test.go"], # TODO(b/153680566): Fix netstack then remove the line below. - netstack = False, + expect_netstack_failure = True, deps = [ "//pkg/tcpip/header", "//test/packetimpact/testbench", @@ -149,7 +149,7 @@ packetimpact_go_test( name = "icmpv6_param_problem", srcs = ["icmpv6_param_problem_test.go"], # TODO(b/153485026): Fix netstack then remove the line below. - netstack = False, + expect_netstack_failure = True, deps = [ "//pkg/tcpip", "//pkg/tcpip/header", diff --git a/test/packetimpact/tests/defs.bzl b/test/packetimpact/tests/defs.bzl index 27c5de375..45dce64ab 100644 --- a/test/packetimpact/tests/defs.bzl +++ b/test/packetimpact/tests/defs.bzl @@ -106,15 +106,15 @@ def packetimpact_netstack_test( **kwargs ) -def packetimpact_go_test(name, size = "small", pure = True, linux = True, netstack = True, **kwargs): +def packetimpact_go_test(name, size = "small", pure = True, expect_linux_failure = False, expect_netstack_failure = False, **kwargs): """Add packetimpact tests written in go. Args: name: name of the test size: size of the test pure: make a static go binary - linux: generate a linux test - netstack: generate a netstack test + expect_linux_failure: expect the test to fail for Linux + expect_netstack_failure: expect the test to fail for Netstack **kwargs: all the other args, forwarded to go_test """ testbench_binary = name + "_test" @@ -127,11 +127,11 @@ def packetimpact_go_test(name, size = "small", pure = True, linux = True, netsta ) packetimpact_linux_test( name = name, - expect_failure = not linux, + expect_failure = expect_linux_failure, testbench_binary = testbench_binary, ) packetimpact_netstack_test( name = name, - expect_failure = not netstack, + expect_failure = expect_netstack_failure, testbench_binary = testbench_binary, ) |