summaryrefslogtreecommitdiffhomepage
path: root/runsc
diff options
context:
space:
mode:
authorIan Gudger <igudger@google.com>2019-03-12 14:36:58 -0700
committerShentubot <shentubot@google.com>2019-03-12 14:37:56 -0700
commita16f6e50c5a6465b94f367d62c7a46b34ef15f66 (patch)
tree6ad6ab66e1ed0c8da218f3db0afe47fc74452e06 /runsc
parent8930e79ebf72a0cc69e9b81af37bcbb57b115543 (diff)
Make HandleLocal apply to all non-loopback interfaces.
HandleLocal is very similar conceptually to MULTICAST_LOOP, so we can unify the implementations. This has the benefit of making HandleLocal apply even when the fdbased link endpoint isn't in use. In addition, move looping logic to route creation so that it doesn't need to be run for each packet. This should improve performance. PiperOrigin-RevId: 238099480 Change-Id: I72839f16f25310471453bc9d3fb8544815b25c23
Diffstat (limited to 'runsc')
-rw-r--r--runsc/boot/loader.go5
-rw-r--r--runsc/boot/network.go1
2 files changed, 3 insertions, 3 deletions
diff --git a/runsc/boot/loader.go b/runsc/boot/loader.go
index 4c7e6abfc..9ebe64dce 100644
--- a/runsc/boot/loader.go
+++ b/runsc/boot/loader.go
@@ -769,8 +769,9 @@ func newEmptyNetworkStack(conf *Config, clock tcpip.Clock) (inet.Stack, error) {
netProtos := []string{ipv4.ProtocolName, ipv6.ProtocolName, arp.ProtocolName}
protoNames := []string{tcp.ProtocolName, udp.ProtocolName, icmp.ProtocolName4}
s := epsocket.Stack{stack.New(netProtos, protoNames, stack.Options{
- Clock: clock,
- Stats: epsocket.Metrics,
+ Clock: clock,
+ Stats: epsocket.Metrics,
+ HandleLocal: true,
})}
if err := s.Stack.SetTransportProtocolOption(tcp.ProtocolNumber, tcp.SACKEnabled(true)); err != nil {
return nil, fmt.Errorf("failed to enable SACK: %v", err)
diff --git a/runsc/boot/network.go b/runsc/boot/network.go
index 40bc147ca..f025a42f1 100644
--- a/runsc/boot/network.go
+++ b/runsc/boot/network.go
@@ -138,7 +138,6 @@ func (n *Network) CreateLinksAndRoutes(args *CreateLinksAndRoutesArgs, _ *struct
FD: newFD,
MTU: uint32(link.MTU),
EthernetHeader: true,
- HandleLocal: true,
Address: mac,
PacketDispatchMode: fdbased.PacketMMap,
})